Bug 1157908 (calamares) - Review Request: calamares - Installer from a live CD/DVD/USB to disk
Summary: Review Request: calamares - Installer from a live CD/DVD/USB to disk
Keywords:
Status: CLOSED NEXTRELEASE
Alias: calamares
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2014-10-28 02:21 UTC by Kevin Kofler
Modified: 2014-12-20 08:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-11-16 02:41:43 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Kevin Kofler 2014-10-28 02:21:32 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=80&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.7.20141027git6a9c9cbaae0a9.fc21.src.rpm
Description:
Calamares is a distribution-independent installer framework, designed to install
from a live CD/DVD/USB environment to a hard disk. It includes a graphical
installation program based on Qt 5. This package includes the Calamares
framework and the required configuration files to produce a working replacement
for Anaconda's liveinst.
Fedora Account System Username: kkofler


Please note that the package currently FTBFS on Rawhide, see:
https://github.com/calamares/calamares/issues/125
It builds fine on Fedora 21 though:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/55314/
I successfully installed a Fedora Remix:
http://svn.calcforge.org/viewvc/kannolo/trunk/kickstart/
with Calamares in QEMU-KVM.

Comment 1 Kevin Kofler 2014-10-28 17:17:55 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=82&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.8.20141028git10ca85338db00.fc21.src.rpm

* Tue Oct 28 2014 Kevin Kofler <…> - 0-0.8.20141028git10ca85338db00
- New snapshot, fixes FTBFS in Rawhide (Qt 5.4.0 beta) (calamares#125)

This one should now build in Rawhide, but there are currently broken dependencies in Rawhide (due to the LLVM upgrade) that prevent it from building right now.

Comment 2 Rex Dieter 2014-10-28 17:21:39 UTC
I can work on reviewing this.

Comment 3 Kevin Kofler 2014-10-28 17:42:04 UTC
The Koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7964052
succeeded. (Koji has a newer Rawhide state than Copr.)

Comment 4 Kevin Kofler 2014-10-28 21:04:11 UTC
Note: The package targets only Fedora 21 and higher. Boost is too old on Fedora 20. I don't intend to target any EPEL branches, but if you are interested in those, you'll find that Boost is probably too old in all current EPEL branches, too.

Comment 5 Kevin Kofler 2014-11-05 01:48:28 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=84&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.9.20141104gitb9af5b7d544a7.fc21.src.rpm

* Wed Nov 05 2014 Kevin Kofler <…> - 0-0.9.20141104gitb9af5b7d544a7
- New snapshot, creates sddm.conf if missing (calamares#132), adds translations
- Use and customize the new upstream .desktop file
- Point URL to the new http://calamares.github.io/ page

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/56933/

Comment 6 Kevin Kofler 2014-11-06 22:38:23 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=87&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.10.20141106git1df44eddba572.fc21.src.rpm

* Thu Nov 06 2014 Kevin Kofler <…> - 0-0.10.20141106git1df44eddba572
- New snapshot, fixes the calamares#132 fix, calamares#124 (colors in build.log)
- Drop pkexec policy rename from desktop-file patch, fixed upstream

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/57353/

Comment 7 Kevin Kofler 2014-11-08 03:07:06 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=88&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.11.20141107gitfd5d1935290d9.fc21.src.rpm

* Fri Nov 07 2014 Kevin Kofler <…> - 0-0.11.20141107gitfd5d1935290d9
- New snapshot, fixes the calamares#132 fix again, fixes enabling translations

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/57540/

Now the SDDM autologin setup is fixed for real. (I sent 2 pull requests fixing the remaining issues in -0.10 to upstream, they merged them.) This new snapshot also actually builds and enables the translations and fixes some other minor issues.

Comment 8 Kevin Kofler 2014-11-11 23:38:25 UTC
Spec URL: http://svn.calcforge.org/viewvc/kannolo/trunk/packages/calamares/calamares.spec?revision=90&view=co
SRPM URL: https://kkofler.fedorapeople.org/kannolo/calamares-0-0.12.20141111gitfaa77d7f5e656.fc21.src.rpm

* Tue Nov 11 2014 Kevin Kofler <…> - 0-0.12.20141111gitfaa77d7f5e656
- New snapshot, writes keyboard configuration files to the installed system
  (calamares#31), adds a language selector and dynamic retranslation support

Successful Rawhide and F21 build:
https://copr.fedoraproject.org/coprs/kkofler/kannolo/build/59166/

Comment 9 Rex Dieter 2014-11-13 17:39:55 UTC
OK, finally (sorry for the delay).

naming: ok

licensing: ok
$ licensecheck  -r src | cut -d: -f2 | sort | uniq
 GPL (v2 or later)
 GPL (v3 or later)
 LGPL (v2)
 *No copyright* UNKNOWN


1.  sources: NOT ok/verifiable, source URLS give 404s:
spectool -g *.spec
Getting https://github.com/calamares/calamares/archive/faa77d7f5e65620212b6abcba9bc71e55bb78f4e/calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz to ./calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found
Getting https://github.com/calamares/partitionmanager/archive/3f1ace00592088a920f731acb1e42417f71f5e62/calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz to ./calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz
...
curl: (22) The requested URL returned error: 404 Not Found


2. SHOULD:   I'd also prefer if you used something closer to the SourceURL template on
https://fedoraproject.org/wiki/Packaging:SourceURL#Github
which has a shorter Release tag.


macros: ok

scriptlets: ok

%files: ok



I think the rest looks pretty good, please address item 1, and consider 2, thanks.

Comment 10 Rex Dieter 2014-11-13 17:48:48 UTC
Looks like my 404s were a temporary github glitch

sources are verifiable now,

$ md5sum *.gz
e5c4ff39413fc2868d96402eed72dfdc  calamares-faa77d7f5e65620212b6abcba9bc71e55bb78f4e.tar.gz
853bb899693b47d43a78e6142d07e235  calamares-partitionmanager-3f1ace00592088a920f731acb1e42417f71f5e62.tar.gz


APPROVED.

Comment 11 Kevin Kofler 2014-11-13 17:51:40 UTC
As for the length of the release tags, https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages allows up to 13 characters for the commit ID, and I'm using exactly 13.

Comment 12 Kevin Kofler 2014-11-13 23:36:17 UTC
New Package SCM Request
=======================
Package Name: calamares
Short Description: Installer from a live CD/DVD/USB to disk
Upstream URL: http://calamares.github.io/
Owners: kkofler
Branches: f21
InitialCC:

Comment 13 Gwyn Ciesla 2014-11-14 12:51:14 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2014-12-07 05:34:09 UTC
calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21

Comment 15 Fedora Update System 2014-12-20 08:45:08 UTC
calamares-0.17.0-5.20141206giteb748cca8ebfc.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.