Bug 1158109 - Review Request: xfce4-hamster-plugin - Clone of the gnome extension for xfce4
Summary: Review Request: xfce4-hamster-plugin - Clone of the gnome extension for xfce4
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1151837 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-28 15:18 UTC by Raphael Groner
Modified: 2015-07-14 16:42 UTC (History)
3 users (show)

Fixed In Version: xfce4-hamster-plugin-1.6.1-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-03 19:38:37 UTC
Type: ---
Embargoed:
kevin: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 700095 0 medium CLOSED remove incorrect fsf address or switch from error to warning 2021-02-22 00:41:40 UTC

Internal Links: 700095

Description Raphael Groner 2014-10-28 15:18:10 UTC
Spec URL: https://raphgro.fedorapeople.org/review/hamster/xfce4-hamster-plugin.spec
SRPM URL: https://raphgro.fedorapeople.org/review/hamster/xfce4-hamster-plugin-1.2-0.1.fc20.src.rpm
Description: Clone of the gnome extension for xfce4
Fedora Account System Username: raphgro

This is a pre-release in beta state at upstream. Upstream is heavily active with issues and patches. Maybe currently already worth to test at rawhide.

Comment 1 Raphael Groner 2014-10-28 15:20:11 UTC
Assigning to Kevin, as discussed in IRC. ok?

Comment 3 Kevin Fenzi 2014-11-01 19:05:14 UTC
Look for a review later today. ;)

Comment 4 Kevin Fenzi 2014-11-01 19:54:23 UTC
Release is a bit strange, if this is a 1.4 released version you should start at 
1, but perhaps you are doing that because it's in review? 

I don't see any blockers here, this package is APPROVED. 

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
     "Unknown or generated". 11 files have unknown license. Detailed output of
     licensecheck in /home/fedora/kevin/review-xfce4-hamster-
     plugin/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 122880 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: xfce4-hamster-plugin-1.4-0.2.fc22.x86_64.rpm
          xfce4-hamster-plugin-1.4-0.2.fc22.src.rpm
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US https -> HTTP
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US projecthamster -> project hamster, project-hamster, projectionist
xfce4-hamster-plugin.x86_64: W: no-manual-page-for-binary xfce4-popup-hamstermenu
xfce4-hamster-plugin.src: W: spelling-error %description -l en_US https -> HTTP
xfce4-hamster-plugin.src: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub
xfce4-hamster-plugin.src: W: spelling-error %description -l en_US projecthamster -> project hamster, project-hamster, projectionist
xfce4-hamster-plugin.src:52: W: macro-in-%changelog %find_lang
2 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint xfce4-hamster-plugin
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US https -> HTTP
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
xfce4-hamster-plugin.x86_64: W: spelling-error %description -l en_US projecthamster -> project hamster, project-hamster, projectionist
xfce4-hamster-plugin.x86_64: W: no-manual-page-for-binary xfce4-popup-hamstermenu
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
xfce4-hamster-plugin (rpmlib, GLIBC filtered):
    /bin/sh
    hamster-time-tracker
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libdbus-1.so.3()(64bit)
    libdbus-glib-1.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    libxfce4panel-1.0.so.4()(64bit)
    libxfce4ui-1.so.0()(64bit)
    libxfce4util.so.6()(64bit)
    libxfcegui4.so.4()(64bit)
    libxfconf-0.so.2()(64bit)
    rtld(GNU_HASH)



Provides
--------
xfce4-hamster-plugin:
    libhamster.so()(64bit)
    xfce4-hamster-plugin
    xfce4-hamster-plugin(x86-64)



Unversioned so-files
--------------------
xfce4-hamster-plugin: /usr/lib64/xfce4/panel/plugins/libhamster.so

Source checksums
----------------
https://github.com/projecthamster/xfce4-hamster-plugin/archive/v1.4.tar.gz#/xfce4-hamster-plugin-1.4.tar.gz :
  CHECKSUM(SHA256) this package     : 410f4432d46d1a41260f8606835622fa911f2173afe57c122a3819caba35edc9
  CHECKSUM(SHA256) upstream package : 410f4432d46d1a41260f8606835622fa911f2173afe57c122a3819caba35edc9


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -n xfce4-hamster-plugin
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 5 Raphael Groner 2014-11-02 12:46:45 UTC
Reported incorrect FSF address to upstream.
https://github.com/projecthamster/xfce4-hamster-plugin/issues/19

Comment 6 Raphael Groner 2014-11-02 12:53:50 UTC
Kevin, thanks for the review.

> Package installs a %{name}.desktop using desktop-file-install or desktop-
> file-validate if there is such a file.

This is a panel plugin, the desktop file is there to ease its usage for adding it as an item in the panel dialog. So this is a false-positive warning.

Comment 7 Raphael Groner 2014-11-02 12:57:46 UTC
New Package SCM Request
=======================
Package Name: xfce4-hamster-plugin
Short Description: Clone of the gnome extension for xfce4
Upstream URL: https://github.com/projecthamster/xfce4-hamster-plugin
Owners: raphgro
Branches: f20 f21
InitialCC:

Comment 8 Gwyn Ciesla 2014-11-03 13:58:36 UTC
Git done (by process-git-requests).

Comment 10 Gwyn Ciesla 2014-11-03 15:59:58 UTC
https://fedorahosted.org/rel-eng/ticket/6028

Comment 11 Gwyn Ciesla 2014-11-03 16:04:01 UTC
Git done (by process-git-requests).

Comment 12 Gwyn Ciesla 2014-11-03 16:45:09 UTC
Git done (by process-git-requests).

Comment 13 Kevin Fenzi 2014-11-03 17:07:43 UTC
Git done (by process-git-requests).

Comment 14 Raphael Groner 2014-11-03 18:25:55 UTC
(In reply to Raphael Groner from comment #5)
> Reported incorrect FSF address to upstream.
> https://github.com/projecthamster/xfce4-hamster-plugin/issues/19

Upstream fix is available. I expect to have it included in the next release of upstream, so doing the SCM import without any patch therefore.

Comment 15 Fedora Update System 2014-11-03 19:23:29 UTC
xfce4-hamster-plugin-1.5-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xfce4-hamster-plugin-1.5-1.fc21

Comment 16 Raphael Groner 2014-11-03 19:38:37 UTC
Please help with karma, so we could promote it as a feature in F21. 
I am not going to provide official support for F20, at least not if
anyone requests it.

Comment 17 Raphael Groner 2014-11-03 20:07:07 UTC
*** Bug 1151837 has been marked as a duplicate of this bug. ***

Comment 18 Fedora Update System 2014-11-14 20:24:22 UTC
xfce4-hamster-plugin-1.5-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xfce4-hamster-plugin-1.5-2.fc21

Comment 19 Fedora Update System 2014-11-22 11:58:50 UTC
xfce4-hamster-plugin-1.6-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xfce4-hamster-plugin-1.6-3.fc21

Comment 20 Fedora Update System 2014-12-16 21:43:13 UTC
xfce4-hamster-plugin-1.6-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xfce4-hamster-plugin-1.6-1.fc21

Comment 21 Fedora Update System 2014-12-29 09:59:53 UTC
xfce4-hamster-plugin-1.6-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 22 Raphael Groner 2015-03-26 10:35:12 UTC
Package Change Request
======================
Package Name: xfce4-hamster-plugin
New Branches: epel7
Owners: raphgro
InitialCC:

Comment 23 Gwyn Ciesla 2015-03-26 14:36:41 UTC
Git done (by process-git-requests).

Comment 24 Fedora Update System 2015-03-26 15:57:51 UTC
xfce4-hamster-plugin-1.6.1-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/xfce4-hamster-plugin-1.6.1-1.el7

Comment 25 Fedora Update System 2015-07-14 16:42:43 UTC
xfce4-hamster-plugin-1.6.1-1.el7, hamster-time-tracker-1.04-5.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.