Spec URL: https://raw.githubusercontent.com/FrostyX/tracer/master/tracer.spec SRPM URL: http://tux.inf.upol.cz/~frostyx/SRPMS/tracer-0.5.3-1.fc20.src.rpm Description: Tracer determines which applications use outdated files and prints them. For special kind of applications such as services or daemons, it suggests a standard command to restart it. Detecting whether file is outdated or not is based on a simple idea. If application has loaded in memory any version of a file which is provided by any package updated since system was booted up, tracer consider this application as outdated. Fedora Account System Username: frostyx
Taking
FAS name is just: frostyx
Summary should start with capital character. >%description >Tracer finds outdated running applications in your system. >... Do not repeat Subject in description. Simply remove that first sentence from description. > This is plugin for DNF which runs tracer after every successful transaction Missing dot at the end. Since Fedora 22 should have python3 as default, it is worth considering to move to python3. But this is not blocker and can be addressed later. I talked to Jan Zeleny and it is prefered to call the plugin "dnf-plugin-tracer". You do not need to list make as BuildRequires: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_dpkg.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_rules.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/resources/router.py 0644L /usr/bin/python tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_lang.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_applications.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_yum.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/main.py 0644L /usr/bin/python tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_portage.py 0644L /usr/bin/env tracer.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tracer/tests/test_dnf.py 0644L /usr/bin/env Either remove shebang, or set the executable flag. But having the file as non-executable and have there shebang does not have sense. Otherwise it looks good.
Thank you Miroslav, I agree with everything, so > Do not repeat Subject in description. Simply remove that first sentence from description. Fixed > Missing dot at the end. Fixed > I talked to Jan Zeleny and it is prefered to call the plugin "dnf-plugin-tracer". Renamed > You do not need to list > make > as BuildRequires: Fixed > Either remove shebang, or set the executable flag. But having the file as non-executable and have there shebang does not have sense. Fixed > Since Fedora 22 should have python3 as default, it is worth considering to move to python3. But this is not blocker and can be addressed later. It's a new for me that F22 should have python3 as default. In that case tracer will be ready before its release. There is link to new SRPM file: http://tux.inf.upol.cz/~frostyx/SRPMS/tracer-0.5.4-1.fc20.src.rpm
When you are providing updated SRPM, you should provide even updated .spec file. The same way as you done in #0. I extracted it from src.rpm this time. One little issue: make in %build should be: make %{?_smp_mflags} See: http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make But you can do that after this review. I will be watching you anyway. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. APPROVED
New Package SCM Request ======================= Package Name: tracer Short Description: finds outdated running applications in your system Upstream URL: http://tracer-package.com/ Owners: frostyx Branches: f19 f20 f21 InitialCC:
Git done (by process-git-requests).
I am sorry, my request was affected by this issue https://fedorahosted.org/rel-eng/ticket/6028 so I am setting fedora-cvs flag to "?" and posting new request here. New Package SCM Request ======================= Package Name: tracer Short Description: finds outdated running applications in your system Upstream URL: http://tracer-package.com/ Owners: frostyx Branches: f19 f20 f21 InitialCC: Thank you