Spec URL: https://arg.fedorapeople.org/reviews/docker-storage-setup/docker-storage-setup.spec SRPM URL: https://arg.fedorapeople.org/reviews/docker-storage-setup/docker-storage-setup-0.0.3-1.fc21.src.rpm Description: This is a simple service to divide available storage between the OS and docker using LVM devices. Fedora Account System Username: arg
It'd be good if there was a COPYING/LICENSE file in the upstream, in addition to the ASL 2.0 header in the script. Should capitalize Docker.
Same comment as Colin on Docker capitalization. Agreed that a LICENSE file would be nice to have, but is not required (especially given that it's just a single-file script). Review PASSED Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)". Detailed output of licensecheck in /home/mattdm/fedora/1158645-docker-storage-setup/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: docker-storage-setup-0.0.3-1.fc22.noarch.rpm docker-storage-setup-0.0.3-1.fc22.src.rpm docker-storage-setup.noarch: W: no-documentation docker-storage-setup.noarch: W: no-manual-page-for-binary docker-storage-setup 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint docker-storage-setup docker-storage-setup.noarch: W: no-documentation docker-storage-setup.noarch: W: no-manual-page-for-binary docker-storage-setup 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- docker-storage-setup (rpmlib, GLIBC filtered): /bin/bash /bin/sh cloud-utils-growpart lvm2 systemd systemd-units Provides -------- docker-storage-setup: docker-storage-setup Source checksums ---------------- https://github.com/projectatomic/docker-storage-setup/archive/0.0.3.tar.gz : CHECKSUM(SHA256) this package : c66c430f35e952fe34e1f30b00742d8f0518848d801a1194fec1cb4416195d9f CHECKSUM(SHA256) upstream package : c66c430f35e952fe34e1f30b00742d8f0518848d801a1194fec1cb4416195d9f Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1158645 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
New Package SCM Request ======================= Package Name: docker-storage-setup Short Description: A simple service to setup docker storage devices Upstream URL: https://github.com/projectatomic/docker-storage-setup Owners: arg Branches: f21 InitialCC:
Git done (by process-git-requests).
docker-storage-setup-0.0.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/docker-storage-setup-0.0.3-1.fc21
docker-storage-setup-0.0.3-1.fc21 has been pushed to the Fedora 21 testing repository.
docker-storage-setup-0.0.3-1.fc21 has been pushed to the Fedora 21 stable repository.