Spec URL: https://lsm5.fedorapeople.org/golang-github-Sirupsen-logrus/golang-github-Sirupsen-logrus.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-Sirupsen-logrus/SRPMS/golang-github-Sirupsen-logrus-0.5.1-1.fc22.src.rpm Description: Structured logger for Go Fedora Account System Username: lsm5 $ rpmlint golang-github-Sirupsen-logrus.spec SRPMS/golang-github-Sirupsen-logrus-0.5.1-1.fc22.src.rpm RPMS/noarch/golang-github-Sirupsen-logrus-devel-0.5.1-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7978514
Created attachment 952205 [details] update of spec file Missing BuildRequires on golang(github.com/stretchr/testify/assert) and test. Otherwise it is OK. Licence se correct.
reviewed and it looks good. It complies with the current go guidelines. Lokesh, though the hooks/airbrake have additional requirement that is not packaged yet "github.com/tobi/airbrake-go". Perhaps we don't Provide that yet? or also package that import?
(In reply to Jan Chaloupka from comment #1) > Created attachment 952205 [details] > update of spec file > > Missing BuildRequires on golang(github.com/stretchr/testify/assert) and > test. Otherwise it is OK. Licence se correct. %changelog * Thu Oct 30 2014 Lokesh Mandvekar <lsm5> - 0.5.1-2 - Resolves: rhbz#1158670 - initial package bug - courtesy Jan Chaloupka <jchaloup> - update dependencies - add check Spec URL: https://lsm5.fedorapeople.org/golang-github-Sirupsen-logrus/golang-github-Sirupsen-logrus.spec SRPM URL: https://lsm5.fedorapeople.org/golang-github-Sirupsen-logrus/SRPMS/golang-github-Sirupsen-logrus-0.5.1-2.fc22.src.rpm Vincent: Jan and I were talking about this a few mins back, if we're installing examples, do we need to Provide the imports in examples as well? Or just leave it to the user to get those imports?
This is optional from my point of view. It is example and if user wishes to try it, he can install the missing deps. Of course, we can package the deps too. But still we don't need it for building not for installing.
As Vincent wrote, the spec file complies with the current go guidelines. Package approved.
New Package SCM Request ======================= Package Name: golang-github-Sirupsen-logrus Short Description: Structured logger for Go Upstream URL: https://github.com/Sirupsen/logrus Owners: lsm5 jchaloup vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
Git done (by process-git-requests).
golang-github-Sirupsen-logrus-0.5.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.5.1-2.fc21
golang-github-Sirupsen-logrus-0.5.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.5.1-2.fc20
golang-github-Sirupsen-logrus-0.5.1-2.fc21 has been pushed to the Fedora 21 testing repository.
golang-github-Sirupsen-logrus-0.5.1-2.fc20 has been pushed to the Fedora 20 stable repository.
golang-github-Sirupsen-logrus-0.6.0-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.6.0-1.fc21
golang-github-Sirupsen-logrus-0.6.0-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-Sirupsen-logrus-0.6.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.6.2-1.fc20
golang-github-Sirupsen-logrus-0.6.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.6.2-1.fc21
golang-github-Sirupsen-logrus-0.6.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.6.2-1.el6
golang-github-Sirupsen-logrus-0.6.2-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-Sirupsen-logrus-0.6.2-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-Sirupsen-logrus-0.8.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.8.4-1.el6
golang-github-Sirupsen-logrus-0.8.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-Sirupsen-logrus-0.8.4-2.el6