Bug 1158925 - agent crashes on wrong metadata
Summary: agent crashes on wrong metadata
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-hosted-engine-ha
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.5.1
Assignee: Jiri Moskovcak
QA Contact: Artyom
URL:
Whiteboard: sla
Depends On:
Blocks: 1167860 1169308 1192931
TreeView+ depends on / blocked
 
Reported: 2014-10-30 14:10 UTC by Jiri Moskovcak
Modified: 2016-02-10 19:42 UTC (History)
9 users (show)

Fixed In Version: ovirt-3.5.1_rc1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1167860 1169308 (view as bug list)
Environment:
Last Closed: 2015-01-21 16:05:08 UTC
oVirt Team: SLA
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 34658 0 master MERGED agent: handle malformed metadata better Never
oVirt gerrit 35517 0 ovirt-hosted-engine-ha-1.2 MERGED agent: handle malformed metadata better Never

Description Jiri Moskovcak 2014-10-30 14:10:35 UTC 
Description of problem:
Agent crashes when there is 'null' as the engine-state in the metadata. this was observed while updating from 3.4 to 3.5

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-ha-1.2.4-1.fc19.noarch

How reproducible:
100%

Steps to Reproduce:
1. have metadata where the engine-status field is null
2. start broker and agent
3.

Actual results:
agent crashes with: AttributeError: 'NoneType' object has no attribute 'iteritems'

Expected results:
Agent ignores malformed metadata

Additional info:
Comment 1 Sven Kieske 2014-11-11 08:24:58 UTC 
(In reply to Jiri Moskovcak from comment #0)
> Description of problem:
> Agent crashes when there is 'null' as the engine-state in the metadata. this
> was observed while updating from 3.4 to 3.5

imho therefore it should block 3.5.1 release, would you mind backporting it to 3.5.1?
Comment 2 Sandro Bonazzola 2015-01-15 14:52:26 UTC 
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA
Comment 3 Artyom 2015-01-15 15:08:05 UTC 
Verified on ovirt-hosted-engine-ha-1.2.4-5.el6ev.noarch, with Jiri steps
Comment 4 Sandro Bonazzola 2015-01-21 16:05:08 UTC 
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.