Spec URL: https://gist.github.com/jakubjedelsky/9f61102d947f177ca93d SRPM URL: http://s.stderr.cz/rpm/py3status-1.6-1.fc22.src.rpm Description: Using py3status, you can take control of your i3bar easily by: - writing your own modules and have their output displayed on your bar - handling click events on your i3bar and play with them in no time - seeing your clock tick every second whatever your i3status interval No extra configuration file needed, just install & enjoy ! Fedora Account System Username: kubo Rpmlint: $ rpmlint py3status-1.6-1.fc22.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint py3status-1.6-1.fc22.noarch.rpm py3status.noarch: W: no-manual-page-for-binary py3status 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Hello I am i3 user, can you please share a direct link to the spec file, I have this error running fedora-review ERROR: 'Cannot find spec file URL'
Hi William, you're right that gist's url is not so comfortable. Please try this one: Spec URL: http://s.stderr.cz/rpm/py3status.spec
Overrall: Passed Upstream suport Python3 so you SHOULD make a python3 subpackage, but this is not a blocker, also %prep is a better place to run the rm -rf /modules, but you can check this is future releases. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [OK]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [OK]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: [OK]: Package contains no bundled libraries without FPC exception. [OK]: Changelog in prescribed format. [OK]: Sources contain only permissible code or content. [ OK: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [OK]: Package uses nothing in %doc for runtime. [OK]: Package consistently uses macros (instead of hard-coded directory names). [OK]: Package is named according to the Package Naming Guidelines. [OK]: Package does not generate any conflict. [OK]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [OK]: Requires correct, justified where necessary. [OK]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. []: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 23 files. [-]: Package complies to the Packaging Guidelines [OK]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [OK]: Package installs properly. [OK]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [OK]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [OK]: Package requires other packages for directories it uses. [OK]: Package must own all directories that it creates. [OK]: Package does not own files or directories owned by other packages. [OK]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [OK]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [OK]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [OK]: Macros in Summary, %description expandable at SRPM build time. [OK]: Package does not contain duplicates in %files. [OK]: Permissions on files are set properly. [OK]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [OK]: Package is named using only allowed ASCII characters. [OK]: Package do not use a name that already exist [OK]: Package is not relocatable. [OK]: Sources used to build the package match the upstream source, as provided in the spec URL. [OK]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [OK]: File names are valid UTF-8. [OK]: Packages must not store files under /srv, /opt or /usr/local Python: [OK]: Python eggs must not download any dependencies during the build process. [OK]: A package which is used by another package via an egg interface should provide egg info. [OK]: Package meets the Packaging Guidelines::Python [OK]: Package contains BR: python2-devel or python3-devel [OK]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [OK]: Final provides and requires are sane (see attachments). [OK]: Package functions as described. [OK]: Latest version is packaged. [OK]: Package does not include license text files separate from upstream. [OK]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [OK]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [OK]: Packages should try to preserve timestamps of original installed files. [OK]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [OK]: Sources can be downloaded from URI in Source: tag [OK]: Reviewer should test that the package builds in mock. [OK]: Buildroot is not present [OK]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [OK]: Dist tag is present (not strictly required in GL). [OK]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [OK]: SourceX is a working URL. [OK]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: py3status-1.6-1.fc20.noarch.rpm py3status-1.6-1.fc20.src.rpm py3status.noarch: W: no-manual-page-for-binary py3status 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint py3status py3status.noarch: W: no-manual-page-for-binary py3status 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- py3status (rpmlib, GLIBC filtered): /usr/bin/python2 i3status python(abi) Provides -------- py3status: py3status Source checksums ---------------- https://github.com/ultrabug/py3status/archive/1.6.tar.gz : CHECKSUM(SHA256) this package : cecc0fb7a1cc7c6bfc4845417b652eeeb144232b07680fad3466d0f8737a9506 CHECKSUM(SHA256) upstream package : cecc0fb7a1cc7c6bfc4845417b652eeeb144232b07680fad3466d0f8737a9506
Package Aproved
thanks for hints William, I'll change it with next release.
New Package SCM Request ======================= Package Name: py3status Short Description: An extensible i3status wrapper written in python Upstream URL: https://github.com/ultrabug/py3status Owners: kubo Branches: f19 f20 f21 el6 epel7
Git done (by process-git-requests).
py3status-1.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/py3status-1.6-1.el6
py3status-1.6-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/py3status-1.6-1.fc19
py3status-1.6-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/py3status-1.6-1.fc21
py3status-1.6-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/py3status-1.6-1.fc20
py3status-1.6-1.fc20 has been pushed to the Fedora 20 testing repository.
py3status-1.6-1.fc20 has been pushed to the Fedora 20 stable repository.
py3status-1.6-1.fc21 has been pushed to the Fedora 21 stable repository.
py3status-1.6-1.fc19 has been pushed to the Fedora 19 stable repository.
py3status-1.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
py3status-1.6-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/py3status-1.6-1.el7