Bug 1159221 - io-stats may crash the brick when loc->path is NULL in some fops
Summary: io-stats may crash the brick when loc->path is NULL in some fops
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1170830 1204596
TreeView+ depends on / blocked
 
Reported: 2014-10-31 09:03 UTC by Pranith Kumar K
Modified: 2015-06-19 15:18 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1170830 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:28:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2014-10-31 09:03:59 UTC
Description of problem:
Cases where loc->path is NULL, the current code in create/open/mkdir
would copy the same blindly and as a result coredump. One such case is when resolve_loc_touchup fails to get inode_path due to loops in the inode table.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-10-31 09:07:57 UTC
REVIEW: http://review.gluster.org/9029 (xlator/io-stat: Check and copy loc->path) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-11-06 05:30:34 UTC
COMMIT: http://review.gluster.org/9029 committed in master by Vijay Bellur (vbellur) 
------
commit 08109ed5a7e09ec14ecb3640cfcaf9b32d83499b
Author: Shyam <srangana>
Date:   Fri Oct 24 15:44:22 2014 -0400

    xlator/io-stat: Check and copy loc->path
    
    Cases where loc->path is NULL, the current code in create/open/mkdir
    would copy the same blindly and as a result coredump.
    
    This is a preventive fix for the coredump. The reason for loc->path
    to be NULL in certain cases is yet to be determined.
    
    One such case is when resolve_loc_touchup fails to get inode_path due
    to loops in the inode table.
    
    Change-Id: Ic2ddf2cc9f2acaf9b939afc11afd193b4402ee7c
    BUG: 1159221
    Signed-off-by: Shyam <srangana>
    Reviewed-on: http://review.gluster.org/9029
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:28:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:41 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:03 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:44:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.