Created attachment 952564 [details] timeout fix Description of problem: lockfile_check() returns a lockfile invalid/stale after only 10 seconds. This should be 5 mins. Any programs depending on this are broken. Version-Release number of selected component (if applicable): liblockfile-1.08-15 How reproducible: always Steps to Reproduce: 1. Run: $ dotlockfile lock $ dotlockfile lock $ echo $? 0 Actual results: The second lock will succeed ~10 seconds later Expected results: Should be failure (L_MAXTRIES) or a stale lock success after 5 mins. Additional info: patch attached... looks like some debugging macro code code added sometime.
Broken in F21 also.
Sorry, I fail to see, what's broken here. either a lock exists, or it doesn't.
Please compare with 1.09: http://sources.debian.net/src/liblockfile/1.09-6/lockfile.c/#L445 The lockfile exists, but the check whether it is stale/valid depends on the timeout. The lockfile should not timeout so soon. Normally, a lockfile would be valid for a much longer time unless the process _removes_ the lockfile.
Oh, and since I only saw this bz mail flying by, the Changelog of 1.09 gives confirmation: http://sources.debian.net/src/liblockfile/1.09-6/Changelog/#L5
liblockfile-1.09-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/liblockfile-1.09-1.fc21
liblockfile-1.09-1.fc21 works
Package liblockfile-1.09-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing liblockfile-1.09-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-0768/liblockfile-1.09-1.fc21 then log in and leave karma (feedback).
liblockfile-1.09-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.