Bug 1159915 - azureus 5.4 is available
Summary: azureus 5.4 is available
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: azureus
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Juran
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-03 15:20 UTC by Sergio Basto
Modified: 2014-12-26 00:25 UTC (History)
3 users (show)

Fixed In Version: azureus-5.5.0.0-1.fc21
Clone Of:
Environment:
Last Closed: 2014-12-06 09:58:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch to azureus-4.8.1.2-no-bundled-apache-commons.patch (5.33 KB, patch)
2014-11-10 01:52 UTC, Sergio Basto
no flags Details | Diff
no-bundled-apache-commons.patch.patch (1.06 KB, patch)
2014-11-10 02:11 UTC, Sergio Basto
no flags Details | Diff
no-bundled-bouncycastle.patch.patch (1.06 KB, patch)
2014-11-10 02:13 UTC, Sergio Basto
no flags Details | Diff
azureus.spec.patch (1.71 KB, patch)
2014-11-10 02:16 UTC, Sergio Basto
no flags Details | Diff
Azureus.desktop.patch (253 bytes, patch)
2014-11-10 02:18 UTC, Sergio Basto
no flags Details | Diff
no-bundled-apache-commons.patch.patch (4.55 KB, patch)
2014-11-10 02:21 UTC, Sergio Basto
no flags Details | Diff
azureus-5.3.0.0-no-bundled-bouncycastle (7.12 KB, patch)
2014-11-10 02:23 UTC, Sergio Basto
no flags Details | Diff
azureus-4.8.1.2-no-bundled-apache-commons.patch (6.87 KB, patch)
2014-11-10 02:40 UTC, Sergio Basto
no flags Details | Diff
make build in Fedora 20 and others minor fixes (2.59 KB, patch)
2014-11-13 06:09 UTC, Sergio Basto
no flags Details | Diff

Description Sergio Basto 2014-11-03 15:20:26 UTC
Last upstream release is 5.4 , and should be present in Fedora 21 at least. 
My opinion should go to Fedora 20 and 19 as weel , like kde and kernel team do (at least)

Comment 1 Sergio Basto 2014-11-10 01:52:26 UTC
Created attachment 955649 [details]
patch to azureus-4.8.1.2-no-bundled-apache-commons.patch

Hi  	
David Juran , I saw that azureus not compile from git and done the patches make it build. 
I hope that could help

Comment 2 Sergio Basto 2014-11-10 02:11:48 UTC
Created attachment 955650 [details]
no-bundled-apache-commons.patch.patch

azureus-4.8.1.2-no-bundled-apache-commons.patch changes (patch of the patch)

Comment 3 Sergio Basto 2014-11-10 02:13:11 UTC
Created attachment 955651 [details]
no-bundled-bouncycastle.patch.patch

azureus-5.3.0.0-no-bundled-bouncycastle changes ( the patch of the patch)

Comment 4 Sergio Basto 2014-11-10 02:16:35 UTC
Created attachment 955654 [details]
azureus.spec.patch

Patch to azureus.spec , make it build on Fedora 20 , not just Fedora 21+ , 
uncomment remove of org/pf

Comment 5 Sergio Basto 2014-11-10 02:18:25 UTC
Created attachment 955655 [details]
Azureus.desktop.patch

Fix the warning: /builddir/build/SOURCES/Azureus.desktop: warning: key "MimeType" is a list and does not have a semicolon as trailing character, fixing

Comment 6 Sergio Basto 2014-11-10 02:21:10 UTC
Created attachment 955656 [details]
no-bundled-apache-commons.patch.patch

the right no-bundled-apache-commons.patch.patch.

Comment 7 Sergio Basto 2014-11-10 02:23:58 UTC
Created attachment 955657 [details]
azureus-5.3.0.0-no-bundled-bouncycastle

azureus-5.3.0.0-no-bundled-bouncycastle laste version , could be more simple to use that patch of patch ...

Comment 8 Sergio Basto 2014-11-10 02:40:23 UTC
Created attachment 955659 [details]
azureus-4.8.1.2-no-bundled-apache-commons.patch

azureus-4.8.1.2-no-bundled-apache-commons.patch last version , could be easy to read and understand . 

Note in SimpleXMLParserDocumentImpl.java have this line : 
    int num = Entities.HTML40.entityValue( ref ); 
that I couldn't find a replacement and seems:
    replacement = new String( buffer, 0, buffer_pos );
for all cases is not bad .
But upstream could benefit with StringEscapeUtils of 2.x api  https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringEscapeUtils.html

escapeHtml seems to handle all Entities of a string, instead function EntityFudger of azureus code . 

You could approve me as commiter in https://admin.fedoraproject.org/pkgdb/package/azureus/


Thanks,

Comment 9 David Juran 2014-11-12 19:14:13 UTC
Thanks for the hints, I think StringEscapeUtils will do nicely. If it works fine, I'll suggest the patch for upstream as well. 
Building right now for rawhide, I'll push this for F21 shortly

Comment 10 Sergio Basto 2014-11-13 06:09:32 UTC
Created attachment 956962 [details]
make build in Fedora 20 and others minor fixes

I use Azureus-5.4.0.0 in my fedora 20 ...

Comment 11 Fedora Update System 2014-11-17 10:56:24 UTC
azureus-5.4.0.0-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/azureus-5.4.0.0-3.fc21

Comment 12 Fedora Update System 2014-11-18 12:14:41 UTC
Package azureus-5.4.0.0-3.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing azureus-5.4.0.0-3.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15273/azureus-5.4.0.0-3.fc21
then log in and leave karma (feedback).

Comment 13 Sergio Basto 2014-11-19 22:53:42 UTC
I'm testing azureus in both systems Fedora 20 and Fedora 21 , and swt from Fedora 21 doesn't render well when UI is Vuze , works well when UI is classic, I also tried swt.jar from eclipse Night builds , startup script of fedora force 
SWT=/usr/lib64/eclipse/swt.jar and to test it, I had to modified the script , but none swt.jar renders correctly since swt-4.4 .

I had report in bug 980260#c42 , swt-4.4M5-gtk-linux-x86_64.zip worked correctly, but could not find a copy on internet to prove it . also eclipse-swt from fedora 20 render well. 

btw we still have 2 old problems:
- restart doesn't work 
and 
- help -> release notes , shows:  
Welcome Window: Error loading resource: /changelog.txt

Comment 14 Sergio Basto 2014-11-19 23:30:50 UTC
yeah , an old swt.jar from eclipse-swt-4.4.0-0.2.fc21.x86_64.rpm render works better and doesn't show warnings like : 

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

(SWT:10788): GLib-GObject-CRITICAL **: g_closure_unref: assertion 'closure->ref_count > 0' failed

Comment 15 Fedora Update System 2014-11-24 20:59:22 UTC
Package azureus-5.5.0.0-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing azureus-5.5.0.0-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15273/azureus-5.5.0.0-1.fc21
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2014-12-06 09:58:27 UTC
azureus-5.5.0.0-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Sergio Basto 2014-12-07 06:25:25 UTC
(In reply to Sergio Monteiro Basto from comment #13)
> I'm testing azureus in both systems Fedora 20 and Fedora 21 , and swt from
> Fedora 21 doesn't render well when UI is Vuze , works well when UI is
> classic, I also tried swt.jar from eclipse Night builds , startup script of
> fedora force 
> SWT=/usr/lib64/eclipse/swt.jar and to test it, I had to modified the script
> , but none swt.jar renders correctly since swt-4.4 .
> 
> I had report in bug 980260#c42 , swt-4.4M5-gtk-linux-x86_64.zip worked
> correctly, but could not find a copy on internet to prove it . also
> eclipse-swt from fedora 20 render well. 

Thanks , now with swt.jar version 4.424  in ~/.azureus/app/ , azureus-5.5.0.0-1 for fc20, (with my patch ) works perfectly , loads the bundle swt.jar and execute plugins updates . 
I think azureus-5.5 should go to f20 because is more stable than others.

Comment 18 Sergio Basto 2014-12-08 04:57:19 UTC
Hi , 
the azureus-5.2.0.0-startupScript.patch, I think we should keep : 

JAVA_ARGS="-Xmx256m"

why do you removing it  ? 

Running azureus with "java -Xmx256m" , maybe we don't need the azureus-cache-size.patch 

Best regards,

Comment 19 Sergio Basto 2014-12-14 04:21:37 UTC
Hi, 
I fork http://pkgs.fedoraproject.org/git/azureus.git on github

So here are my proposes: 

https://github.com/sergiomb2/azureus/commit/2c48fcc4b5485a0e69e3ad8c15024d719c887c79

https://github.com/sergiomb2/azureus/commit/19585e1deca70210eef7351211f496ce6e9c571d

https://github.com/sergiomb2/azureus/commit/45f47bbe70ddcb6427c5594ddcf7aeddba783162 

if you want you could cheery pick them.

Now, on Fedora 20 , if we copy an swt.jar version 4.4 to ~/.azureus/app azureus works perfectly .
 
Thanks.

Comment 20 David Juran 2014-12-25 20:10:50 UTC
Hello.

In regards to #18, the memory limit was actually removed back in February in response to https://bugzilla.redhat.com/show_bug.cgi?id=1040625#c7

Regarding the azureus-cache-size.patch, it was added back in 2006. I'm not quite sure what function it holds, I'll try removing it in rawhide, let's see if anyone will complain

Comment 21 Sergio Basto 2014-12-26 00:25:36 UTC
Quoting :
"Trying to set JAVA_ARGS="-Xmx256m" from 128m to azureus script, has the result to azureus  to responsive for few minutes.

The solution was to replace azureus script to previous version. Azureus works fine after this ...."

JAVA_ARGS="-Xmx256m" is from upstream script , so "previous version" should also had -Xmx256m, the problem report there seems not be  directly with this option , I believe. 

azureus-cache-size.patch seems an antidote when not have mx256m (max memory) . So I'm trying using upstream without modifications .

Since is also about startupScript, I found solution for eclipse-swt warning, bug 1174553 
https://github.com/sergiomb2/azureus/commit/e5a23f3a418cf31b7fc50e2befc8172f7865f57c

This commit is very cool because let us update azureus plugins in Fedora 21 and 20  .


Note You need to log in before you can comment on or make changes to this bug.