Bug 1160410 - Pulp uses '__/primary/__' string to indicate primary content source
Summary: Pulp uses '__/primary/__' string to indicate primary content source
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: API/integration
Version: 2.5
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 3.0.0
Assignee: pulp-bugs
QA Contact: pulp-qe-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-04 18:04 UTC by Chris Duryee
Modified: 2015-02-28 22:43 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-28 22:43:20 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Priority Status Summary Last Updated
Pulp Redmine 608 None None None Never

Description Chris Duryee 2014-11-04 18:04:44 UTC 
Description of problem:

Currently, pulp's ContentSource class has an id field that represents source ID. In cases when the ContentSource is the primary content source, this is set to "__/primary/__".

Instead, this could just be set to "None". This would let us remove the PRIMARY_ID constant in pulp/common/constants.py.

This change is an API change so I propose that it is done with Pulp 3.0.

Version-Release number of selected component (if applicable): 2.5

Note that there is also https://bugzilla.redhat.com/show_bug.cgi?id=1135589 which moves the PRIMARY_ID definition to avoid DB initialization. The patch for that bug is more of a workaround; this BZ is to get rid of the constant entirely.
Comment 1 Brian Bouterse 2015-02-28 22:43:20 UTC 
Moved to https://pulp.plan.io/issues/608
Note You need to log in before you can comment on or make changes to this bug.