Bug 1160504

When I upgrade qemu-kvm-rhev to  qemu-kvm-rhev-2.1.2-6.el7.x86_64
,the bug also does exist.

> Bus 001 Device 004: ID 154b:6001 PNY    <---usb

Bus 1 address 4.

>     <hostdev mode='subsystem' type='usb' managed='no'>
>       <source>
>         <address bus='1' device='4'/>
>       </source>
>       <alias name='hostdev0'/>
>     </hostdev>

Likewise.

> [root@localhost songwang]# ps aux |grep qemu
[ ... ]
> -device usb-host,hostbus=1,hostaddr=7,id=hostdev0

Bus 1 address 7.  Huh?

Looks like libvirt messed something up here.

That's strange and I can't reproduce it with those devices in domain XML.

Could you please attach the full domain XML, debug logs from libvirtd (log_level=1 in /etc/libvirt/libvirtd.conf) and the QEMU log for the machine from /var/log/libvirt/qemu/?

(In reply to Gerd Hoffmann from comment #3)
> > Bus 001 Device 004: ID 154b:6001 PNY    <---usb
> 
> Bus 1 address 4.
> 
> >     <hostdev mode='subsystem' type='usb' managed='no'>
> >       <source>
> >         <address bus='1' device='4'/>
> >       </source>
> >       <alias name='hostdev0'/>
> >     </hostdev>
> 
> Likewise.
> 
> > [root@localhost songwang]# ps aux |grep qemu
> [ ... ]
> > -device usb-host,hostbus=1,hostaddr=7,id=hostdev0
> 
> Bus 1 address 7.  Huh?
> 
> Looks like libvirt messed something up here.

I'm so sorry to make you misunderstand for the  messages. Libvirt shows messages without error.Maybe it is my fault because I have done the test some times so that I copied the code not corresponding to the xml.I am so sorry for that!

(In reply to Jan Tomko from comment #4)
> That's strange and I can't reproduce it with those devices in domain XML.
> 
> Could you please attach the full domain XML, debug logs from libvirtd
> (log_level=1 in /etc/libvirt/libvirtd.conf) and the QEMU log for the machine
> from /var/log/libvirt/qemu/?

libvirt-1.2.8-5.el7.x86_64
qemu-kvm-rhev-2.1.2-6.el7.x86_64
kernel-3.10.0-195.el7.x86_64


1.[root@localhost songwang]# lsusb
Bus 001 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 002 Device 002: ID 8087:0024 Intel Corp. Integrated Rate Matching Hub
Bus 003 Device 002: ID 17ef:6019 Lenovo 
Bus 003 Device 003: ID 04b3:3025 IBM Corp. NetVista Full Width Keyboard
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 003: ID 154b:6001 PNY      <----usb

2.[root@localhost ~]# virsh dumpxml aa
<domain type='kvm'>
  <name>aa</name>
  <uuid>23d19d5a-ee01-4a2b-bec9-948fca512c00</uuid>
  <memory unit='KiB'>1048576</memory>
  <currentMemory unit='KiB'>1048576</currentMemory>
  <vcpu placement='static' current='2'>4</vcpu>
  <os>
    <type arch='x86_64' machine='pc-i440fx-rhel7.1.0'>hvm</type>
    <boot dev='hd'/>
  </os>
  <features>
    <acpi/>
    <apic/>
    <pae/>
  </features>
  <clock offset='utc'/>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>restart</on_crash>
  <devices>
    <emulator>/usr/libexec/qemu-kvm</emulator>
    <disk type='file' device='disk'>
      <driver name='qemu' type='raw' cache='none'/>
      <source file='/var/lib/libvirt/images/r7.img'/>
      <target dev='vda' bus='virtio'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </disk>
    <disk type='block' device='cdrom'>
      <driver name='qemu' type='raw'/>
      <target dev='hda' bus='ide'/>
      <readonly/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <controller type='usb' index='0' model='ich9-ehci1'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x7'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci1'>
      <master startport='0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0' multifunction='on'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci2'>
      <master startport='2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x1'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci3'>
      <master startport='4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x2'/>
    </controller>
    <controller type='pci' index='0' model='pci-root'/>
    <controller type='virtio-serial' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </controller>
    <controller type='ide' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
    </controller>
    <interface type='network'>
      <mac address='52:54:00:4c:dd:e2'/>
      <source network='default'/>
      <model type='virtio'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </interface>
    <serial type='pty'>
      <target port='0'/>
    </serial>
    <console type='pty'>
      <target type='serial' port='0'/>
    </console>
    <input type='tablet' bus='usb'/>
    <input type='mouse' bus='ps2'/>
    <input type='keyboard' bus='ps2'/>
    <graphics type='spice' autoport='yes'/>
    <sound model='ich6'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </sound>
    <video>
      <model type='qxl' ram='65536' vram='65536' heads='1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>
    <hostdev mode='subsystem' type='usb' managed='no'>
      <source>
        <address bus='1' device='3'/>
      </source>
    </hostdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <memballoon model='virtio'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/>
    </memballoon>
  </devices>
</domain>

3.[root@localhost ~]# ps aux |grep qemu-kvm
qemu      6927 20.8  3.4 3611544 270544 ?      Sl   10:31   0:13 /usr/libexec/qemu-kvm -name aa -S -machine pc-i440fx-rhel7.1.0,accel=kvm,usb=off -m 1024 -realtime mlock=off -smp 2,maxcpus=4,sockets=4,cores=1,threads=1 -uuid 23d19d5a-ee01-4a2b-bec9-948fca512c00 -no-user-config -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/aa.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -boot strict=on -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x5.0x7 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pci.0,multifunction=on,addr=0x5 -device ich9-usb-uhci2,masterbus=usb.0,firstport=2,bus=pci.0,addr=0x5.0x1 -device ich9-usb-uhci3,masterbus=usb.0,firstport=4,bus=pci.0,addr=0x5.0x2 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x6 -drive file=/var/lib/libvirt/images/r7.img,if=none,id=drive-virtio-disk0,format=raw,cache=none -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x7,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -drive if=none,id=drive-ide0-0-0,readonly=on,format=raw -device ide-cd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -netdev tap,fd=25,id=hostnet0,vhost=on,vhostfd=26 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:4c:dd:e2,bus=pci.0,addr=0x3 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -device usb-tablet,id=input0 -spice port=5900,addr=127.0.0.1,disable-ticketing,seamless-migration=on -device qxl-vga,id=video0,ram_size=67108864,vram_size=67108864,bus=pci.0,addr=0x2 -device intel-hda,id=sound0,bus=pci.0,addr=0x4 -device hda-duplex,id=sound0-codec0,bus=sound0.0,cad=0 -chardev spicevmc,id=charredir0,name=usbredir -device usb-redir,chardev=charredir0,id=redir0 -chardev spicevmc,id=charredir1,name=usbredir -device usb-redir,chardev=charredir1,id=redir1 -chardev spicevmc,id=charredir2,name=usbredir -device usb-redir,chardev=charredir2,id=redir2 -chardev spicevmc,id=charredir3,name=usbredir -device usb-redir,chardev=charredir3,id=redir3 -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x8 -msg timestamp=on

4.check usb device in guest
login in guest
#lsusb
Bus 001 Device 002: ID:0627:0001 Adomax Technology Co., Ltd
Bus 004 Device 002: ID:0409:55aa NEC Corp. Hub
Bus 001 Device 001: ID:1d6b:0002 Linux Foudation 2.0 root hub
Bus 002 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 003 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 004 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub

I can not find usb device

Created attachment 954777 [details]
QEMU log

Created attachment 954778 [details]
Libvirtd log

what happens if you remove one of the four usbredir devices?

when I only remove one of the four usbredir devices in xml 

login in guest, then guest can show the usb device correctly.
#lsusb
Bus 001 Device 002: ID:0627:0001 Adomax Technology Co., Ltd
Bus 001 Device 003: ID:154b:6001 PNY
Bus 001 Device 001: ID:1d6b:0002 Linux Foudation 2.0 root hub
Bus 002 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 003 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 004 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub

(In reply to Gerd Hoffmann from comment #9)
> what happens if you remove one of the four usbredir devices?

additional info :

Scenario 1:
 " <controller type='usb' index='0' model='ich9-uhci3'>
      <master startport='4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x2'/>
    </controller>
"
when I only remove this in xml 

login in guest, then guest can show the usb device correctly.
#lsusb
Bus 001 Device 002: ID:0627:0001 Adomax Technology Co., Ltd
Bus 001 Device 003: ID:154b:6001 PNY
Bus 001 Device 001: ID:1d6b:0002 Linux Foudation 2.0 root hub
Bus 002 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 003 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub


Scenario 2:
" <controller type='usb' index='0' model='ich9-uhci2'>
      <master startport='2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x1'/>
    </controller>
"
when I only remove this in xml 

login in guest, then guest can't show the usb device correctly.
#lsusb
Bus 001 Device 002: ID:0627:0001 Adomax Technology Co., Ltd
Bus 003 Device 002: ID:0409:55aa NEC Corp. Hub
Bus 001 Device 001: ID:1d6b:0002 Linux Foudation 2.0 root hub
Bus 002 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub
Bus 003 Device 001: ID:1d6b:0001 Linux Foudation 1.1 root hub

Your "PHY" device most likely requires USB2 then, and due to your configuration it isn't connected to a usb2 capable port.

There are 6 root ports @ ehci.  usb2 works with them.  The usb hub emulated by qemu (device 3:2) supports usb1 only though.

With 4 redir devices one port is taken by the usb tablet, four ports by the redir devices.  Then qemu goes plug a usn-hub into the sixth port to avoid running out of ports, and the usb-host device is plugged into the hub.  So it ends up on a port which doesn't support usb2.

What you can do about it?

(1) use less usb-redir devices.

(2) explicitly assign devices to ports, using
    <address type='usb' bus='0' port='$nr'/>
    With $nr between 1 and 6 (with ehci).
    In that case qemu will not auto-plug usb hubs.

Unlike with pci devices libvirt doesn't auto-generate address tags for usb devices.  Maybe that should be fixed.

(In reply to Gerd Hoffmann from comment #12)
> Your "PHY" device most likely requires USB2 then, and due to your
> configuration it isn't connected to a usb2 capable port.

Can QEMU detect the issue?

(In reply to Gerd Hoffmann from comment #12)
> Your "PHY" device most likely requires USB2 then, and due to your
> configuration it isn't connected to a usb2 capable port.
> 
> There are 6 root ports @ ehci.  usb2 works with them.  The usb hub emulated
> by qemu (device 3:2) supports usb1 only though.
> 
> With 4 redir devices one port is taken by the usb tablet, four ports by the
> redir devices.  Then qemu goes plug a usn-hub into the sixth port to avoid
> running out of ports, and the usb-host device is plugged into the hub.  So
> it ends up on a port which doesn't support usb2.
> 
> What you can do about it?
> 
> (1) use less usb-redir devices.
> 
> (2) explicitly assign devices to ports, using
>     <address type='usb' bus='0' port='$nr'/>
>     With $nr between 1 and 6 (with ehci).
>     In that case qemu will not auto-plug usb hubs.
> 
> Unlike with pci devices libvirt doesn't auto-generate address tags for usb
> devices.  Maybe that should be fixed.

Thanks for your answer to solve the problem! if users don't know the rules when setting up the parameters like the xml,they will meet the same problem .Maybe qemu also should detect the issue to show error messages for the user to know the error.

addional info:
I run the test in the same machine.For qemu-kvm-1.5.3-77.el7.x86_64, the problem doesn't exist.

(In reply to Song Wang from comment #15)
> addional info:
> I run the test in the same machine.For qemu-kvm-1.5.3-77.el7.x86_64, the
> problem doesn't exist.

Oh, *that* is surprising.

Can you attach 'lspci -t' from both host and guest (running 1.5.3) please?

What kind of device is this?

(In reply to Gerd Hoffmann from comment #16)
> (In reply to Song Wang from comment #15)
> > addional info:
> > I run the test in the same machine.For qemu-kvm-1.5.3-77.el7.x86_64, the
> > problem doesn't exist.
> 
> Oh, *that* is surprising.
> 
> Can you attach 'lspci -t' from both host and guest (running 1.5.3) please?
> 
> What kind of device is this?
Run the test as bug shows,then:
USB device
host:
[root@host1 songwang]# lspci -t
-[0000:00]-+-00.0
           +-02.0
           +-14.0
           +-16.0
           +-16.3
           +-19.0
           +-1a.0
           +-1b.0
           +-1d.0
           +-1e.0-[01]--
           +-1f.0
           +-1f.2
           \-1f.3

guest:
#lspci -t
-[0000:00]-+-00.0
           +-01.0
           +-01.1
           +-01.3
           +-02.0
           +-03.0
           +-04.0
           +-05.0
           +-05.1
           +-05.2
           +-05.7
           +-07.0
           \-08.0

(In reply to Song Wang from comment #17)
> (In reply to Gerd Hoffmann from comment #16)

> [root@host1 songwang]# lspci -t
> -[0000:00]-+-00.0

Oops.  I've meant "lsusb -t", sorry.

(In reply to Gerd Hoffmann from comment #18)
> (In reply to Song Wang from comment #17)
> > (In reply to Gerd Hoffmann from comment #16)
> 
> > [root@host1 songwang]# lspci -t
> > -[0000:00]-+-00.0
> 
> Oops.  I've meant "lsusb -t", sorry.

host:
[root@host1 songwang]# lsusb -t
/:  Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 5000M
/:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/4p, 480M
    |__ Port 2: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
    |__ Port 3: Dev 3, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
/:  Bus 02.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/3p, 480M
    |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/8p, 480M
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/3p, 480M
    |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/6p, 480M
        |__ Port 2: Dev 14, If 0, Class=Mass Storage, Driver=usb-storage, 480M

guest:
[root@oolong ~]# lsusb -t
/:  Bus 04.Port 1: Dev 1, Class=root_hub, Driver=uhci_hcd/2p, 12M
    |__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/8p, 12M
/:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=uhci_hcd/2p, 12M
/:  Bus 02.Port 1: Dev 1, Class=root_hub, Driver=uhci_hcd/2p, 12M
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/6p, 480M
    |__ Port 1: Dev 2, If 0, Class=Human Interface Device, Driver=usbhid, 480M

http://patchwork.ozlabs.org/patch/410003/

patch posted.

test builds: http://people.redhat.com/ghoffman/bz1160504/

Fix included in qemu-kvm-rhev-2.1.2-11.el7

*** Bug 1165478 has been marked as a duplicate of this bug. ***

Reproduce:
Version of components:
qemu-kvm-rhev-2.1.2-7.el7.x86_64


1, On the host:
# lsusb
...
Bus 001 Device 008: ID 1516:6221 CompUSA
...

2, Boot guest and use above usb stick via "usb-host". Cli as followings(The same with comment 6):
# /usr/libexec/qemu-kvm -name aa -S -machine pc-i440fx-rhel7.1.0,accel=kvm,usb=off -m 1024 -realtime mlock=off -smp 2,maxcpus=4,sockets=4,cores=1,threads=1 -uuid 23d19d5a-ee01-4a2b-bec9-948fca512c00 -no-user-config -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/aa.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -boot strict=on -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x5.0x7 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pci.0,multifunction=on,addr=0x5 -device ich9-usb-uhci2,masterbus=usb.0,firstport=2,bus=pci.0,addr=0x5.0x1 -device ich9-usb-uhci3,masterbus=usb.0,firstport=4,bus=pci.0,addr=0x5.0x2 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x6 -drive file=/root/sn-r7.img,if=none,id=drive-virtio-disk0,format=qcow2,cache=none -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x7,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -drive if=none,id=drive-ide0-0-0,readonly=on,format=raw -device ide-cd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -netdev tap,fd=25,id=hostnet0,vhost=on -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:4c:dd:e2,bus=pci.0,addr=0x3 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -device usb-tablet,id=input0 -spice port=5901,disable-ticketing,seamless-migration=on -device qxl-vga,id=video0,ram_size=67108864,vram_size=67108864,bus=pci.0,addr=0x2 -device intel-hda,id=sound0,bus=pci.0,addr=0x4 -device hda-duplex,id=sound0-codec0,bus=sound0.0,cad=0 -chardev spicevmc,id=charredir0,name=usbredir -device usb-redir,chardev=charredir0,id=redir0 -chardev spicevmc,id=charredir1,name=usbredir -device usb-redir,chardev=charredir1,id=redir1 -chardev spicevmc,id=charredir2,name=usbredir -device usb-redir,chardev=charredir2,id=redir2 -chardev spicevmc,id=charredir3,name=usbredir -device usb-redir,chardev=charredir3,id=redir3 -device usb-host,hostbus=1,hostaddr=8,id=hostdev0 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x8 -monitor stdio -boot menu=on

3, After guest boot up, check the usb stick inside guest, can not find this usb stick.

As above show, this bz has been reproduced.
==============
Verfiy:
Version of components:
qemu-kvm-rhev-2.1.2-14.el7.x86_64

steps and command line just as above show, after step3, can use this usb stick inside guest correctly.

As above show, this bz has been verified. 
==============

So set this bz with verify. Any issue, please correct me.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0624.html

*** Bug 1164695 has been marked as a duplicate of this bug. ***