Spec URL: https://comzeradd.fedorapeople.org/specs/seafile-client.spec SRPM URL: https://comzeradd.fedorapeople.org/srpms/seafile-client-3.1.8-1.fc21.src.rpm Description: Seafile is a next-generation open source cloud storage system, with advanced support for file syncing, privacy protection and teamwork. Fedora Account System Username: comzeradd
updated to 4.1.4 Spec: https://comzeradd.fedorapeople.org/specs/seafile-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/seafile-client-4.1.4-1.fc21.src.rpm
Updated to 5.1.1 and made a couple of changes more, since seafile switched to qt5 in the meantime. Spec: https://comzeradd.fedorapeople.org/specs/seafile-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/seafile-client-5.1.1-1.fc24.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in seafile-client See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 278 files have unknown license. Detailed output of licensecheck in /home/jenselme/Downloads/1160672 -seafile-client/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in seafile- client-debuginfo [-]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: seafile-client-5.1.1-1.fc25.x86_64.rpm seafile-client-debuginfo-5.1.1-1.fc25.x86_64.rpm seafile-client-5.1.1-1.fc25.src.rpm seafile-client.x86_64: W: no-manual-page-for-binary seafile-applet 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: seafile-client-debuginfo-5.1.1-1.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- seafile-client-debuginfo.x86_64: W: invalid-url URL: http://seafile.com/ <urlopen error [Errno -2] Name or service not known> seafile-client.x86_64: W: invalid-url URL: http://seafile.com/ <urlopen error [Errno -2] Name or service not known> seafile-client.x86_64: W: no-manual-page-for-binary seafile-applet 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jenselme/Downloads/1160672-seafile-client/srpm/seafile-client.spec 2016-06-02 13:28:12.403764945 +0200 +++ /home/jenselme/Downloads/1160672-seafile-client/srpm-unpacked/seafile-client.spec 2016-06-02 12:55:28.000000000 +0200 @@ -65,5 +65,4 @@ * Wed Jun 01 2016 Nikos Roussos <comzeradd> - 5.1.1-1 - Update to 5.1.1 -- Switch to qt5 * Mon Feb 08 2016 Nikos Roussos <comzeradd> - 5.0.4-1 Requires -------- seafile-client-debuginfo (rpmlib, GLIBC filtered): seafile-client (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Test.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libccnet.so.0()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libevent-2.0.so.5()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjansson.so.4()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libseafile.so.0()(64bit) libsearpc.so.1()(64bit) libsqlite3.so.0()(64bit) libssl.so.10()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) rtld(GNU_HASH) Provides -------- seafile-client-debuginfo: seafile-client-debuginfo seafile-client-debuginfo(x86-64) seafile-client: application() application(seafile.desktop) seafile-client seafile-client(x86-64) Source checksums ---------------- https://github.com/haiwen/seafile-client/archive/v5.1.1.tar.gz : CHECKSUM(SHA256) this package : 0148cbdb97dcd58e6ebec738c8f6bc476192f0b9156f0783199f1213c4d0322f CHECKSUM(SHA256) upstream package : 0148cbdb97dcd58e6ebec738c8f6bc476192f0b9156f0783199f1213c4d0322f Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1160672 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks. I update the SRPM with the right SPEC. I also took the chance to use the https upstream url and add an appdata file to look nice on Software Center. I'll open an upstream PR for the appdata. SPEC: https://comzeradd.fedorapeople.org/specs/seafile-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/seafile-client-5.1.1-2.fc24.src.rpm
> gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in seafile-client > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache That's still missing. Once this is done, I'll approve the package. > . I also took the chance to use the https upstream url and add an appdata file to look nice on Software Center Good.
I completely missed that. SPEC: https://comzeradd.fedorapeople.org/specs/seafile-client.spec SRPM: https://comzeradd.fedorapeople.org/srpms/seafile-client-5.1.1-3.fc24.src.rpm
Looks good. Approved!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/seafile-client
seafile-5.1.2-3.fc24 seafile-client-5.1.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6aa664154f
seafile-5.1.2-3.fc24, seafile-client-5.1.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6aa664154f
seafile-5.1.2-3.fc24, seafile-client-5.1.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.