Bug 1161102

REVIEW: http://review.gluster.org/9069 (cluster/afr : Prevent excessive logging of split-brain messages.) posted (#1) for review on release-3.5 by Anuradha Talur (atalur)

Explanation of patch sent for fix -

Currently, gluster volume heal <VOLNAME> info command results in
logging split-brain messages(when split-brain is detected).

Shruthi raised this bug : https://bugzilla.redhat.com/show_bug.cgi?id=1122492,
reporting excessive logging.
She had run heal info command repeatedly with a sleep of 1 minute in between
and the size of log file grew to 9GB.

The log message that repeated was as follows-
afr-self-heal-common.c:234:afr_sh_print_split_brain_log] 0-vol1-replicate-0: Unable to self-heal contents of '33f5c4c3-eef6-47b5-bb67-fdf5407b3d37' (possible split-brain). Please delete the file from all but the preferred subvolume.- Pending matrix:  [ [ 0 2 ] [ 5 0 ] ]

My patch tries to reduce these split-brain log messages.
When heal info command is run, this log-message won't be reported anymore.
Instead, a message indicating split-brain will be displayed in the output of
heal info command itself.

Sample output -
Brick <hostname:brickpath>
<gfid:304c2117-6907-4b8c-b0de-7c83535a9d06> - Is in split-brain
Number of entries: 1

Brick <hostname:brickpath>
<gfid:304c2117-6907-4b8c-b0de-7c83535a9d06> - Is in split-brain
Number of entries: 1

Note that the patch suppresses split-brain log messages only for
heal info command. This message will still be logged by other means.

REVIEW: http://review.gluster.org/9069 (cluster/afr : Prevent excessive logging of split-brain messages.) posted (#2) for review on release-3.5 by Anuradha Talur (atalur)

REVIEW: http://review.gluster.org/9069 (cluster/afr : Prevent excessive logging of split-brain messages.) posted (#3) for review on release-3.5 by Anuradha Talur (atalur)

COMMIT: http://review.gluster.org/9069 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit c11c9deb3cf77101c7e440522ab8f5961f815222
Author: Anuradha <atalur>
Date:   Thu Nov 13 10:59:52 2014 +0530

    cluster/afr : Prevent excessive logging of split-brain messages.
    
            Running the volume heal info command would result in
    excessive logging of split-brain messages. After this patch,
    running heal info command will not log the split brain messages.
    This info is now displayed in the output of heal info command
    instead.
    If a file is in split-brain, a message "Is in split-brain"
    will be written against its name.
    
    Change-Id: Ib8979be04f5ac7c59ce3ad1185886bb54b8be808
    BUG: 1161102
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/9069
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.4, please reopen this bug report.

glusterfs-3.5.4 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/2
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user