Created attachment 954427 [details]
in TestRangeMapper.h with:
FAIL! : TestRangeMapper::linearUpBackward() Compared doubles are not the same (fuzzy compare)
Actual (rm.getValueForPositionUnclamped(0)): -2.23517e-08
Expected (0.0) : 0
FAIL! : TestRangeMapper::linearDownBackward() Compared doubles are not the same (fuzzy compare)
Actual (rm.getValueForPositionUnclamped(9)): -2.23517e-08
Expected (0.0) : 0
Tests fail due QCOMPARE is using qFuzzyCompare to compare floats internally, which may fail when one of a compared value is 0.0(documented behaviour, but bit perplexing as it's not affecting x86 in this case, probably rounding error...).
Proposed workaround from documentation is not working, as it results in 1!=1. But using qFuzzyIsNull(undocumented, but used/recommended(see up mentioned bug)) in combination with QVERIFY result in tests pass on all Fedora kojis.
Scratch builds with patch:
In attachment is patch doing these changes.
Patch sent to upstream ML firstname.lastname@example.org.
sonic-visualiser-2.4.1-2.fc20 has been submitted as an update for Fedora 20.
sonic-visualiser-2.4.1-2.fc21 has been submitted as an update for Fedora 21.
sonic-visualiser-2.4.1-2.fc19 has been submitted as an update for Fedora 19.
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing sonic-visualiser-2.4.1-2.fc19'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
sonic-visualiser-2.4.1-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
sonic-visualiser-2.4.1-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
sonic-visualiser-2.4.1-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.