Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1161124

Summary:	small memory leak in migration
Product:	Red Hat Enterprise Linux 7	Reporter:	Ján Tomko <jtomko>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.1	CC:	dyuan, lhuang, rbalakri, zhwang, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.2.8-7.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 07:47:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ján Tomko 2014-11-06 12:52:03 UTC

Description of problem:
A few bytes are leaked when migrating.

Version-Release number of selected component (if applicable):
libvirt-1.2.8-6.el7

How reproducible:
99.997 %

Steps to Reproduce:
1. host1# valgrind --leak-check=full libvirtd
2. migrate a domain to host1

Actual results:
==10274== 232 bytes in 1 blocks are definitely lost in loss record 669 of 758
==10274==    at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10274==    by 0x52A2BF3: virAlloc (viralloc.c:144)
==10274==    by 0x1D49AD70: qemuMigrationCookieAddStatistics (qemu_migration.c:554)
==10274==    by 0x1D49AD70: qemuMigrationBakeCookie (qemu_migration.c:1228)
==10274==    by 0x1D4A43B8: qemuMigrationFinish (qemu_migration.c:5002)
==10274==    by 0x1D4C9339: qemuDomainMigrateFinish3Params (qemu_driver.c:11526)
==10274==    by 0x538D7B0: virDomainMigrateFinish3Params (libvirt.c:7078)
==10274==    by 0x125CDD: remoteDispatchDomainMigrateFinish3Params (remote.c:5734)
==10274==    by 0x125CDD: remoteDispatchDomainMigrateFinish3ParamsHelper (remote_dispatch.h:5789)
==10274==    by 0x53F5841: virNetServerProgramDispatchCall (virnetserverprogram.c:437)
==10274==    by 0x53F5841: virNetServerProgramDispatch (virnetserverprogram.c:307)
==10274==    by 0x15029C: virNetServerProcessMsg (virnetserver.c:172)
==10274==    by 0x15029C: virNetServerHandleJob (virnetserver.c:193)
==10274==    by 0x52FA5E4: virThreadPoolWorker (virthreadpool.c:145)
==10274==    by 0x52F9F7D: virThreadHelper (virthread.c:197)
==10274==    by 0x8516DF2: start_thread (in /usr/lib64/libpthread-2.17.so)


Expected results:
The statistics are properly freed.

Additional info:
Upstream patch:
https://www.redhat.com/archives/libvir-list/2014-November/msg00148.html

Comment 1 Ján Tomko 2014-11-06 12:54:26 UTC

Fixed upstream by:
commit 1d1c5ecd1360d74292a5db18fbd90fe27ec2551b
Author:     Ján Tomko <jtomko>
AuthorDate: 2014-11-06 12:24:46 +0100
Commit:     Ján Tomko <jtomko>
CommitDate: 2014-11-06 13:52:33 +0100

    Free job statistics from the migration cookie
    
    ==404== 232 bytes in 1 blocks are definitely lost in loss record 669 of 758
    ==404==    at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==404==    by 0x52A2BF3: virAlloc (viralloc.c:144)
    ==404==    by 0x1D49AD70: qemuMigrationCookieAddStatistics (qemu_migration.c:554)
    ==404==    by 0x1D49AD70: qemuMigrationBakeCookie (qemu_migration.c:1228)
    ==404==    by 0x1D4A43B8: qemuMigrationFinish (qemu_migration.c:5002)
    ==404==    by 0x1D4C9339: qemuDomainMigrateFinish3Params (qemu_driver.c:11526)
    
    Introduced by commit 5d6fb96

git describe: v1.2.10-25-g1d1c5ec

Comment 5 zhenfeng wang 2014-11-19 10:52:58 UTC

I can reproduce this bug with libvirt-1.2.8-6.el7 with the comment 0's step 

#virsh migrate --live rhel7 qemu+ssh://$target_ip/system --verbose
# valgrind --leak-check=full libvirtd
--
==1493== 8 bytes in 1 blocks are definitely lost in loss record 70 of 689
==1493==    at 0x4C2BB0A: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==1493==    by 0x529A37F: virReallocN (viralloc.c:245)
==1493==    by 0x5331202: virDomainObjListExport (domain_conf.c:20804)
==1493==    by 0x538B4E2: virConnectListAllDomains (libvirt.c:8960)
==1493==    by 0x129FBE: remoteDispatchConnectListAllDomains (remote.c:1551)
==1493==    by 0x129FBE: remoteDispatchConnectListAllDomainsHelper (remote_dispatch.h:1072)
==1493==    by 0x53EDFF1: virNetServerProgramDispatchCall (virnetserverprogram.c:437)
==1493==    by 0x53EDFF1: virNetServerProgramDispatch (virnetserverprogram.c:307)
==1493==    by 0x1501FC: virNetServerProcessMsg (virnetserver.c:172)
==1493==    by 0x1501FC: virNetServerHandleJob (virnetserver.c:193)
==1493==    by 0x52F26C4: virThreadPoolWorker (virthreadpool.c:145)
==1493==    by 0x52F205D: virThreadHelper (virthread.c:197)
==1493==    by 0x7C64DF2: start_thread (in /usr/lib64/libpthread-2.17.so)
==1493==    by 0x837605C: clone (in /usr/lib64/libc-2.17.so)

==1493== 232 bytes in 1 blocks are definitely lost in loss record 608 of 689
==1493==    at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==1493==    by 0x529A283: virAlloc (viralloc.c:144)
==1493==    by 0x1C493049: qemuMigrationCookieStatisticsXMLParse (qemu_migration.c:902)
==1493==    by 0x1C493049: qemuMigrationCookieXMLParse (qemu_migration.c:1143)
==1493==    by 0x1C493049: qemuMigrationCookieXMLParseStr (qemu_migration.c:1172)
==1493==    by 0x1C493049: qemuMigrationEatCookie (qemu_migration.c:1254)
==1493==    by 0x1C497032: qemuMigrationConfirmPhase (qemu_migration.c:3109)
==1493==    by 0x1C499491: qemuMigrationConfirm (qemu_migration.c:3203)
==1493==    by 0x5386266: virDomainMigrateConfirm3Params (libvirt.c:7123)
==1493==    by 0x125A00: remoteDispatchDomainMigrateConfirm3Params (remote.c:5795)
==1493==    by 0x125A00: remoteDispatchDomainMigrateConfirm3ParamsHelper (remote_dispatch.h:5635)
==1493==    by 0x53EDFF1: virNetServerProgramDispatchCall (virnetserverprogram.c:437)
==1493==    by 0x53EDFF1: virNetServerProgramDispatch (virnetserverprogram.c:307)
==1493==    by 0x1501FC: virNetServerProcessMsg (virnetserver.c:172)
==1493==    by 0x1501FC: virNetServerHandleJob (virnetserver.c:193)
==1493==    by 0x52F26C4: virThreadPoolWorker (virthreadpool.c:145)
==1493==    by 0x52F205D: virThreadHelper (virthread.c:197)
==1493==    by 0x7C64DF2: start_thread (in /usr/lib64/libpthread-2.17.so)
==1493== 
==1493== 464 bytes in 2 blocks are definitely lost in loss record 637 of 689
==1493==    at 0x4C2B934: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==1493==    by 0x529A283: virAlloc (viralloc.c:144)
==1493==    by 0x1C4924E0: qemuMigrationCookieAddStatistics (qemu_migration.c:552)
==1493==    by 0x1C4924E0: qemuMigrationBakeCookie (qemu_migration.c:1217)
==1493==    by 0x1C494A6F: qemuMigrationRun (qemu_migration.c:3735)
==1493==    by 0x1C495B73: doNativeMigrate (qemu_migration.c:3817)
==1493==    by 0x1C49B71B: qemuMigrationPerformPhase (qemu_migration.c:4628)
==1493==    by 0x1C49B71B: qemuMigrationPerform (qemu_migration.c:4714)
==1493==    by 0x1C4C198C: qemuDomainMigratePerform3Params (qemu_driver.c:11690)
==1493==    by 0x5385C5B: virDomainMigratePerform3Params (libvirt.c:7034)
==1493==    by 0x125ED3: remoteDispatchDomainMigratePerform3Params (remote.c:5678)
==1493==    by 0x125ED3: remoteDispatchDomainMigratePerform3ParamsHelper (remote_dispatch.h:6006)
==1493==    by 0x53EDFF1: virNetServerProgramDispatchCall (virnetserverprogram.c:437)
==1493==    by 0x53EDFF1: virNetServerProgramDispatch (virnetserverprogram.c:307)
==1493==    by 0x1501FC: virNetServerProcessMsg (virnetserver.c:172)
==1493==    by 0x1501FC: virNetServerHandleJob (virnetserver.c:193)
==1493==    by 0x52F26C4: virThreadPoolWorker (virthreadpool.c:145)

also the mem leak has gone while i update the libvirt to libvirt-1.2.8-7,  so 
mark this bug verified

Comment 7 errata-xmlrpc 2015-03-05 07:47:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html