Bug 1161366 - wrong journalctl parameters in upgrade-post
Summary: wrong journalctl parameters in upgrade-post
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: fedup-dracut
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Will Woods
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: https://fedoraproject.org/wiki/Common...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-07 02:27 UTC by Serge Pavlovsky
Modified: 2015-11-09 19:50 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-11-09 19:50:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Serge Pavlovsky 2014-11-07 02:27:35 UTC
Description of problem:

upgrade-post runs journalctl -a -m >/var/log/upgrade.log
i.e. it processes whole jornal from beginning of time, not just upgrade part


Steps to Reproduce:
1. upgrade with several gigabytes of system journal files

Actual results:
enjoy several hours of upgrade-post[19174]: writing logs to disk and rebooting


Expected results:
journalctl -bam >/var/log/upgrade-real.log
completes instantly

Additional info:
add -b switch to journalctl cmdline

Comment 1 Will Woods 2014-11-10 17:14:56 UTC
Hey, yeah, fixing the logging means that we're now dumping the entire journal. Whoops. Thanks for catching this.

Fixed in git:

    https://github.com/wgwoods/fedup-dracut/commit/cde5f2d


Should be fixed for the F21 final release.

Comment 2 Zbigniew Jędrzejewski-Szmek 2014-12-10 20:16:45 UTC
Please remove the -m too.

Comment 3 Will Woods 2014-12-10 21:52:22 UTC
Oh, hell. This missed F21, unfortunately.

Still, I'll remove the '-m' upstream and rebuild to ensure this is fixed for F22.

Comment 4 Zbigniew Jędrzejewski-Szmek 2014-12-10 21:55:02 UTC
(In reply to Will Woods from comment #3)
> Oh, hell. This missed F21, unfortunately.
Majority of people do not have journals from other machines, and even if they do, those machines don't get a chance to run during fedup upgrade anyway, so it's mostly a cosmetic issue.
 
> Still, I'll remove the '-m' upstream and rebuild to ensure this is fixed for
> F22.
Thanks!

Comment 5 Bradley 2014-12-11 12:23:54 UTC
Can this fix be backported to F20 too? (The fedup instructions already tell users to make sure that they have the latest version)

Comment 6 Will Woods 2014-12-11 14:50:29 UTC
No, it can't. The script that writes out the journal is part of the upgrade.img in the boot media / install trees, which are frozen at release time.

Comment 7 John Gotts 2015-04-06 21:35:43 UTC
It's definitely not cosmetic. It added an additional 20 minutes to my fedup upgrade on a fairly new laptop. It's writing out logs dating back to February 21st.

Comment 8 Zbigniew Jędrzejewski-Szmek 2015-04-07 13:14:19 UTC
Sure, it's not cosmetic, but cannot be fixed (see comment #c6).

Comment 9 Fedora End Of Life 2015-11-04 15:57:28 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Jan Pazdziora 2015-11-09 13:38:16 UTC
Should this be CURRENTRELEASE with Fedora 22? I dislike to see bugs go EOLed ...

Comment 11 Will Woods 2015-11-09 19:50:59 UTC
No, it should be EOL, since fedup is EOL'd after F21.


Note You need to log in before you can comment on or make changes to this bug.