Bug 1161487 - Review Request: collada2gltf - an open-source command-line pipeline tool that converts COLLADA to glTF
Summary: Review Request: collada2gltf - an open-source command-line pipeline tool that...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1161483
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-07 08:40 UTC by David Tardon
Modified: 2017-10-30 07:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-10-30 07:39:19 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Tardon 2014-11-07 08:40:27 UTC
Spec URL: https://dtardon.fedorapeople.org/rpm/collada2gltf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/collada2gltf-0-1.fc21.src.rpm
Description:
collada2gltf is an open-source command-line pipeline tool that converts COLLADA to glTF.

Fedora Account System Username: dtardon

Comment 3 Ganapathi Kamath 2015-06-06 21:30:18 UTC
I think the main binary bin/collada2gltf that ought to be built is not built/included in the rpm. 
the source file collada2gltf/main.cpp seems not be used

$ rpm -qa | grep  collada2gltf
collada2gltf-0-3.fc22.x86_64
$ rpm -ql collada2gltf
/usr/lib64/libcollada2gltfConvert.so.0.0
/usr/share/doc/collada2gltf
/usr/share/doc/collada2gltf/LICENSE.md

Comment 4 Ganapathi Kamath 2015-06-06 21:46:36 UTC
$ cd ${BUILDROOT}/COLLADA2GLTF

$ mkdir bin

$ g++ main.cpp -lstdc++ -lcollada2gltfConvert -I /usr/include/collada2gltf/GLTF -I /usr/include/rapidjson -I /usr/include/collada2gltf -I /usr/include/collada2gltf/JSON -I /usr/include/collada2gltf/assetModifiers -I /usr/include/COLLADASaxFrameworkLoader -I /usr/include/COLLADABaseUtils -I /usr/include/COLLADAFramework -I /usr/include/collada2gltf/helpers -lOpenCOLLADABaseUtils -lOpenCOLLADAFramework -lOpenCOLLADASaxFrameworkLoader -lOpenCOLLADAStreamWriter -o bin/collada2gltf

main.cpp:267:15: warning: extra tokens at end of #ifndef directive

$  ls  bin/collada2gltf 
bin/collada2gltf

Comment 5 David Tardon 2015-06-07 16:42:33 UTC
(In reply to Ganapathi Kamath from comment #3)
> I think the main binary bin/collada2gltf that ought to be built is not
> built/included in the rpm. 

I do not build it because I do not need it.

Comment 6 Ganapathi Kamath 2015-06-07 20:13:36 UTC
well, that's just my review comment. 
The bin-tool might be useful to others, and that's why the specfile needs to be updated to include and additionally build the bin-tool as well.
I had a dae file, I was just checking out what a gltf file looked like.
The name "collada2gltf" suggests that it provides a tool, not just a library, and that's what I was expecting. 
The srpms you made were helpful, your efforts are very much appreciated.

Comment 7 David Tardon 2015-06-07 20:47:07 UTC
If anyone needs more than the library, he can become a co-maintainer and do the work himself. Or, even better, he can take over. I have got no use for collada2gltf myself--it is simply a dependency of libreoffice that needs to be packaged.

Comment 8 David Tardon 2017-10-30 07:39:19 UTC
I don't need this anymore.


Note You need to log in before you can comment on or make changes to this bug.