Spec URL: https://lupinix.fedorapeople.org/kde-plasma-redshift.spec SRPM URL: https://lupinix.fedorapeople.org/kde-plasma-redshift-1.0-1.fc20.src.rpm Description: Redshift plasmoid provides a configuration interface and allows to start/stop redshift daemon either manually or automatically based on the current activity. Fedora Account System Username: lupinix Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091863 Koji build f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091883 Koji build f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091889 Koji build f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8091893 Thank you for review in advance!
Some initial comments, 1. SHOULD use BuildRequires: kdelibs4-devel (instead of kdelibs-devel, in case kdelibs-devel ever moves to v5) 2. in %files SHOULD use %{_kde4_iconsdir}/hicolor/*/*/* instead and relatedly... 3. MUST include icon cache scriplets per https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Thanks for your useful comments :) I will include this soon.
Spec URL: https://lupinix.fedorapeople.org/kde-plasma-redshift.spec SRPM URL: https://lupinix.fedorapeople.org/kde-plasma-redshift-1.0-2.fc20.src.rpm Koji build rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8092782 Fixed the issues :)
I can review this today.
naming: ok sources: ok 32b142c966d496e50bebb599e374b1c0 v1.0.tar.gz license: ok scriptlets: ok macros: ok You may want to consider updating project URL, sources to point to http://simgunz.org/projects/redshift-plasmoid Otherwise, simple and clean, APPROVED.
Thank you for reviewing the package :) Will update the URL.
New Package SCM Request ======================= Package Name: kde-plasma-redshift Short Description: Plasmoid for redshift Upstream URL: http://simgunz.org/projects/redshift-plasmoid Owners: lupinix Branches: f20 f21 InitialCC:
Git done (by process-git-requests).
kde-plasma-redshift-1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/kde-plasma-redshift-1.0-2.fc21
kde-plasma-redshift-1.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kde-plasma-redshift-1.0-2.fc20
kde-plasma-redshift-1.0-2.fc20 has been pushed to the Fedora 20 testing repository.
kde-plasma-redshift-1.0-2.fc21 has been pushed to the Fedora 21 stable repository.
kde-plasma-redshift-1.0-2.fc20 has been pushed to the Fedora 20 stable repository.