Bug 1162680 - Data Assignments Editor doesn't load all data assignments where DataInput and DataOutput contains same variable names
Summary: Data Assignments Editor doesn't load all data assignments where DataInput and...
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: jBPM Designer
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: CR1
: 6.0.2
Assignee: Tihomir Surdilovic
QA Contact: Sona Mala
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-11 13:02 UTC by Sona Mala
Modified: 2020-03-27 18:37 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-03-27 18:37:42 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot of problem (70.55 KB, image/png)
2014-11-11 16:36 UTC, Sona Mala
no flags Details
JS error in console (100.76 KB, image/png)
2014-11-12 09:11 UTC, Sona Mala
no flags Details
designer-plugins.js to be used for testing (366.96 KB, text/plain)
2014-11-13 16:22 UTC, Tihomir Surdilovic
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1119231 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Bugzilla 1149123 1 None None None 2021-01-20 06:05:38 UTC
Red Hat Bugzilla 1152826 0 urgent CLOSED Process Designer's Data Assignments editor overwrite existing data assignment when we try to add new data assignment. 2021-02-22 00:41:40 UTC

Internal Links: 1119231 1149123 1152826

Description Sona Mala 2014-11-11 13:02:32 UTC
Description of problem:
Data Assignment Editor cannot load these Data Assignments:
  procVar -> myVar; myVar -> procVar

where:
  'procVar' is process variable,
  'myVar' is data input and data output of same task.

Please check bz 1119231 for more information.


Version-Release number of selected component (if applicable):
roll up patch 6.0.3_1_2014 build 2 and 3 (both product BPMS and BRMS)


Steps to Reproduce:
1. Create a simple process Start->HumanTask->End
2. Define process variable: 'procVar'
3. Define data input of task: 'myVar'
4. Define data output of task: 'myVar'
5. Open Data Assignment Editor and define these assignments:
    - Data Input: procVar->myVar
    - Data Output: myVar->procVar
6. Save assignments
7. Reopen Data Assignment Editor

Actual results:
There is only one data assignment.

Expected results:
All assignments which were saved should be present.

Additional info:

Comment 2 Sona Mala 2014-11-11 16:36:29 UTC
Created attachment 956355 [details]
Screenshot of problem

Data assignment input shows two assignemnts, but the editor just one.

Comment 3 Sona Mala 2014-11-11 16:39:51 UTC
Even if this problem does not occur in the first build of patch, the problem can be present in any commit of patch. The first build changed just property-view.js and it did not change compressed javascript files like designer-plugin.js.

Comment 4 Sona Mala 2014-11-11 16:42:17 UTC
The productization repository contains an commit which does not represent any bugzilla issue and probably it was cherrypicked from master to 6.0.x.

https://github.com/droolsjbpm/jbpm-designer/commit/14b986cb19b2ddd4b5ef69d441c176dce57294fc

Comment 7 Sona Mala 2014-11-12 09:10:49 UTC
Data Assignment editor cannot be opened any more.

Firebug console returns:
ReferenceError: dataassignmentProxy is not defined

Please correct me if I am wrong:
- you have deleted just this code in the commit:

var dataassignmentProxy = new Ext.data.MemoryProxy({
  root: []
});


But this variable has got only one useage which has not been deleted yet:

...
reader: new Ext.data.JsonReader({
    root: "root"
  }, DataAssignment),
proxy: dataassignmentProxy,
sorters: [
...

Comment 8 Sona Mala 2014-11-12 09:11:48 UTC
Created attachment 956625 [details]
JS error in console

Comment 9 Sona Mala 2014-11-12 09:29:27 UTC
I have checked commit on branches and I found out that 6.2.x, 6.1.x and master are same but 6.0.x is totaly different.

Maybe the problem is a backporting from master to 6.0.x branch.

Comment 10 Sona Mala 2014-11-12 09:35:20 UTC
I can confirm that changes at master was done at 6.0.x branch too, but unfortunately there is the another change which broke Data Assignment Editor and I cannot check it now.

Comment 12 Tihomir Surdilovic 2014-11-12 15:30:16 UTC
fixed merge problem in 6.0.x:

https://github.com/droolsjbpm/jbpm-designer/commit/ed12a6347a89b8a058d6389caafed710a7ec9ac4

For the patch the file needed to be included into the patch after a build is 

${project.build.directory}/classes/org/jbpm/designer/public/js/compressed/designer-plugins.js

Comment 13 Kris Verlaenen 2014-11-12 16:05:26 UTC
Waiting for further verification, moving back to assigned.

Comment 14 Tihomir Surdilovic 2014-11-12 22:33:54 UTC
the fix for the merge problem and the particular test case of this bz is in the 6.0.x branch. it would help if QA could verify it to make sure we are all clear to go

Comment 16 Ryan Zhang 2014-11-13 06:00:37 UTC
The patch zip has been updated in the same folder, Please verify again.

bfb196bcdc7812c96f8851b96708f081  BZ-1146248.zip

Comment 17 Sona Mala 2014-11-13 10:44:42 UTC
This issue was fixed. I need to check issues of patch again. Just to be sure that the fix does not break other issues.

Comment 18 Sona Mala 2014-11-13 10:46:22 UTC
This commit has broke bz 1149123.

Comment 19 Tihomir Surdilovic 2014-11-13 16:22:09 UTC
Commit to 6.0.x for the regression of metioned BZ 1149123:

6.0.x: https://github.com/droolsjbpm/jbpm-designer/commit/b4645acdc


I have attached the corresponding output JS file to this BZ which you can use to quickly test without waiting on the build (just replace the one in your distro with the attached).

Comment 20 Tihomir Surdilovic 2014-11-13 16:22:51 UTC
Created attachment 957220 [details]
designer-plugins.js to be used for testing

Comment 21 Sona Mala 2014-11-13 20:54:57 UTC
This issue has been fixed by the last commit. The full regression test suite runs with this fix without problems. It was tested with java7 x fedora20 x firefox. I do not expect another regression issue.

Comment 22 Ryan Zhang 2014-11-14 07:42:28 UTC
OK, I have rebuilt the jbpm-designer with the latest code. (See: https://brewweb.devel.redhat.com/buildinfo?buildID=398783 )
The patch files has been packed in Rollup distributions. Please verify.
8687000b63317478278e5af571d7b691  BZ-1146248.zip

Comment 23 Tihomir Surdilovic 2014-12-15 18:23:14 UTC
fix is not also in designer 6.2.x branch


Note You need to log in before you can comment on or make changes to this bug.