Spec URL: https://www.happyassassin.net/reviews/php-phpseclib-crypt-base/php-phpseclib-crypt-base.spec SRPM URL: https://www.happyassassin.net/reviews/php-phpseclib-crypt-base/php-phpseclib-crypt-base-0.3.9-1.fc21.src.rpm Description: This class is required by all of phpseclib's specific cipher implementations. It is not used directly by anything else. Fedora Account System Username: adamwill phpseclib has grown a base class for crypto implementations, I need a package for it to get up to phpseclib 0.3.9. Without this, the rest of the suite is broken.
*** Bug 1162995 has been marked as a duplicate of this bug. ***
Created attachment 956613 [details] phpci.log phpCompatInfo version 3.5.0 static analyze results
Created attachment 956614 [details] review.txt Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
MUST [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/pear/Crypt => add %dir %{pear_phpdir}/Crypt (and of course you can drop ownership of this dir from packages which require base) SHOULD [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. => please open a bug and add link
Just did a ninja bump which changes the directory ownership, thanks for the catch (I'll adjust dependent packages later). Can't remember if we talked to upstream about licenses already, I'll look into it. Thanks. for the phpci, for the record, mcrypt dep is optional.
$ colordiff -u php-phpseclib-crypt-base.spec.00 php-phpseclib-crypt-base.spec --- php-phpseclib-crypt-base.spec.00 2014-11-12 08:37:39.000000000 +0100 +++ php-phpseclib-crypt-base.spec 2014-11-12 09:21:56.000000000 +0100 @@ -63,7 +63,7 @@ %files %{pear_xmldir}/%{name}.xml -%{pear_phpdir}/Crypt/Base.php +%{pear_phpdir}/Crypt === APPROVED ===
New Package SCM Request ======================= Package Name: php-phpseclib-crypt-base Short Description: Base class for phpseclib cipher implementations Owners: adamwill Branches: f19 f20 f21 el6 epel7 InitialCC: (still adamw, I split my bugzilla accounts a while back, sorry)
Git done (by process-git-requests).
This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now.