Bug 1163435 - Build installed tests for gnome-photos
Summary: Build installed tests for gnome-photos
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-photos
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Mathieu Bridon
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-12 16:53 UTC by Vadim Rutkovsky
Modified: 2014-11-17 17:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-17 17:10:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Build tests package (1.54 KB, patch)
2014-11-12 17:04 UTC, Vadim Rutkovsky
no flags Details | Diff

Description Vadim Rutkovsky 2014-11-12 16:53:34 UTC
Installed tests should be built in separate package (similar to glib2-tests and gtk3-tests). See attached patch for .spec file.

I've also built this package at https://copr.fedoraproject.org/coprs/vrutkovs/desktop-tests/build/59241/ and tests worked correctly for me


This was verified for F21 also, so please cherry-pick this on f21 branch

Comment 1 Vadim Rutkovsky 2014-11-12 17:04:23 UTC
Created attachment 956809 [details]
Build tests package

Comment 2 Mathieu Bridon 2014-11-17 17:10:01 UTC
Thanks for the patch. Just a minor nitpick: next time, please provide a patch in « git format-patch » format, so it's just a tiny little bit easier to apply. :P

In any case, I just pushed the patch to Rawhide and F21.

However, I built it only for Rawhide, as it didn't make much sense to push an update to F21 and make users update their system for such a small change that has no user-visible impact.

It's in Git though, so it will get built next time there's an update to gnome-photos in F21 (for example, if we get a 3.14.3 or something).


Note You need to log in before you can comment on or make changes to this bug.