Spec URL: https://mayorga.fedorapeople.org/python-flask-uwsgi-websocket.spec SRPM URL: https://mayorga.fedorapeople.org/python-flask-uwsgi-websocket-0.2.5-1.fc20.src.rpm Description: High-performance WebSockets for your Flask apps powered by uWSGI. Low-level uWSGI WebSocket API access and flexible high-level abstractions for building complex WebSocket applications with Flask. Supports several different concurrency models including Gevent. Inspired by Flask-Sockets. Fedora Account System Username: mayorga
Just some quick comments: - 'Requires: python-Flask' seems wrong, the package is named python-flask - The tag 'Group:' is obsolete - The python3 install must be first
(In reply to Fabian Affolter from comment #1) > Just some quick comments: > > - 'Requires: python-Flask' seems wrong, the package is named python-flask Done. > - The tag 'Group:' is obsolete I'll leave it as I'm going for EPEL too. > - The python3 install must be first In this case it doesn't matter because it does not write any file in %{_bindir} or other common location. Spec URL: https://fedorapeople.org/~mayorga/python-flask-uwsgi-websocket.spec SRPM URL: https://mayorga.fedorapeople.org/python-flask-uwsgi-websocket-0.2.10-1.fc20.src.rpm
Hi, - Can you please update to 0.4.1? - You should close the %if 0%{?with_python3} after the package description and not just before - Be more specific in the files you include. See: https://fedoraproject.org/wiki/Packaging:Python#Files_to_include
Any progress?
Spec URL: https://mayorga.fedorapeople.org/python-flask-uwsgi-websocket.spec SRPM URL: https://mayorga.fedorapeople.org/python-flask-uwsgi-websocket-0.4.4-1.fc22.src.rpm * Fri Jul 24 2015 Eduardo Mayorga Téllez <mayorga> - 0.4.4-1 - Update to 0.4.4 - %%files section more specific
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [X]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -flask-uwsgi-websocket [X]: Package functions as described. [ ]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-flask-uwsgi-websocket-0.4.4-1.fc24.noarch.rpm python3-flask-uwsgi-websocket-0.4.4-1.fc24.noarch.rpm python-flask-uwsgi-websocket-0.4.4-1.fc24.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python3-flask-uwsgi-websocket (rpmlib, GLIBC filtered): python(abi) python3-flask uwsgi-plugin-python3 python-flask-uwsgi-websocket (rpmlib, GLIBC filtered): python(abi) python-flask uwsgi-plugin-python Provides -------- python3-flask-uwsgi-websocket: python3-flask-uwsgi-websocket python-flask-uwsgi-websocket: python-flask-uwsgi-websocket Source checksums ---------------- https://pypi.python.org/packages/source/F/Flask-uWSGI-WebSocket/Flask-uWSGI-WebSocket-0.4.4.tar.gz : CHECKSUM(SHA256) this package : c9387509f71ec0646c057222bccc8953bdba6e22a1f268d18a7426bdfbdfc3dd CHECKSUM(SHA256) upstream package : c9387509f71ec0646c057222bccc8953bdba6e22a1f268d18a7426bdfbdfc3dd Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1163559 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 For your information, the python guidelines doesn't recommend the use of %py3dir any more. Now, you should use a python2 subdirectory for python2 builds and python3 directory for python3 builds. See: https://fedoraproject.org/wiki/Packaging:Python#Building_more_than_once Not a blocker, so marking this package as approved.
New Package SCM Request ======================= Package Name: python-flask-uwsgi-websocket Short Description: High-performance WebSockets for your Flask apps powered by uWSGI Upstream URL: https://github.com/zeekay/flask-uwsgi-websocket Owners: mayorga Branches: f22 f23 InitialCC:
Git done (by process-git-requests).
python-flask-uwsgi-websocket-0.4.4-2.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/python-flask-uwsgi-websocket-0.4.4-2.fc23
python-flask-uwsgi-websocket-0.4.4-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-flask-uwsgi-websocket-0.4.4-2.fc22
python-flask-uwsgi-websocket-0.4.4-2.fc23 has been pushed to the Fedora 23 testing repository.
python-flask-uwsgi-websocket-0.4.4-2.fc23 has been pushed to the Fedora 23 stable repository.
python-flask-uwsgi-websocket-0.4.4-2.fc22 has been pushed to the Fedora 22 stable repository.