Bug 1163701 - [RFE] Better name for the "Reset all" button
Summary: [RFE] Better name for the "Reset all" button
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vladimír Slávik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-13 10:20 UTC by cornel panceac
Modified: 2021-04-30 07:42 UTC (History)
8 users (show)

Fixed In Version: anaconda-34.7-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-30 07:42:06 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description cornel panceac 2014-11-13 10:20:56 UTC
Description of problem:
i have added some partitions, i'm not satisifed with the outcome and i want to cancel. there's no cancel button.

Version-Release number of selected component (if applicable):
fedora 21 beta workstation x86_64

How reproducible:
always


Steps to Reproduce:
1.enter manual partitioning screen
2.add partitions
3.cancel all cahnges you've just added

Actual results:
you can't cancel the changes

Expected results:
there is a big nice cancel button there

Additional info:
i have two free space regions on my hard disk, and anaconda places the partitions in the unwanted free space region. So i want to go to text mode and use fdisk fro this.

Comment 1 Martin Kolman 2014-11-13 12:05:57 UTC
Well, there is a rather big "Reset all" button in the lower right corner of the screen - does that do what you want ?

Also if you want to do partitioning manually from the command line, that is also possible - just don't forget to press the "Reload storage configuration changes" button in the lower left. Anaconda will rescan all disks, so you can use your manually created storage configuration for the installation.

Comment 2 cornel panceac 2014-11-13 12:49:28 UTC
well, i have no idea what is "Reset all" doing. My belief was that it resets the device partition table. It is doing something else?

Comment 3 Martin Kolman 2014-11-13 13:05:10 UTC
(In reply to cornel panceac from comment #2)
> well, i have no idea what is "Reset all" doing. My belief was that it resets
> the device partition table. It is doing something else?
It resets all the changes you made in the manual partitioning screen back to the initial state. Note that we don't make changes to the disks until you start the installation (see the note above the "Reset all" button).

Comment 4 cornel panceac 2014-11-13 13:20:20 UTC
ah, then maybe a box may describe this when hover the mouse cursor. anyway, i would change the button label to "Reset all changes". 
on the other hand, isn't it more or less what reload storage config from disk button is doing?

Comment 5 Martin Kolman 2014-11-13 13:56:59 UTC
(In reply to cornel panceac from comment #4)
> ah, then maybe a box may describe this when hover the mouse cursor. anyway,
> i would change the button label to "Reset all changes".
That sounds like a good idea - do you mind if I switch the bug to an enahncement request so we can track this ?

> on the other hand, isn't it more or less what reload storage config from
> disk button is doing?
There is one important difference - "Reset all" only reverts all changes made in the UI back to the state after the initial scan modRana did when it was starting up - this should be more or less instant.  

On the other hand "reload" rescans all available storage devices, which might need considerable time to complete, especially for more complicated storage setups.

Comment 6 cornel panceac 2014-11-13 14:05:05 UTC
Please make all changes you find necessary. At the time of creation i did not know thhat button resets only the changes, so i did not filed a Request For Enhancement myself :)

Comment 7 Martin Kolman 2014-11-13 14:21:21 UTC
(In reply to cornel panceac from comment #6)
> Please make all changes you find necessary. At the time of creation i did
> not know thhat button resets only the changes, so i did not filed a Request
> For Enhancement myself :)

OK, I've renamed the bug and moved it to Rawhide branch as it is too late to change this for Fedora 21 as we are already in string freeze & rather close to release.

Comment 8 cornel panceac 2014-11-13 14:25:00 UTC
Thank you very much.

Comment 9 Adam Williamson 2019-12-12 01:02:13 UTC
It's still called Reset All as of F31.

Comment 10 Vladimír Slávik 2020-09-09 12:57:01 UTC
PR with changes: https://github.com/rhinstaller/anaconda/pull/2841

Comment 11 Vladimír Slávik 2020-09-24 15:50:00 UTC
PR merged.


Note You need to log in before you can comment on or make changes to this bug.