Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1163821

Summary: Current timer implementation has no way to avoid some races
Product: [Community] GlusterFS Reporter: Xavi Hernandez <jahernan>
Component: coreAssignee: Xavi Hernandez <jahernan>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1163822 (view as bug list) Environment:
Last Closed: 2016-11-23 07:28:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1163822    

Description Xavi Hernandez 2014-11-13 14:33:28 UTC 
Description of problem:

With the current implementation of timers in gluster, there are some situations that cannot be handled in a safe way. This could lead to race conditions, causing crashes or other unexpected side effects.

Version-Release number of selected component (if applicable): master

Additional info:

A clear example is the release of resources after cancelling a timer (the timer could have not been really cancelled and the callback will run anyway but the caller of gf_timer_call_cancel() has no way to know it).

Additionally, it's not possible to determine if a timer callback has been executed or not, or synchronize with it and know if it has been executed successfully.
Comment 1 Anand Avati 2014-12-19 12:27:57 UTC 
REVIEW: http://review.gluster.org/9316 ([WIP] libglusterfs: Improved timer implementation) posted (#1) for review on master by Xavier Hernandez (xhernandez)
Comment 2 Anand Avati 2015-01-08 10:15:54 UTC 
REVIEW: http://review.gluster.org/9316 ([WIP] libglusterfs: Improved timer implementation) posted (#2) for review on master by Xavier Hernandez (xhernandez)
Comment 3 Mike McCune 2016-03-28 23:46:11 UTC 
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Comment 4 Xavi Hernandez 2016-11-23 07:28:19 UTC 
Timer implementation has already been fixed in some places to avoid the major problems, so this patch is not needed anymore.