Red Hat Bugzilla – Bug 1163917
/var/www/openshift/broker/httpd/broker.conf is not marked as a configuration file
Last modified: 2015-02-12 08:09:29 EST
Description of problem: Any modifications made to the configuration file /var/www/openshift/broker/httpd/broker.conf are overwritten when the package 'openshift-origin-broker' is updated. The file is not marked as a configuration file in the rpm configuration. Version-Release number of selected component (if applicable): openshift-origin-broker-1.16.1.13-1.el6op.noarch How reproducible: Always Steps to Reproduce: 1. Make changes to the file /var/www/openshift/broker/httpd/broker.conf on an out-of-date OSE environment. 2. Update the openshift-origin-broker rpm 3. Actual results: Changes overwritten Expected results: Changes remain. Additional info: # rpm -qc openshift-origin-broker-1.16.1.13-1.el6op.noarch /etc/httpd/conf.d/000002_openshift_origin_broker_proxy.conf /etc/httpd/conf.d/000002_openshift_origin_broker_servername.conf /etc/openshift/broker-dev.conf /etc/openshift/broker.conf /etc/openshift/quickstarts.json /var/www/openshift/broker/config/environments/development.rb /var/www/openshift/broker/config/environments/production.rb
It's hard to see much reason for a customer modifying this file (it is basically just the httpd wrapper to the broker, which shouldn't need anything in the way of tuning). If a customer has a good use case for changing it, we certainly want to support that, but if not, having the RPM able to overwrite it could be useful for consistency if we ever need to change it. We could just mark it as a config file and still have it overwrite the user's changes. There is an oo-diagnostics check to look for the .rpmsave file that would be created if a user ever did modify this file and have it overwritten. That would probably be wise as we can't always anticipate good use cases.
https://github.com/openshift/origin-server/pull/6033 causes this file and httpd.conf to be marked as conf files, still overwriting them on update, but making a backup which can be detected by oo-diagnostics, and users can easily compare the changes. I do not think we want users to edit these files in general. Should we find a need to edit them ourselves, it is likely to be the kind of change that we want to force on users. If a user really feels this is the right place for them to edit a conf file, they can always chattr +i the file to prevent it being reset by an update. If there is a reasonable use case for this, it would be a good argument for making it %config(noreplace).
Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/092f7feafde9d2372f38c8248e5175de78f9075c broker: mark broker httpd confs as conf files https://bugzilla.redhat.com/show_bug.cgi?id=1163917 Bug 1163917 - /var/www/openshift/broker/httpd/broker.conf is not marked as a configuration file
Check on puddle-2-2-2015-01-23 1. check the configuration for the old package # rpm -qc openshift-origin-broker-1.16.2.2-1.el6op.noarch /etc/httpd/conf.d/000002_openshift_origin_broker_proxy.conf /etc/httpd/conf.d/000002_openshift_origin_broker_servername.conf /etc/openshift/broker-dev.conf /etc/openshift/broker.conf /etc/openshift/quickstarts.json /var/www/openshift/broker/config/environments/development.rb /var/www/openshift/broker/config/environments/production.rb 2. check the configuration file for the latest package # rpm -qc openshift-origin-broker.noarch 0:1.16.2.3-1.el6op /etc/httpd/conf.d/000002_openshift_origin_broker_proxy.conf /etc/httpd/conf.d/000002_openshift_origin_broker_servername.conf /etc/openshift/broker-dev.conf /etc/openshift/broker.conf /etc/openshift/quickstarts.json /var/www/openshift/broker/config/environments/development.rb /var/www/openshift/broker/config/environments/production.rb /var/www/openshift/broker/httpd/broker.conf /var/www/openshift/broker/httpd/httpd.conf
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0220.html