Bug 1163917
| Summary: | /var/www/openshift/broker/httpd/broker.conf is not marked as a configuration file | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Timothy Williams <tiwillia> |
| Component: | Node | Assignee: | Luke Meyer <lmeyer> |
| Status: | CLOSED ERRATA | QA Contact: | libra bugs <libra-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.2.0 | CC: | bleanhar, cryan, erich, jokerman, libra-onpremise-devel, mmccomas, xiama |
| Target Milestone: | --- | Keywords: | EasyFix, Upstream |
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | openshift-origin-broker-1.16.2.3-1 | Doc Type: | Bug Fix |
| Doc Text: |
Cause: RPM packaging did not properly mark /var/www/openshift/broker/httpd/broker.conf and /var/www/openshift/broker/httpd/httpd.conf as configuration files.
Consequence: /var/www/openshift/broker/httpd/broker.conf and /var/www/openshift/broker/httpd/httpd.conf were overwritten on broker upgrades losing local changes.
Fix: RPM packaging now marks /var/www/openshift/broker/httpd/broker.conf and /var/www/openshift/broker/httpd/httpd.conf as a configuration files.
Result: If an admin has modified the contents of /var/www/openshift/broker/httpd/broker.conf or /var/www/openshift/broker/httpd/httpd.conf those changes are preserved in a files suffixed with '.rpmsave'. It is not advised to modify these files.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-12 13:09:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Timothy Williams
2014-11-13 17:13:18 UTC
It's hard to see much reason for a customer modifying this file (it is basically just the httpd wrapper to the broker, which shouldn't need anything in the way of tuning). If a customer has a good use case for changing it, we certainly want to support that, but if not, having the RPM able to overwrite it could be useful for consistency if we ever need to change it. We could just mark it as a config file and still have it overwrite the user's changes. There is an oo-diagnostics check to look for the .rpmsave file that would be created if a user ever did modify this file and have it overwritten. That would probably be wise as we can't always anticipate good use cases. https://github.com/openshift/origin-server/pull/6033 causes this file and httpd.conf to be marked as conf files, still overwriting them on update, but making a backup which can be detected by oo-diagnostics, and users can easily compare the changes. I do not think we want users to edit these files in general. Should we find a need to edit them ourselves, it is likely to be the kind of change that we want to force on users. If a user really feels this is the right place for them to edit a conf file, they can always chattr +i the file to prevent it being reset by an update. If there is a reasonable use case for this, it would be a good argument for making it %config(noreplace). Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/092f7feafde9d2372f38c8248e5175de78f9075c broker: mark broker httpd confs as conf files https://bugzilla.redhat.com/show_bug.cgi?id=1163917 Bug 1163917 - /var/www/openshift/broker/httpd/broker.conf is not marked as a configuration file Check on puddle-2-2-2015-01-23 1. check the configuration for the old package # rpm -qc openshift-origin-broker-1.16.2.2-1.el6op.noarch /etc/httpd/conf.d/000002_openshift_origin_broker_proxy.conf /etc/httpd/conf.d/000002_openshift_origin_broker_servername.conf /etc/openshift/broker-dev.conf /etc/openshift/broker.conf /etc/openshift/quickstarts.json /var/www/openshift/broker/config/environments/development.rb /var/www/openshift/broker/config/environments/production.rb 2. check the configuration file for the latest package # rpm -qc openshift-origin-broker.noarch 0:1.16.2.3-1.el6op /etc/httpd/conf.d/000002_openshift_origin_broker_proxy.conf /etc/httpd/conf.d/000002_openshift_origin_broker_servername.conf /etc/openshift/broker-dev.conf /etc/openshift/broker.conf /etc/openshift/quickstarts.json /var/www/openshift/broker/config/environments/development.rb /var/www/openshift/broker/config/environments/production.rb /var/www/openshift/broker/httpd/broker.conf /var/www/openshift/broker/httpd/httpd.conf Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0220.html |