Bug 1163928 - why runtime require gnome-icon-theme?
Summary: why runtime require gnome-icon-theme?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-printer
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-13 17:28 UTC by Wolfgang Ulbrich
Modified: 2015-02-22 06:02 UTC (History)
4 users (show)

Fixed In Version: system-config-printer-1.5.5-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-22 06:02:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
adwaita theme (761.93 KB, image/png)
2014-11-13 19:12 UTC, Wolfgang Ulbrich
no flags Details
mate theme (783.89 KB, image/png)
2014-11-13 19:13 UTC, Wolfgang Ulbrich
no flags Details

Description Wolfgang Ulbrich 2014-11-13 17:28:04 UTC
Description of problem:
system-config-printer has a runtime require to gnome-icon-theme in spec file.
Is this really needed ?
It seems that gnome-icon-theme is obsolete and gnome use already adwaita-icon-theme.
Also gnome-shell has it own printer configuration, in result only desktops like mate, xfce, sugar, or lxde will use system-config-printer.
All this desktops has it own icon-themes, and use a icon-theme in their comps file to be shure that a icon-theme is installed.
So using 'Requires: gnome-icon-theme' or any other icon-theme is not really needed, imo.

The reason for why i ask is that i'm working on the mate-compiz live spin.
I added system-config-printer today and it pulls in gnome-icon-theme.
Which is pretty useless in Mate and increase only the size of the livecd, which i want to use for other applications.
Maybe this is fixable before we run in release freeze and installer images are tag for release.

Correct if i'm wrong, maybe you have a good reason to do that which i don't see.

Thank you

Comment 1 Tim Waugh 2014-11-13 18:21:39 UTC
It needs to have certain named icons, e.g. i-network-printer, printer, emblem-pause, emblem-favorite.

Is adwaita-icon-theme a better requirement?

Comment 2 Wolfgang Ulbrich 2014-11-13 19:02:27 UTC
Ok, for mate i would say we have this icons too, mate-icon-theme is a fork from gnome-icon-theme, but i don't know exactly the situation for other desktops.

adwaita-icon-theme should be a better requirement, because it is always installed.

a list of icons with printer in name.

[rave@mother icons]$ find Adwaita/ -name *printer*
Adwaita/22x22/devices/printer-network.png
Adwaita/22x22/devices/printer.png
Adwaita/22x22/status/printer-error.png
Adwaita/22x22/status/printer-printing.png
Adwaita/24x24/devices/printer-network-symbolic.symbolic.png
Adwaita/24x24/devices/printer-network.png
Adwaita/24x24/devices/printer-symbolic.symbolic.png
Adwaita/24x24/devices/printer.png
Adwaita/24x24/status/printer-error.png
Adwaita/24x24/status/printer-printing.png
Adwaita/24x24/status/printer-printing-symbolic.symbolic.png
Adwaita/24x24/status/printer-error-symbolic.symbolic.png
Adwaita/24x24/status/printer-warning-symbolic.symbolic.png
Adwaita/scalable/devices/printer-symbolic.svg
Adwaita/scalable/devices/printer-network-symbolic.svg
Adwaita/scalable/status/printer-error-symbolic.svg
Adwaita/scalable/status/printer-warning-symbolic.svg
Adwaita/scalable/status/printer-printing-symbolic.svg
Adwaita/16x16/devices/printer-network-symbolic.symbolic.png
Adwaita/16x16/devices/printer-network.png
Adwaita/16x16/devices/printer-symbolic.symbolic.png
Adwaita/16x16/devices/printer.png
Adwaita/16x16/status/printer-error.png
Adwaita/16x16/status/printer-printing.png
Adwaita/16x16/status/printer-printing-symbolic.symbolic.png
Adwaita/16x16/status/printer-error-symbolic.symbolic.png
Adwaita/16x16/status/printer-warning-symbolic.symbolic.png
Adwaita/32x32/devices/printer-network-symbolic.symbolic.png
Adwaita/32x32/devices/printer-network.png
Adwaita/32x32/devices/printer-symbolic.symbolic.png
Adwaita/32x32/devices/printer.png
Adwaita/32x32/status/printer-error.png
Adwaita/32x32/status/printer-printing.png
Adwaita/32x32/status/printer-printing-symbolic.symbolic.png
Adwaita/32x32/status/printer-error-symbolic.symbolic.png
Adwaita/32x32/status/printer-warning-symbolic.symbolic.png
Adwaita/256x256/devices/printer-network.png
Adwaita/256x256/devices/printer.png
Adwaita/256x256/status/printer-error.png
Adwaita/256x256/status/printer-printing.png
Adwaita/96x96/devices/printer-network-symbolic.symbolic.png
Adwaita/96x96/devices/printer-symbolic.symbolic.png
Adwaita/96x96/status/printer-printing-symbolic.symbolic.png
Adwaita/96x96/status/printer-error-symbolic.symbolic.png
Adwaita/96x96/status/printer-warning-symbolic.symbolic.png
Adwaita/48x48/devices/printer-network-symbolic.symbolic.png
Adwaita/48x48/devices/printer-network.png
Adwaita/48x48/devices/printer-symbolic.symbolic.png
Adwaita/48x48/devices/printer.png
Adwaita/48x48/status/printer-error.png
Adwaita/48x48/status/printer-printing.png
Adwaita/48x48/status/printer-printing-symbolic.symbolic.png
Adwaita/48x48/status/printer-error-symbolic.symbolic.png
Adwaita/48x48/status/printer-warning-symbolic.symbolic.png
Adwaita/64x64/devices/printer-network-symbolic.symbolic.png
Adwaita/64x64/devices/printer-symbolic.symbolic.png
Adwaita/64x64/status/printer-printing-symbolic.symbolic.png
Adwaita/64x64/status/printer-error-symbolic.symbolic.png
Adwaita/64x64/status/printer-warning-symbolic.symbolic.png

and emblems

Adwaita/22x22/emblems
Adwaita/22x22/emblems/emblem-photos.png
Adwaita/22x22/emblems/emblem-synchronizing.png
Adwaita/22x22/emblems/emblem-important.png
Adwaita/22x22/emblems/emblem-documents.png
Adwaita/22x22/emblems/emblem-default.png
Adwaita/22x22/emblems/emblem-unreadable.png
Adwaita/22x22/emblems/emblem-urgent.png
Adwaita/22x22/emblems/emblem-mail.png
Adwaita/22x22/emblems/emblem-downloads.png
Adwaita/22x22/emblems/emblem-web.png
Adwaita/22x22/emblems/emblem-favorite.png
Adwaita/22x22/emblems/emblem-shared.png
Adwaita/22x22/emblems/emblem-generic.png
Adwaita/22x22/emblems/emblem-symbolic-link.png
Adwaita/22x22/emblems/emblem-package.png
Adwaita/22x22/emblems/emblem-system.png
Adwaita/22x22/emblems/emblem-readonly.png
Adwaita/22x22/emblems/emblem-new.png
Adwaita/24x24/emblems
Adwaita/24x24/emblems/emblem-photos.png
Adwaita/24x24/emblems/emblem-synchronizing.png
Adwaita/24x24/emblems/emblem-important.png
Adwaita/24x24/emblems/emblem-documents.png
Adwaita/24x24/emblems/emblem-default.png
Adwaita/24x24/emblems/emblem-unreadable.png
Adwaita/24x24/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-urgent.png
Adwaita/24x24/emblems/emblem-mail.png
Adwaita/24x24/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-downloads.png
Adwaita/24x24/emblems/emblem-web.png
Adwaita/24x24/emblems/emblem-favorite.png
Adwaita/24x24/emblems/emblem-music-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-system-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-default-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-shared.png
Adwaita/24x24/emblems/emblem-generic.png
Adwaita/24x24/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-symbolic-link.png
Adwaita/24x24/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-important-symbolic.symbolic.png
Adwaita/24x24/emblems/emblem-package.png
Adwaita/24x24/emblems/emblem-system.png
Adwaita/24x24/emblems/emblem-readonly.png
Adwaita/24x24/emblems/emblem-new.png
Adwaita/scalable/emblems
Adwaita/scalable/emblems/emblem-documents-symbolic.svg
Adwaita/scalable/emblems/emblem-videos-symbolic.svg
Adwaita/scalable/emblems/emblem-synchronizing-symbolic.svg
Adwaita/scalable/emblems/emblem-ok-symbolic.svg
Adwaita/scalable/emblems/emblem-system-symbolic.svg
Adwaita/scalable/emblems/emblem-shared-symbolic.svg
Adwaita/scalable/emblems/emblem-music-symbolic.svg
Adwaita/scalable/emblems/emblem-favorite-symbolic.svg
Adwaita/scalable/emblems/emblem-default-symbolic.svg
Adwaita/scalable/emblems/emblem-photos-symbolic.svg
Adwaita/scalable/emblems/emblem-important-symbolic.svg
Adwaita/16x16/emblems
Adwaita/16x16/emblems/emblem-photos.png
Adwaita/16x16/emblems/emblem-synchronizing.png
Adwaita/16x16/emblems/emblem-important.png
Adwaita/16x16/emblems/emblem-documents.png
Adwaita/16x16/emblems/emblem-default.png
Adwaita/16x16/emblems/emblem-unreadable.png
Adwaita/16x16/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-urgent.png
Adwaita/16x16/emblems/emblem-mail.png
Adwaita/16x16/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-downloads.png
Adwaita/16x16/emblems/emblem-web.png
Adwaita/16x16/emblems/emblem-favorite.png
Adwaita/16x16/emblems/emblem-music-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-system-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-default-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-shared.png
Adwaita/16x16/emblems/emblem-generic.png
Adwaita/16x16/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-symbolic-link.png
Adwaita/16x16/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-important-symbolic.symbolic.png
Adwaita/16x16/emblems/emblem-package.png
Adwaita/16x16/emblems/emblem-system.png
Adwaita/16x16/emblems/emblem-readonly.png
Adwaita/16x16/emblems/emblem-new.png
Adwaita/32x32/emblems
Adwaita/32x32/emblems/emblem-photos.png
Adwaita/32x32/emblems/emblem-synchronizing.png
Adwaita/32x32/emblems/emblem-important.png
Adwaita/32x32/emblems/emblem-documents.png
Adwaita/32x32/emblems/emblem-default.png
Adwaita/32x32/emblems/emblem-unreadable.png
Adwaita/32x32/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-urgent.png
Adwaita/32x32/emblems/emblem-mail.png
Adwaita/32x32/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-downloads.png
Adwaita/32x32/emblems/emblem-web.png
Adwaita/32x32/emblems/emblem-favorite.png
Adwaita/32x32/emblems/emblem-music-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-system-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-default-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-shared.png
Adwaita/32x32/emblems/emblem-generic.png
Adwaita/32x32/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-symbolic-link.png
Adwaita/32x32/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-important-symbolic.symbolic.png
Adwaita/32x32/emblems/emblem-package.png
Adwaita/32x32/emblems/emblem-system.png
Adwaita/32x32/emblems/emblem-readonly.png
Adwaita/32x32/emblems/emblem-new.png
Adwaita/256x256/emblems
Adwaita/256x256/emblems/emblem-synchronizing.png
Adwaita/256x256/emblems/emblem-unreadable.png
Adwaita/256x256/emblems/emblem-mail.png
Adwaita/256x256/emblems/emblem-shared.png
Adwaita/256x256/emblems/emblem-symbolic-link.png
Adwaita/256x256/emblems/emblem-package.png
Adwaita/256x256/emblems/emblem-readonly.png
Adwaita/8x8/emblems
Adwaita/8x8/emblems/emblem-synchronizing.png
Adwaita/8x8/emblems/emblem-default.png
Adwaita/8x8/emblems/emblem-unreadable.png
Adwaita/8x8/emblems/emblem-symbolic-link.png
Adwaita/8x8/emblems/emblem-readonly.png
Adwaita/8x8/emblems/emblem-new.png
Adwaita/96x96/emblems
Adwaita/96x96/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-music-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-system-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-default-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/96x96/emblems/emblem-important-symbolic.symbolic.png
Adwaita/48x48/emblems
Adwaita/48x48/emblems/emblem-photos.png
Adwaita/48x48/emblems/emblem-synchronizing.png
Adwaita/48x48/emblems/emblem-important.png
Adwaita/48x48/emblems/emblem-documents.png
Adwaita/48x48/emblems/emblem-default.png
Adwaita/48x48/emblems/emblem-unreadable.png
Adwaita/48x48/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-urgent.png
Adwaita/48x48/emblems/emblem-mail.png
Adwaita/48x48/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-downloads.png
Adwaita/48x48/emblems/emblem-web.png
Adwaita/48x48/emblems/emblem-favorite.png
Adwaita/48x48/emblems/emblem-music-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-system-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-default-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-shared.png
Adwaita/48x48/emblems/emblem-generic.png
Adwaita/48x48/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-symbolic-link.png
Adwaita/48x48/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-important-symbolic.symbolic.png
Adwaita/48x48/emblems/emblem-package.png
Adwaita/48x48/emblems/emblem-system.png
Adwaita/48x48/emblems/emblem-readonly.png
Adwaita/48x48/emblems/emblem-desktop.png
Adwaita/48x48/emblems/emblem-new.png
Adwaita/64x64/emblems
Adwaita/64x64/emblems/emblem-photos-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-favorite-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-shared-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-synchronizing-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-videos-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-music-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-system-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-default-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-ok-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-documents-symbolic.symbolic.png
Adwaita/64x64/emblems/emblem-important-symbolic.symbolic.png

Another solution could be to check if gnome-icon-theme-legacy is sufficient.

Comment 3 Wolfgang Ulbrich 2014-11-13 19:11:26 UTC
a quick test shows that no icons are missing with adwaita-icon-theme or mate-icon-theme

Comment 4 Wolfgang Ulbrich 2014-11-13 19:12:23 UTC
Created attachment 957276 [details]
adwaita theme

Comment 5 Wolfgang Ulbrich 2014-11-13 19:13:07 UTC
Created attachment 957277 [details]
mate theme

Comment 6 Tim Waugh 2014-11-14 09:29:27 UTC
I think this needs more investigation into exactly which names system-config-printer ought to be using, and whether they are Gtk.STOCK_*-type names or literal strings.

Comment 7 Wolfgang Ulbrich 2014-11-14 09:48:16 UTC
Ok, if you give me a list i can check it against posible themes.

Comment 8 Fedora Update System 2015-02-06 20:44:30 UTC
system-config-printer-1.5.5-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/system-config-printer-1.5.5-1.fc21

Comment 9 Fedora Update System 2015-02-09 05:26:30 UTC
Package system-config-printer-1.5.5-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.5-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1876/system-config-printer-1.5.5-2.fc21
then log in and leave karma (feedback).

Comment 10 lnie 2015-02-09 05:55:55 UTC
system-config-printer-1.5.5-1.fc21 works

Comment 11 Fedora Update System 2015-02-22 06:02:58 UTC
system-config-printer-1.5.5-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.