Spec URL: http://vps533.directvps.nl/statsd.spec SRPM URL: http://vps533.directvps.nl/statsd-0.7.2-1.fc21.src.rpm Description: A simple, lightweight network daemon to collect metrics over UDP Fedora Account System Username: piotrp koji scratch rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8153984 koji scratch f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=8153986 koji scratch f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=8153988 koji scratch f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=8153992 koji scratch epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=8153990
added epel6 & epel7 support Spec URL: http://vps533.directvps.nl/statsd.spec SRPM URL: http://vps533.directvps.nl/statsd-0.7.2-2.fc21.src.rpm
Two small things, that are not blockers: - Can you fix the end-of-line encodings in these two files in the prep section? dos2unix should do it. - /usr/share/doc/statsd/examples/go/statsd.go - /usr/share/doc/statsd/examples/csharp_example.cs - Also, if you like, it would be nice to generate a manpage with help2man or something similar. Those aside (they can be fixed before import), PACKAGE IS APPROVED. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 39 files have unknown license. Detailed output of licensecheck in /home/threebean/1164496-statsd/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 29 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [-]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: statsd-0.7.2-2.fc20.noarch.rpm statsd-0.7.2-2.fc20.src.rpm statsd.noarch: W: spelling-error %description -l en_US js -> dis, ks, j statsd.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged statsd.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end statsd.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/statsd/examples/go/statsd.go statsd.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/statsd/examples/csharp_example.cs statsd.noarch: W: no-manual-page-for-binary statsd statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/Etsy/StatsD.pm perl(Carp) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/Etsy/StatsD.pm perl(warnings) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/perl-example.pl perl(warnings) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/perl-example.pl perl(lib) statsd.src: W: spelling-error %description -l en_US js -> dis, ks, j statsd.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged statsd.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end 2 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@geier /]# rpmlint statsd statsd.noarch: W: spelling-error %description -l en_US js -> dis, ks, j statsd.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged statsd.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end statsd.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/statsd/examples/go/statsd.go statsd.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/statsd/examples/csharp_example.cs statsd.noarch: W: no-manual-page-for-binary statsd statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/Etsy/StatsD.pm perl(Carp) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/Etsy/StatsD.pm perl(warnings) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/perl-example.pl perl(warnings) statsd.noarch: W: doc-file-dependency /usr/share/doc/statsd/examples/perl-example.pl perl(lib) 1 packages and 0 specfiles checked; 0 errors, 10 warnings. ]0;<mock-chroot><mock-chroot>[root@geier /]# echo 'rpmlint-done:' Requires -------- statsd (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/env /usr/bin/perl config(statsd) nodejs(engine) perl(Carp) perl(Etsy::StatsD) perl(Getopt::Long) perl(IO::Socket) perl(constant) perl(lib) perl(strict) perl(warnings) shadow-utils systemd Provides -------- statsd: config(statsd) npm(statsd) perl(Etsy::StatsD) statsd Source checksums ---------------- https://github.com/etsy/statsd/archive/v0.7.2.tar.gz#/statsd-v0.7.2.tar.gz : CHECKSUM(SHA256) this package : 0d0d6b7596fe68ef7da0984e32ca988c21985bdab825d33043cede2d7b9076f2 CHECKSUM(SHA256) upstream package : 0d0d6b7596fe68ef7da0984e32ca988c21985bdab825d33043cede2d7b9076f2 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1164496 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks! Will fix the issues before importing.
No SCM request found.
New Package SCM Request ======================= Package Name: statsd Short Description: Description: A simple, lightweight network daemon to collect metrics over UDP Upstream URL: https://github.com/etsy/statsd/ Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp
Git done (by process-git-requests).
statsd-0.7.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/statsd-0.7.2-3.fc21
statsd-0.7.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/statsd-0.7.2-3.fc20
statsd-0.7.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/statsd-0.7.2-3.fc19
statsd-0.7.2-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/statsd-0.7.2-3.el7
statsd-0.7.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/statsd-0.7.2-3.el6
statsd-0.7.2-3.fc21 has been pushed to the Fedora 21 stable repository.
statsd-0.7.2-3.fc20 has been pushed to the Fedora 20 stable repository.
statsd-0.7.2-3.fc19 has been pushed to the Fedora 19 stable repository.
statsd-0.7.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
statsd-0.7.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository.