Hide Forgot
description of problem: libvirt should forbid attach a unsupport console to a active vm Version-Release number of selected component (if applicable): libvirt-1.2.8-7.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1.# cat lxcconsole.xml <console type='pty'> <target type='lxc' port='1'/> </console> 2.# virsh list --all Id Name State ---------------------------------------------------- 32 r6 running 3.wrong in this step: # virsh attach-device r6 lxcconsole.xml Device attached successfully 4.can see it in vm's xml # virsh dumpxml r6|grep -2 lxc <console type='pty'> <source path='/dev/pts/11'/> <target type='lxc' port='1'/> <alias name='console1'/> </console> 5.cannot detach after attach # virsh detach-device r6 lxcconsole.xml --live error: Failed to detach device from lxcconsole.xml error: Requested operation is not valid: device not present in domain configuration Actual results: attach success Expected results: report error, this console is for lxc, if we try start a qemu guest with lsc console, will get error : # virsh start r6 error: Failed to start domain r6 error: unsupported configuration: unsupported console target type lxc So attach this console should report error. Additional info: No error in libvirtd.log.
send a patch to upstream: https://www.redhat.com/archives/libvir-list/2014-November/msg00556.html
commit 860522d26b9bd532d4f77d057d85e847c84e6af5 Author: Luyao Huang <lhuang@redhat.com> Date: Thu Jan 22 10:28:18 2015 +0800 qemu: output error when try to hotplug unsupported console type https://bugzilla.redhat.com/show_bug.cgi?id=1164627 When using 'virsh attach-device' to hotplug an unsupported console type into a qemu guest the attachment would succeed as the command line formatter didn't report error in such case. v1.2.12-rc1-3-g860522d
Verified as below: [root@localhost ~]# rpm -q libvirt qemu-kvm-rhev libvirt-1.2.15-1.el7.x86_64 qemu-kvm-rhev-2.3.0-1.el7.x86_64 [root@localhost ~]# virsh list Id Name State ---------------------------------------------------- 34 r71 running [root@localhost ~]# cat lxc.xml <console type='pty'> <target type='lxc' port='1'/> </console> [root@localhost ~]# virsh attach-device r71 lxc.xml error: Failed to attach device from lxc.xml error: unsupported configuration: unsupported console target type lxc
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html