Spec URL: https://fedorapeople.org/~miminar/rpmreview/devilspie2.spec SRPM URL: https://fedorapeople.org/~miminar/rpmreview/devilspie2-0.38-1.fc21.src.rpm Description: Devilspie2 is a window matching utility, allowing the user to perform scripted actions on windows as they are created. For example you can script a terminal program to always be positioned at a specific screen position, or position a window on a specific workspace. It is based on the program Devilspie by Ross Burton. Fedora Account System Username: miminar
Mostly fine, just a couple of things that need fixing: * the license is GPLv3+, not GPLv3 (check the license headers in the source files) * the full license text (GPL3.txt) must be included in the package Also, a few suggestions: * use pkgconfig(foo) for BuildRequires: https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires ** doing this might allow you to remove the explicit pkg-config BuildRequires (needs verification) * preserve timestamps during installation with 'INSTALL="install -p"': https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)". Detailed output of licensecheck in /home/david/checkout/rpms/1165105-devilspie2/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: devilspie2-0.38-1.fc22.x86_64.rpm devilspie2-0.38-1.fc22.src.rpm devilspie2.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace devilspie2.src: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace devilspie2.src: W: strange-permission devilspie2_0.38-src.tar.gz 0640L 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# rpmlint devilspie2 devilspie2.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/david/checkout/rpms/1165105-devilspie2/srpm/devilspie2.spec 2014-12-01 12:24:55.601832569 +0000 +++ /home/david/checkout/rpms/1165105-devilspie2/srpm-unpacked/devilspie2.spec 2014-11-18 11:03:04.000000000 +0000 @@ -14,4 +14,5 @@ BuildRequires: libwnck3-devel BuildRequires: glib2-devel +BuildRequires: gettext %description Requires -------- devilspie2 (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) liblua-5.2.so()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libwnck-3.so.0()(64bit) rtld(GNU_HASH) Provides -------- devilspie2: devilspie2 devilspie2(x86-64) Source checksums ---------------- http://download.savannah.gnu.org/releases/devilspie2/devilspie2_0.38-src.tar.gz : CHECKSUM(SHA256) this package : 0452f39789f4ba446cd7532a4ec7eae5fa35d2ecc3cdaf6557ecc198af3b4a24 CHECKSUM(SHA256) upstream package : 0452f39789f4ba446cd7532a4ec7eae5fa35d2ecc3cdaf6557ecc198af3b4a24 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1165105 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank you David for your suggestions. Hopefully, they've been covered: https://fedorapeople.org/~miminar/rpmreview/devilspie2.spec https://fedorapeople.org/~miminar/rpmreview/devilspie2-0.38-2.fc21.src.rpm Could you take a look at it once more? Sorry for the delay... Michal
Looks great now. Approved!
New Package SCM Request ======================= Package Name: devilspie2 Short Description: A window-matching utility Upstream URL: http://www.gusnan.se/devilspie2 Owners: miminar Branches: f20 f21 epel7 InitialCC:
Git done (by process-git-requests).
Closing now. Kudos to David and Jon.