Bug 1165285
| Summary: | Corrupt system jindex confuses fsck.gfs2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Robert Peterson <rpeterso> | ||||||||
| Component: | gfs2-utils | Assignee: | Robert Peterson <rpeterso> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 7.2 | CC: | cluster-maint, gfs2-maint, jpayne | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | gfs2-utils-3.1.8-1.el7 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-11-19 03:53:00 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1153316, 1184482, 1268045 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Robert Peterson
2014-11-18 18:16:10 UTC
Assigning to Andy for now, but I'm happy to assist. Reassigning to me because I'm already making major changes to fsck.gfs2. Created attachment 978377 [details]
Early prototype #1
This patch seems to work; needs more testing.
Created attachment 991144 [details]
Patch 1 of 2 - Rebuild system files if they don't have the SYS bit set
Here is patch 1 of 2 to fix this problem.
Created attachment 991145 [details]
Patch 2 of 2 - Check the integrity of the journal index
This is patch 2 of 2 for this bug. It checks the integrity of
the system jindex file, and performs repairs as needed.
These two patches are in the master branch of the upstream gfs2-utils git repo, since 22 January 2015. So it's just a matter of pushing them to the RHEL7 branch at this point. However, they do rely upon the existence of the patches for bug #1153316, so I'm going to add that as a dependency. Verified in gfs2-utils-3.1.8-4.el7: [root@dash-01 ~]# rpm -q gfs2-utils gfs2-utils-3.1.8-4.el7.x86_64 [root@dash-01 ~]# gfs2_edit restoremeta saswork.banjaxedjindex.meta /dev/mapper/fsck-sasdata No valid file header found. Falling back to old format... Block size is 4096B This is gfs2 metadata. There are 805306368 free blocks on the destination device. Highest saved block is 268410886 (0xfffa006) 268410887 blocks processed, 26462 saved (100%) File saswork.banjaxedjindex.meta restore successful. [root@dash-01 ~]# fsck.gfs2 -y /dev/mapper/fsck-sasdata &> /tmp/fsck_out [root@dash-01 ~]# echo $? 1 [root@dash-01 ~]# fsck.gfs2 /dev/mapper/fsck-sasdata Initializing fsck Validating Resource Group index. Level 1 rgrp check: Checking if all rgrp and rindex values are good. (level 1 passed) Starting pass1 pass1 completed in 0.144s Starting pass1b pass1b completed in 0.000s Starting pass1c pass1c completed in 0.000s Starting pass2 pass2 completed in 1.267s Starting pass3 pass3 completed in 0.000s Starting pass4 pass4 completed in 0.000s Starting pass5 pass5 completed in 1.456s Starting check_statfs check_statfs completed in 0.000s gfs2_fsck complete [root@dash-01 ~]# echo $? 0 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2178.html |