Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/paratype-pt-mono-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/paratype-pt-mono-fonts-20113012-1.fc20.src.rpm Description: Paratype PT Mono fonts, a monospaced typeface Fedora Account System Username: rajeeshknambiar
Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output paratype-pt-mono-fonts.noarch: W: spelling-error Summary(en_US) monospace -> mono space, mono-space, aerospace paratype-pt-mono-fonts.noarch: W: spelling-error %description -l en_US superfamily -> super family, super-family, superficially paratype-pt-mono-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/paratype-pt-mono-fonts/PTSSM_OFL.txt paratype-pt-mono-fonts.src: W: spelling-error Summary(en_US) monospace -> mono space, mono-space, aerospace paratype-pt-mono-fonts.src: W: unexpanded-macro %description -l C %_font_pkg paratype-pt-mono-fonts.src: W: unexpanded-macro %description -l C %doc paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US superfamily -> super family, super-family, superficially paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US conf -> con, cone, cons paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US ttf -> Flatt, paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US txt -> text, ext, tit paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US usr -> use, us, user paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US appdata -> app data, app-data, tapped paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US metainfo -> meta info, meta-info, infotainment paratype-pt-mono-fonts.src: W: spelling-error %description -l en_US xml -> XML, ml, x ml 2 packages and 0 specfiles checked; 0 errors, 14 warnings. + Source verified with upstream as (sha256sum) srpm tarball:e34e729f9509cf85acc52caadf68e96db90457b7164ba45719967d53e7a20dcc upstream tarball:e34e729f9509cf85acc52caadf68e96db90457b7164ba45719967d53e7a20dcc + License is "OFL" and included in its own text file. + follows fonts packaging guidelines. Suggestions to fix issues 1) you should take version as a date on which you packages. So it should be 20141119. Generally if there is no version in tarball then take that as snapshot package with its version as YYYYMMDD. 2) rpmlint warning wrong-file-end-of-line-encoding can be fixed in %prep sed -i "s|\r||g" PTSSM_OFL.txt
Thanks for the review, Parag! Regarding 1) I have based the version numbering on paratype-pt-sans-fonts (which for some reason seems to use YYYYDDMM format) to be uniform and used the source release date. The version in TTF file mentions 1.003. What do you suggest?
Rajeesh, You are right paratype-pt-sans-fonts package version is using wrong date format. I missed this YYYYMMDD format to use when I updated that package last time but no issues. I see there are clearly some changes from PTSans_OFL.zip to new PTSansOFL.zip file (also version bump from 2.004 to 2.005). So, I am going to update paratype-pt-sans-fonts to use this new source to align it with these 2 new serif and mono packaging. You can now use version as the day on which you pick upstream source.
I have built new paratype-pt-sans-fonts-20141121-1.fc22 and will push this update to all other fedora branches by next week.
Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/paratype-pt-mono-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/paratype-pt-mono-fonts-20141121-1.fc20.src.rpm
Looks good. APPROVED.
New Package SCM Request ======================= Package Name: paratype-pt-mono-fonts Short Description: Paratype PT Mono fonts, a monospaced typeface Upstream URL: http://www.paratype.com/public/ Owners: rajeeshknambiar Branches: f21 f22 epel7 InitialCC: pnemade
Git done (by process-git-requests). f22==rawhide which is automatic.