Bug 1165507 - Add appstream font metainfo file
Summary: Add appstream font metainfo file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: monafont
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-19 05:06 UTC by Parag Nemade
Modified: 2014-12-30 07:12 UTC (History)
2 users (show)

Fixed In Version: monafont-2.90-20.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-30 07:12:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Add font metainfo files (4.38 KB, application/mbox)
2014-11-19 05:06 UTC, Parag Nemade
no flags Details

Description Parag Nemade 2014-11-19 05:06:34 UTC
Created attachment 958888 [details]
Add font metainfo files

Description of problem:
Please add font metainfo file as requested by Richard Hughes on devel list https://lists.fedoraproject.org/pipermail/devel/2014-October/203394.html

I see you have maintained this package alone since its added. So instead of directly committing attached patch, I am requesting you to either commit or allow me to commit patch.

Version-Release number of selected component (if applicable):
monafont-2.90-19.fc21


Attached is a patch. If possible add same in F21.

Comment 1 Parag Nemade 2014-11-21 16:34:49 UTC
Hi Mamoru,
   Can you reply here when you are planning to apply attached patch?

Thanks.

Comment 2 Parag Nemade 2014-11-27 03:25:42 UTC
Hi Mamoru,
   Can you provide your views here or should I commit attached patch?

Comment 3 Mamoru TASAKA 2014-12-02 13:25:19 UTC
Well, I just tried installing metainfo file, however
(using F-21) gnome-software looking seems no change
and I don't know how this is needed. Would you explain?
(and note that I am using LXDE).

Comment 4 Mamoru TASAKA 2014-12-07 23:15:22 UTC
ping?

Comment 5 Mamoru TASAKA 2014-12-07 23:16:42 UTC
(Actually the provided metainfos don't seem to contain
 any useful information)

Comment 6 Parag Nemade 2014-12-08 01:18:47 UTC
Sorry was busy with some nodejs package reviews. If you think this font is not useful to show in gnome-software then please close this bug.

The metainfo information is only for gnome-software to show font information. Also, see what Richard answered when asked how to test these font metainfo files -> https://lists.fedoraproject.org/pipermail/devel/2014-October/203598.html

Comment 7 Mamoru TASAKA 2014-12-08 01:44:51 UTC
(In reply to Parag from comment #6)
> Sorry was busy with some nodejs package reviews. If you think this font is
> not useful to show in gnome-software then please close this bug.
> 
> The metainfo information is only for gnome-software to show font
> information. Also, see what Richard answered when asked how to test these
> font metainfo files ->
> https://lists.fedoraproject.org/pipermail/devel/2014-October/203598.html

gnome-software already shows font information without your
metainfo files, and I am really not sure how your metainfo
files is to be used. Also although I checked the line you 
provided on comment 6 and the link like
https://raw.githubusercontent.com/hughsie/createrepo_as_logs/master/l/lato-fonts.log
I cannot see how metadata info is used.

Have you tried by yourself how metadata in other font packages
you provided are actually used?

Comment 8 Parag Nemade 2014-12-08 09:39:48 UTC
Yes, I have checked the fonts I modified by checking logs at https://github.com/hughsie/createrepo_as_logs

E.g. I can see the recent font added by me in Fedora, phetsarath-fonts is not showing in gnome-software as its still using csv file whereas its parsing results can be found at https://raw.githubusercontent.com/hughsie/createrepo_as_logs/master/p/phetsarath-fonts.log
     Another example mozilla-fira-fonts still not updated for metainfo files so they are not having any log entry https://github.com/hughsie/createrepo_as_logs/tree/master/m and similarly for mona-sazanami font 

I see the csv file is removed now in upstream commit https://github.com/hughsie/fedora-appstream/commit/7fd16725d0fda5d31bdeaf8a1344b2edb4ad201a

and also consolidated appdata metainfo files are now compressed in /usr/share/app-info/xmls/fedora-21.xml.gz which is installed by appstream-data

gnome-software depends on this data only. The purpose of this metainfo file addition is that this consolidated file may be removed in future version say in Fedora 22 and gnome-software can show only apps and fonts where their individual packages are installing metainfo files.

Feel free to close this if you see metainfo file is not needed for this package.

Comment 9 Mamoru TASAKA 2014-12-30 07:12:49 UTC
Metainto files requested are now pushed into F-22/F-21-stable. Thank you for reporting this.


Note You need to log in before you can comment on or make changes to this bug.