Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://lorenzodalrio.fedorapeople.org/pg_view.spec SRPM URL: https://lorenzodalrio.fedorapeople.org/pg_view-20141118git11c942e-1.fc20.src.rpm Description: pg_view is a command-line tool to display the state of the PostgreSQL processes. It shows the per-process statistics combined with pg_stat_activity output for the processes that have the rows there, global system stats, per-partition information and the memory stats. Fedora Account System Username: lorenzodalrio Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8184513
Spec URL: https://lorenzodalrio.fedorapeople.org/pg_view.spec SRPM URL: https://lorenzodalrio.fedorapeople.org/pg_view-0-1.20141118git11c942e.fc20.src.rpm Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8188235
New SRPM and Spec file corrected as Michael Schwendt has suggested on fedora-devel. [1] Spec URL: https://lorenzodalrio.fedorapeople.org/pg_view.spec SRPM URL: https://lorenzodalrio.fedorapeople.org/pg_view-1.2.0-2.20141118git11c942e.fc20.src.rpm Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8193506 [1] https://lists.fedoraproject.org/pipermail/devel/2014-November/204511.html
OK. I'll review the package within the next day or two.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/mock/sandbox/review/pg_view/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: pg_view-1.2.0-2.20141118git11c942e.fc20.noarch.rpm pg_view-1.2.0-2.20141118git11c942e.fc20.src.rpm pg_view.noarch: W: no-manual-page-for-binary pg_view 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint pg_view pg_view.noarch: W: no-manual-page-for-binary pg_view 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- pg_view (rpmlib, GLIBC filtered): /usr/bin/python2 python-psycopg2 Provides -------- pg_view: pg_view Source checksums ---------------- https://github.com/zalando/pg_view/archive/11c942e2b0a3d2c054df06e6300a2d403607f96a/pg_view-11c942e2b0a3d2c054df06e6300a2d403607f96a.tar.gz : CHECKSUM(SHA256) this package : adb209df066c78200f4d5d3ae0ed2be2aa88a30656c56aaa588336c852d5132b CHECKSUM(SHA256) upstream package : adb209df066c78200f4d5d3ae0ed2be2aa88a30656c56aaa588336c852d5132b Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --rpm-spec -n pg_view-1.2.0-2.20141118git11c942e.fc20.src.rpm Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=8211422 Package is APPROVED.
New Package SCM Request ======================= Package Name: pg_view Short Description: Command-line tool to display the state of the PostgreSQL processes Upstream URL: https://github.com/zalando/pg_view Owners: lorenzodalrio Branches: f19 f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
pg_view-1.2.0-2.20141118git11c942e.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pg_view-1.2.0-2.20141118git11c942e.fc21
pg_view-1.2.0-2.20141118git11c942e.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pg_view-1.2.0-2.20141118git11c942e.fc20
pg_view-1.2.0-2.20141118git11c942e.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pg_view-1.2.0-2.20141118git11c942e.fc19
pg_view-1.2.0-2.20141118git11c942e.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pg_view-1.2.0-2.20141118git11c942e.el6
pg_view-1.2.0-2.20141118git11c942e.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/pg_view-1.2.0-2.20141118git11c942e.el7
pg_view-1.2.0-2.20141118git11c942e.el6 has been pushed to the Fedora EPEL 6 testing repository.
pg_view-1.2.0-2.20141118git11c942e.fc21 has been pushed to the Fedora 21 stable repository.
pg_view-1.2.0-2.20141118git11c942e.fc20 has been pushed to the Fedora 20 stable repository.
pg_view-1.2.0-2.20141118git11c942e.fc19 has been pushed to the Fedora 19 stable repository.
pg_view-1.2.0-2.20141118git11c942e.el7 has been pushed to the Fedora EPEL 7 stable repository.
pg_view-1.2.0-2.20141118git11c942e.el6 has been pushed to the Fedora EPEL 6 stable repository.