Spec URL: https://github.com/cbm755/fedora-spec/blob/master/perl-Tie-Cycle.spec SRPM URL: http://people.maths.ox.ac.uk/macdonald/fedora/perl-Tie-Cycle-1.20-1.fc21.src.rpm Description: You use Tie::Cycle to go through a list over and over again. Once you get to the end of the list, you go back to the beginning. You don't have to worry about any of this since the magic of tie does that for you. Fedora Account System Username: cbm This is dep for Biber, bug #1165620 I need sponsorship, but I'm not a perl user so I'm equally happy for perl people to take this one. Koji: koji.fedoraproject.org/koji/taskinfo?taskID=8180291
#1 The same as bug 1165625, comment 3, point 3. #2 The same as bug 1165625, comment 3, point 4. #3 Don't package META.json in %doc. It's not really useful to end users. #4 Missing build-time deps here: perl, perl(Carp), perl(constant), perl(strict), perl(Test::More) >= 0.95. #5 The minimum required version of ExtUtils::MakeMaker is 6.46. You should reflect that in your list of build-time deps. #6 Test::Simple is not used anywhere, at all. What you wanted was Test::More (see above). #7 Addition optional build-time dependencies you may add are perl(Test::Pod) >= 1.00 and perl(Test::Pod::Coverage).
Thanks, addressed. http://people.maths.ox.ac.uk/macdonald/fedora/perl-Tie-Cycle-1.20-2.fc21.src.rpm https://raw.githubusercontent.com/cbm755/fedora-spec/master/perl-Tie-Cycle.spec
For a minute I thought some of my BR should actually be Requires. I think I've sorted it out... says "tangerine lib/": ```` Carp Used by: lib/Tie/Cycle.pm:6 constant Used by: lib/Tie/Cycle.pm:10 lib/Tie/Cycle.pm:8 lib/Tie/Cycle.pm:9 ExtUtils::MakeMaker, version 6.46 Used by: Makefile.PL:1, v6.46 strict Used by: lib/Tie/Cycle.pm:2 Tie::Cycle Provided by: lib/Tie/Cycle.pm:1 ```` Are these observations correct? 1. That output means perl(Carp), perl(constant), perl(strict) are run-time deps (not build deps). 2. It looks like rpmbuild automatically knows about these three (from output of "rpm -qRp"). That is why we don't need to manually list them as "Requires". 3. All Requires effectively become BR because of tests (which need to load the module itself). Which is why we list them as BR (even though the Makefile itself doesn't need them.)
(In reply to Colin Macdonald from comment #3) > Are these observations correct? > > 1. That output means perl(Carp), perl(constant), perl(strict) are run-time > deps (not build deps). Well, since the code is tested in %check phase, they're both. > 2. It looks like rpmbuild automatically knows about these three (from > output of "rpm -qRp"). That is why we don't need to manually list them as > "Requires". Correct. Once built, rpmbuild scans perl files listed in %files and generates list of provided and required modules. If you're curious, you can find the script rpmbuild uses in the perl-generators package. > 3. All Requires effectively become BR because of tests (which need to load > the module itself). Which is why we list them as BR (even though the > Makefile itself doesn't need them.) Correct, see (1) :) However, this isn't always the case. It depends on what code is tested and what is not. Some test suites are very thorough, some don't do much. `use'-like statements are compile-time dependencies and are always needed when the file is loaded via whatever method, even if the said statement is in a block which isn't executed. `require'-like statements are pure runtime dependencies. Our module here is very simple; all these are "used", therefore they will be loaded as soon as something touches lib/Tie/Cycle.pm. And when you run `tangerine t/', you see all three tests (obviously) do fiddle with it.
This package fine now. I'm approving it. I've just sponsored you, too. You can now request git branches you care about: https://fedoraproject.org/wiki/Package_SCM_admin_requests When dealing with perl packages, please, always add perl-sig to InitialCC.
New Package SCM Request ======================= Package Name: perl-Tie-Cycle Short Description: Cycle through a list of values via a scalar Upstream URL: http://search.cpan.org/dist/Tie-Cycle/ Owners: cbm mef Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Getopt-Tabular-0.3-2.fc21,perl-Business-ISSN-0.91-4.fc21,perl-Tie-Cycle-1.20-2.fc21,perl-XML-LibXML-Simple-0.94-3.fc21,perl-XML-Writer-String-0.1-5.fc21,perl-ExtUtils-LibBuilder-0.06-4.fc21
perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 testing repository.
perl-Getopt-Tabular-0.3-2.fc21, perl-Business-ISSN-0.91-4.fc21, perl-Tie-Cycle-1.20-2.fc21, perl-XML-LibXML-Simple-0.94-3.fc21, perl-XML-Writer-String-0.1-5.fc21, perl-ExtUtils-LibBuilder-0.06-4.fc21 has been pushed to the Fedora 21 stable repository.