Bug 116566 - [PATCH] Access almost completely open when no users are enabled
Summary: [PATCH] Access almost completely open when no users are enabled
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-config-samba   
(Show other bugs)
Version: 1
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Brent Fox
QA Contact:
Keywords: Patch, Security
Depends On:
Blocks: FC2Target
TreeView+ depends on / blocked
Reported: 2004-02-23 09:23 UTC by Miloslav Trmac
Modified: 2007-11-30 22:10 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2004-03-08 20:45:34 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Don't use "invalid user = %S" (4.13 KB, patch)
2004-02-23 09:23 UTC, Miloslav Trmac
no flags Details | Diff

Description Miloslav Trmac 2004-02-23 09:23:08 UTC
Description of problem:
When the share configuration is set up to allow access only to
the selected users and no users are selected, the tool writes
        invalid users = %S
but %S expands to the share name, so in fact almost all
users are allowed. (After globally enabling the guest user
even the guest user can access this "restricted" share.)

Samba does not really have a notion of "existing but completely
disabled share", the attached patch uses
        valid users = __redhat_config_samba_to_disallow_access__

Version-Release number of selected component (if applicable):

Comment 1 Miloslav Trmac 2004-02-23 09:23:32 UTC
Created attachment 97941 [details]
Don't use "invalid user = %S"

Comment 2 Brent Fox 2004-03-05 21:57:52 UTC
fenlason: Can you provide some insight here?  Is there a better way to
create a share for which access is completely disabled?

Comment 3 Brent Fox 2004-03-08 20:45:34 UTC
At arjan's suggestion, I have modified the application to pop up a
dialog when the "Only allow access to specific users" button".  The
dialog asks the user to choose at least one user from the list.  The
app will no longer allow you to create a share with no valid users
unless the "Allow access to everyone" radio button is selected.

Should be fixed in system-config-samba-1.2.5-1.  Thanks for your report.

Note You need to log in before you can comment on or make changes to this bug.