Red Hat Bugzilla – Bug 116566
[PATCH] Access almost completely open when no users are enabled
Last modified: 2007-11-30 17:10:37 EST
Description of problem:
When the share configuration is set up to allow access only to
the selected users and no users are selected, the tool writes
invalid users = %S
but %S expands to the share name, so in fact almost all
users are allowed. (After globally enabling the guest user
even the guest user can access this "restricted" share.)
Samba does not really have a notion of "existing but completely
disabled share", the attached patch uses
valid users = __redhat_config_samba_to_disallow_access__
Version-Release number of selected component (if applicable):
Created attachment 97941 [details]
Don't use "invalid user = %S"
fenlason: Can you provide some insight here? Is there a better way to
create a share for which access is completely disabled?
At arjan's suggestion, I have modified the application to pop up a
dialog when the "Only allow access to specific users" button". The
dialog asks the user to choose at least one user from the list. The
app will no longer allow you to create a share with no valid users
unless the "Allow access to everyone" radio button is selected.
Should be fixed in system-config-samba-1.2.5-1. Thanks for your report.