RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1166160 - 'pcs acl role create' does not check syntax properly
Summary: 'pcs acl role create' does not check syntax properly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Tomas Jelinek
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-20 13:43 UTC by michal novacek
Modified: 2015-11-19 09:33 UTC (History)
5 users (show)

Fixed In Version: pcs-0.9.142-2.el7
Doc Type: Bug Fix
Doc Text:
Cause: User runs a 'pcs acl role create' command with a mistake in it. Consequence: pcs creates an empty acl role and does not report any error to the user. Fix: Validate parameters of the 'pcs acl role create' command properly and report any errors found. Result: pcs reports an error and does not create any acl role.
Clone Of:
Environment:
Last Closed: 2015-11-19 09:33:41 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
proposed fix (13.66 KB, patch)
2015-04-17 13:26 UTC, Tomas Jelinek 		no flags Details | Diff
proposed fix 2 (5.59 KB, patch)
2015-06-29 10:08 UTC, Tomas Jelinek 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2290 0 normal SHIPPED_LIVE Moderate: pcs security, bug fix, and enhancement update 2015-11-19 09:43:53 UTC

Description michal novacek 2014-11-20 13:43:58 UTC 
Description of problem:
'pcs acl create role' accepts incorrect syntax that leads to empty acl role which is confusing behaviour.

Version-Release number of selected component (if applicable):
pcs-0.9.135-1.el7.x86_64

How reproducible: always

Steps to Reproduce:
1. pcs acl role create no-resources2 deny '//resources'
2. pcs acl show

Actual results: role created with no content

Expected results: pcs would not run and complaint about incorrect syntax (id or
xpath missing in this case.)

Additional info:
[root@host-004 pcsd]# pcs acl role create all-except-resources deny '//resources'
[root@host-004 pcsd]# echo $?
0
[root@host-004 pcsd]# pcs acl show
User: misacek
  Roles: 
Role: all-except-resources
[root@host-004 pcsd]# pcs cluster cib | grep acl
    <acls>
      <acl_target id="misacek"/>
      <acl_role id="all-except-resources"/>
    </acls>
Comment 4 Tomas Jelinek 2015-04-17 13:26:58 UTC 
Created attachment 1015590 [details]
proposed fix
Comment 6 Tomas Jelinek 2015-06-04 14:33:11 UTC 
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs acl role create no-resources2 deny '//resources'
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs acl show
ACLs are disabled, run 'pcs acl enable' to enable

Role: no-resources2
[root@rh71-node1:~]# pcs cluster cib | grep acl
    <acls>
      <acl_role id="no-resources2"/>
    </acls>



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs acl role create no-resources2 deny '//resources'

Usage: pcs acl role create...
    role create <role name> [description=<description>] [((read | write | deny)
                                                (xpath <query> | id <id>))...]
        Create a role with the name and (optional) description specified.
        Each role can also have an unlimited number of permissions
        (read/write/deny) applied to either an xpath query or the id
        of a specific element in the cib

[root@rh71-node1:~]# echo $?
1
[root@rh71-node1:~]# pcs acl show
ACLs are disabled, run 'pcs acl enable' to enable

[root@rh71-node1:~]# pcs cluster cib | grep acl
Comment 8 Tomas Jelinek 2015-06-29 10:08:20 UTC 
Created attachment 1044306 [details]
proposed fix 2
Comment 9 Tomas Jelinek 2015-07-13 12:43:18 UTC 
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.141-1.el7.x86_64
[root@rh71-node1:~]# pcs acl role create test-role read XPath /

Usage: pcs acl role create...
    role create <role name> [description=<description>] [((read | write | deny)
                                                (xpath <query> | id <id>))...]
        Create a role with the name and (optional) description specified.
        Each role can also have an unlimited number of permissions
        (read/write/deny) applied to either an xpath query or the id
        of a specific element in the cib

[root@rh71-node1:~]# echo $?
1
[root@rh71-node1:~]# pcs acl role create test-role read xpath /
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs acl permission add test-role write XPath /

Usage: pcs acl permission add...
    permission add <role name> ((read | write | deny) (xpath <query> |
                                                                id <id>))...
        Add the listed permissions to the role specified

[root@rh71-node1:~]# echo $?
1
[root@rh71-node1:~]# pcs acl
ACLs are disabled, run 'pcs acl enable' to enable

Role: test-role
  Permission: read xpath / (test-role-read)


Also it is not possible to add permissions to a role using web UI.



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.142-2.el7.x86_64
[root@rh71-node1:~]# pcs acl role create test-role read XPath /
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs acl permission add test-role write XPath /
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs acl
ACLs are disabled, run 'pcs acl enable' to enable

Role: test-role
  Permission: read xpath / (test-role-read)
  Permission: write xpath / (test-role-write)


It is possible to add permissions to a role using web UI.
Comment 13 errata-xmlrpc 2015-11-19 09:33:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html
Note You need to log in before you can comment on or make changes to this bug.