Bug 1166328 - vm-restricted is no longer used by restricted users
Summary: vm-restricted is no longer used by restricted users
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.2.0
Hardware: All
OS: All
unspecified
medium
Target Milestone: GA
: 5.4.0
Assignee: Harpreet Kataria
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks: 1171342
TreeView+ depends on / blocked
 
Reported: 2014-11-20 20:42 UTC by Josh Carter
Modified: 2018-12-09 19:13 UTC (History)
4 users (show)

Fixed In Version: 5.4.0.0.11
Doc Type: Bug Fix
Doc Text:
In the previous version of CloudForms Management Engine, users linked to restricted access roles that limited their access to virtual machines or templates owned by them, were incorrectly presented with an unrestricted view on the virtual machine explorer. The reason for this issue was that the virtual machine explorer was using an unrestricted view on restricted users. The bug was fixed by changing the virtual machine explorer view, from unrestricted to restricted, for restricted users. Restricted users are now only able to browse virtual machines or templates that they own in the new version of CloudForms Management Engine.
Clone Of:
: 1171342 (view as bug list)
Environment:
Last Closed: 2015-06-16 12:45:05 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1100 0 normal SHIPPED_LIVE CFME 5.4.0 bug fixes, and enhancement update 2015-06-16 16:28:42 UTC

Description Josh Carter 2014-11-20 20:42:06 UTC
Description of problem:
Users that are linked to roles that are restricted to vms/templates that they own or their group owns should use the /var/www/miq/vmdb/product/views/Vm_restricted.yaml. Now the users have full access and are directed to /var/www/miq/vmdb/product/VmOrTemplates.yaml 

Version-Release number of selected component (if applicable): 5.2.5


How reproducible:
confirmed it still happens on upstream code

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 CFME Bot 2015-01-07 00:26:07 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=ca4a48289c9a7b7fd531dd98745be45c4e9a2cc5

commit ca4a48289c9a7b7fd531dd98745be45c4e9a2cc5
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Jan 6 11:05:02 2015 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jan 6 18:30:15 2015 -0500

    Load Vm__restricted.yaml for restricted users in VM explorers.
    
    Fixed code to load Vm__restricted.yaml in VM explorers for restricted users. Moved code out to a new method that sets the yaml filename and added a spec test around the new method. After loading VM__restricted yaml, need to replace view.db to the one that came in with get_db_view method call, view.db in the YAML is set to Vm which causes all Infra/Cloud VMs to show up together in the explorers.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1171342
    https://bugzilla.redhat.com/show_bug.cgi?id=1166328
    (cherry picked from commit 8e9da64)

 vmdb/app/controllers/application_controller.rb     | 28 ++++++++++++----------
 .../controllers/application_controller_spec.rb     | 24 +++++++++++++++++++
 2 files changed, 39 insertions(+), 13 deletions(-)

Comment 4 CFME Bot 2015-01-07 00:26:10 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/8e9da6425fbe8a5d2346a3609170457eb71353a1

commit 8e9da6425fbe8a5d2346a3609170457eb71353a1
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Jan 6 11:05:02 2015 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Jan 6 17:15:18 2015 -0500

    Load Vm__restricted.yaml for restricted users in VM explorers.
    
    Fixed code to load Vm__restricted.yaml in VM explorers for restricted users. Moved code out to a new method that sets the yaml filename and added a spec test around the new method. After loading VM__restricted yaml, need to replace view.db to the one that came in with get_db_view method call, view.db in the YAML is set to Vm which causes all Infra/Cloud VMs to show up together in the explorers.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1171342
    https://bugzilla.redhat.com/show_bug.cgi?id=1166328

 vmdb/app/controllers/application_controller.rb     | 28 ++++++++++++----------
 .../controllers/application_controller_spec.rb     | 24 +++++++++++++++++++
 2 files changed, 39 insertions(+), 13 deletions(-)

Comment 5 CFME Bot 2015-01-07 15:01:04 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=30be9000e0fc4f8efa96d6bc487631358cd35fad

commit 30be9000e0fc4f8efa96d6bc487631358cd35fad
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Jan 7 09:56:51 2015 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Jan 7 09:56:51 2015 -0500

    Fixed failing spec test on 5.3.z
    
    Replaced call to EvmSpecHelper.seed_specific_product_features on 5.3.z with MiqProductFeature.seed_specific_features
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1171342
    https://bugzilla.redhat.com/show_bug.cgi?id=1166328

 vmdb/spec/controllers/application_controller_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 7 Ramesh A 2015-03-17 17:59:17 UTC
Good to go.  Verified and working fine in 5.4.0.0.12.20150312013923_aa9b093

Comment 9 errata-xmlrpc 2015-06-16 12:45:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html


Note You need to log in before you can comment on or make changes to this bug.