Bug 1166667 - Review Request: perl-Lingua-EN-Words2Nums - Convert English text to numbers
Summary: Review Request: perl-Lingua-EN-Words2Nums - Convert English text to numbers
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1166670
TreeView+ depends on / blocked
 
Reported: 2014-11-21 12:53 UTC by Petr Šabata
Modified: 2014-11-24 15:04 UTC (History)
2 users (show)

Fixed In Version: perl-Lingua-EN-Words2Nums-0.18-1.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-24 15:04:13 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-11-21 12:53:18 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Lingua-EN-Words2Nums/perl-Lingua-EN-Words2Nums.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Lingua-EN-Words2Nums/perl-Lingua-EN-Words2Nums-0.18-1.fc20.src.rpm
Description:
This module converts English text into numbers. It supports both ordinal
and cardinal numbers, negative numbers, and very large numbers.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2014-11-21 14:25:34 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 686556797cd2a4eaa066f19bbf03ab25c06278292c9ead2f187dfd9031ea1d85). Ok.
License verified from README and Words2Nums.pm. Ok.
Summary verified from Words2Nums.pm. Ok.
Description verified from Words2Nums.pm. Ok.
No XS code, noarch BuildArch is Ok.
All build-requires are declared. Ok.
All tests pass. Ok.

$ rpmlint perl-Lingua-EN-Words2Nums.spec ../SRPMS/perl-Lingua-EN-Words2Nums-0.18-1.fc22.src.rpm ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Nov 21 15:21 /usr/share/doc/perl-Lingua-EN-Words2Nums
-rw-r--r--    1 root    root                      439 Dec 17  2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/README
-rw-r--r--    1 root    root                      311 Dec 17  2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/TODO
-rw-r--r--    1 root    root                     2486 Dec 17  2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/samples
-rw-r--r--    1 root    root                      263 Dec 17  2008 /usr/share/doc/perl-Lingua-EN-Words2Nums/testnum
-rw-r--r--    1 root    root                     2021 Nov 21 15:21 /usr/share/man/man3/Lingua::EN::Words2Nums.3pm.gz
drwxr-xr-x    2 root    root                        0 Nov 21 15:21 /usr/share/perl5/vendor_perl/Lingua
drwxr-xr-x    2 root    root                        0 Nov 21 15:21 /usr/share/perl5/vendor_perl/Lingua/EN
-rw-r--r--    1 root    root                     8159 Dec 17  2008 /usr/share/perl5/vendor_perl/Lingua/EN/Words2Nums.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(Lingua::EN::Words2Nums)
      1 perl-Lingua-EN-Words2Nums = 0.18-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Lingua-EN-Words2Nums-0.18-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8202029). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Resolution: Package APPROVED.

Comment 2 Petr Šabata 2014-11-24 09:26:46 UTC
New Package SCM Request
=======================
Package Name: perl-Lingua-EN-Words2Nums
Short Description: Convert English text to numbers
Upstream URL: http://search.cpan.org/dist/Lingua-EN-Words2Nums
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-11-24 13:48:58 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2014-11-24 15:02:21 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.