Bug 1166703 - [RFE] builder.py should print an error and exit if it is run from the master branch
Summary: [RFE] builder.py should print an error and exit if it is run from the master ...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Pulp
Classification: Retired
Component: rel-eng
Version: Master
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 2.6.0
Assignee: Jeremy Cline
QA Contact: pulp-qe-list
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-21 13:45 UTC by Chris Duryee
Modified: 2015-02-28 23:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-19 01:20:27 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Pulp Redmine 271 0 None None None Never

Description Chris Duryee 2014-11-21 13:45:17 UTC 
Description: 

If you miss a step during the build setup process, you may accidentally run ./builder.py from the master branch. This is almost always incorrect; builder.py should run a branch like 2.6-dev or 2.4-release.

This bug is an RFE to print an error if builder.py is run from a git checkout that is currently on master. We can possibly add an override command-line option as well to allow builder.py to run from master if the user really wants to do that.

The "am I on master?" check should be performed before builder.py does anything else.
Comment 1 Randy Barlow 2014-11-21 14:39:32 UTC 
This seems reasonable. That override flag might be necessary if we want to have nightly builds.
Comment 2 Jeremy Cline 2014-12-03 18:08:34 UTC 
https://github.com/pulp/pulp/pull/1387
Comment 3 Chris Duryee 2014-12-23 20:52:54 UTC 
fixed in pulp 2.6.0-0.2.beta
Comment 4 Brian Bouterse 2015-02-19 01:20:27 UTC 
Moved to https://pulp.plan.io/issues/271
Note You need to log in before you can comment on or make changes to this bug.