1166863 – teamd: implement link failure counting

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1166863 - teamd: implement link failure counting

Summary: teamd: implement link failure counting

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libteam
Sub Component:
Version:	7.1
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	Rashid Khan
QA Contact:	Amit Supugade
Docs Contact:
URL:
Whiteboard:
Depends On:	1208418
Blocks:
TreeView+	depends on / blocked

Reported:	2014-11-21 18:54 UTC by Jiri Pirko
Modified:	2016-11-29 21:06 UTC (History)
CC List:	3 users (show)
Fixed In Version:	libteam-1.17-1.el7
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2015-11-19 03:55:37 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2015:2176	0	normal	SHIPPED_LIVE	libteam bug fix and enhancement update	2015-11-19 07:52:34 UTC

Description Jiri Pirko 2014-11-21 18:54:39 UTC

Teamd does not support link failure counting. This should be equivalent of "Link Failure Count: X" line in bonding proc. Please implement it.

Comment 1 Jiri Pirko 2015-03-16 10:52:03 UTC

Upstream commits:

https://github.com/jpirko/libteam/commit/42a1692e386e9d5276397bf6d6468c08374f2966
https://github.com/jpirko/libteam/commit/633f943d24fd55d5eb7d5b31301de89950131d3f

Comment 6 Amit Supugade 2015-08-03 13:12:28 UTC

Verified on- 3.10.0-295.el7.x86_64

[root@sam ~]# teamd -d -t team0
[601071.239968] team0: Mode changed to "roundrobin"
[root@sam ~]# ip link set enp7s0f0 down
[root@sam ~]# ip link set enp7s0f1 down
[root@sam ~]# teamdctl team0 port add enp7s0f0
[601208.472693] be2net 0000:07:00.0: MAC address changed to 02:15:42:fb:62:38
[601208.560528] be2net 0000:07:00.0 enp7s0f0: Link is Up
[601208.627055] team0: Port device enp7s0f0 added
[root@sam ~]# [601208.682685] be2net 0000:07:00.0: MAC address changed to 00:90:fa:8a:5b:fa

[root@sam ~]# teamdctl team0 port add enp7s0f1
[601212.261678] be2net 0000:07:00.1: MAC address changed to 00:90:fa:8a:5b:fa
[601212.349322] be2net 0000:07:00.1 enp7s0f1: Link is Up
[601212.418451] team0: Port device enp7s0f1 added
[root@sam ~]# 
[root@sam ~]# 
[root@sam ~]# ip link set team0 up
[root@sam ~]# [601223.451192] IPv6: team0: IPv6 duplicate address fe80::290:faff:fe8a:5bfa detected!

[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0

Comment 7 Amit Supugade 2015-08-04 16:26:46 UTC

The output showing increased count when link failure occurs.

Verified on- libteam-1.17-1.el7.x86_64

[root@sam ~]# rpm -q libteam
libteam-1.17-1.el7.x86_64

[root@sam ~]# teamd -v
teamd 1.17

[root@sam ~]# teamd -d -t team0
[ 6210.170563] team0: Mode changed to "roundrobin"
[root@sam ~]# ip link set enp7s0f0 down
[root@sam ~]# ip link set enp7s0f1 down
[root@sam ~]# teamdctl team0 port add enp7s0f0
[ 6251.815737] be2net 0000:07:00.0: MAC address changed to 3a:9f:ff:0a:8e:07
[ 6251.902499] be2net 0000:07:00.0 enp7s0f0: Link is Up
[ 6251.967992] team0: Port device enp7s0f0 added
[root@sam ~]# [ 6252.022129] be2net 0000:07:00.0: MAC address changed to 00:90:fa:8a:5b:fa

[root@sam ~]# teamdctl team0 port add enp7s0f1
[ 6258.367409] be2net 0000:07:00.1: MAC address changed to 00:90:fa:8a:5b:fa
[ 6258.454067] be2net 0000:07:00.1 enp7s0f1: Link is Up
[ 6258.519637] team0: Port device enp7s0f1 added
[root@sam ~]#
[root@sam ~]# ip link set team0 up
[root@sam ~]# [ 6283.022175] IPv6: team0: IPv6 duplicate address fe80::290:faff:fe8a:5bfa detected!

[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
[root@sam ~]# ip link set team0 down
[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
[root@sam ~]# ip link set team0 up
[root@sam ~]# [ 6327.470647] IPv6: team0: IPv6 duplicate address fe80::290:faff:fe8a:5bfa detected!

[root@sam ~]#

[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0

[root@sam ~]# ip link set enp7s0f0 down
[root@sam ~]# ip link set enp7s0f0 up
[ 6395.151183] be2net 0000:07:00.0 enp7s0f0: Link is Up
[root@sam ~]#
[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 1
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 0

[root@sam ~]# ip link set enp7s0f1 down
[root@sam ~]# ip link set enp7s0f1 up
[ 6412.647723] be2net 0000:07:00.1 enp7s0f1: Link is Up
[root@sam ~]# teamdctl team0 state
setup:
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 1
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 1

[root@sam ~]# ip link set enp7s0f1 down
[root@sam ~]# ip link set enp7s0f1 up
[ 6426.954332] be2net 0000:07:00.1 enp7s0f1: Link is Up
[root@sam ~]# teamdctl team0 state
setup:
  runner: roundrobin
ports:
  enp7s0f0
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 1
  enp7s0f1
    link watches:
      link summary: up
      instance[link_watch_0]:
        name: ethtool
        link: up
        down count: 2
[root@sam ~]#

Comment 9 errata-xmlrpc 2015-11-19 03:55:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2176.html

Note You need to log in before you can comment on or make changes to this bug.