Bug 1167029 - additional patch for gst-1.0 support (when hw decoder is in the pipeline, via gst-vaapi)
Summary: additional patch for gst-1.0 support (when hw decoder is in the pipeline, via...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: banshee
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-22 19:11 UTC by Fabrice Bellet
Modified: 2014-12-12 04:06 UTC (History)
4 users (show)

Fixed In Version: banshee-2.6.2-7.fc21
Clone Of:
Environment:
Last Closed: 2014-12-12 04:06:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
updated patch (1014 bytes, patch)
2014-12-01 20:42 UTC, Fabrice Bellet
no flags Details | Diff

Description Fabrice Bellet 2014-11-22 19:11:31 UTC
Hi!

with the next version of gstreamer-vaapi, the vaapisink will handle GstNavigation stuff, and this will break banshee, according the the gnome bug I submitted (gnome bz#739808). 

I suggest adding a call to gst_video_overlay_handle_events (player->video_overlay, FALSE) in banshee-player-video.c to the gst-1.0 patch we provide (comment #3)

Comment 1 Tom "spot" Callaway 2014-11-26 21:02:56 UTC
I've applied this change in f21 & rawhide, the patch in Fedora git is:

banshee-2.6.2-gst1.0-handle-events-fix.patch

Comment 2 Fedora Update System 2014-11-26 21:04:06 UTC
banshee-2.6.2-6.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/banshee-2.6.2-6.fc21

Comment 3 Fedora Update System 2014-11-27 19:27:58 UTC
Package banshee-2.6.2-6.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing banshee-2.6.2-6.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15881/banshee-2.6.2-6.fc21
then log in and leave karma (feedback).

Comment 4 Fabrice Bellet 2014-12-01 20:42:39 UTC
Created attachment 963424 [details]
updated patch

Hi!
The patch doesn't work for me, because g_object_class_find_property (G_OBJECT_GET_CLASS (player->video_overlay), "handle-events") returns false in the case of vaapisink.

Comment 5 Fedora Update System 2014-12-02 20:34:34 UTC
banshee-2.6.2-7.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/banshee-2.6.2-7.fc21

Comment 6 Fedora Update System 2014-12-12 04:06:09 UTC
banshee-2.6.2-7.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.