Bug 1167087
| Summary: | [BLOCKED] LUN ID checkbox is still checked when switching between iSCSI host selection under LUNs -> Targets | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Gilad Lazarovich <glazarov> | ||||
| Component: | Frontend.UserPortal | Assignee: | Idan Shaby <ishaby> | ||||
| Status: | CLOSED DEFERRED | QA Contact: | Raz Tamir <ratamir> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | --- | CC: | acanan, amureini, bugs, lsurette, rbalakri, Rhev-m-bugs, srevivo, tnisan, ykaul, ylavi | ||||
| Target Milestone: | --- | Keywords: | UserExperience | ||||
| Target Release: | --- | Flags: | rule-engine:
ovirt-4.2?
rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack? |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-07-24 13:51:58 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1093025 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
The other possible fix is to allow the LUN IDs checkbox to be checked across host selections and ensure LUNs remain checked after discussing with Liz:
the following two conditions should be fulfilled at any given time:
(1) a LUN should be selected only if the user chose to select it, i.e. the user either checked the check-box next to that specific LUN, or the user checked the header check-box which selects everything underneath it *for that particular point in time*.
(2) the header check-box should reflect, at any given time, the status of the LUN selection check-boxes (i.e. in the grid body).
I.e.:
- the check-box should be checked if everything underneath it *at that point in time* is checked.
- the check-box should be unchecked otherwise.
This means that if I have a group of LUNs [LUN1...LUN{n}] while Host1 is selected, and I check the check-box header to select them all, and then I change the 'Use Host' selection to Host2 (which automatically changes the list to [LUNa...LUNz]):
(a) no LUN should be selected *unless it was previously selected*.
(b) if there are now un-selected LUNs [per (a)] - the header check-box should be unchecked.
Otherwise (i.e., *all* LUNs are now selected, i.e. *all LUNs in [LUNa...LUNz] are contained within [LUN1...LUN{n}]*), the header check-box should remain checked.
some examples for clarification:
[in all four examples, the header check-box was checked initially (while Host1 was selected as 'Use Host'), and then the 'Use Host' selection changed to Host2]
LUNs for Host1 LUNs for Host2 header check-box
============== ============== ================
[x]LUN1, [x]LUN2, [x]LUN3 [ ]LUN4, [ ]LUN5, [ ]LUN6 [ ]
---------------------------------------------------------------------------
[x]LUN1, [x]LUN2, [x]LUN3 [x]LUN1, [x]LUN2, [ ]LUN4 [ ]
---------------------------------------------------------------------------
[x]LUN1, [x]LUN2, [x]LUN3 [x]LUN1, [x]LUN2, [x]LUN3 [x]
---------------------------------------------------------------------------
[x]LUN1, [x]LUN2, [x]LUN3 [x]LUN1, [x]LUN2 [x]
please feel free to needinfo Liz/me if any additional UXD assistance is needed.
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. This depends on bug 1093025, which isn't targetted. Closing, until there's a plan to implement it. |
Created attachment 960432 [details] LUN IDs checkbox checked with no actual LUNs selected when switching hosts Description of problem: LUN ID checkbox is still checked when switching between iSCSI host selection under LUNs -> Targets Version-Release number of selected component (if applicable): 3.5 vt11 How reproducible: 100% Steps to Reproduce: 1. Click on the Storage tab and then click on the New Domain button 2. Choose a Data / iSCSI domain 3. Click on the LUNs -> Targets tab for one of the hosts in the setup 4. Click on the LUN IDs checkbox to select all available LUNs 5. Select another host from the “Use Host” dropdown menu Actual results: The LUN IDs checkbox is still selected, but none of the LUNs are actually selected Expected results: The LUN IDs checkbox selection should be cleared when switching between hosts