Bug 1167164
| Summary: | bkr list-systems --xml-filter with invalid XML syntax prints a 500 error page | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | Dan Callaghan <dcallagh> |
| Component: | general | Assignee: | Dan Callaghan <dcallagh> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 0.18 | CC: | aigao, asaha, dcallagh, dowang |
| Target Milestone: | 19.1 | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-17 08:40:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Beaker 19.1 is released. |
Version-Release number of selected component (if applicable): 0.18.5 Steps to Reproduce: 1. bkr list-systems --xml-filter '<invalid' Actual results: A huge HTML 500 error page is printed, including the stack trace: [...] File "/home/dcallagh/work/beaker/Server/bkr/server/controllers.py", line 494, in _systems systems = XmlHost.from_string('<and>%s</and>' % kw['xmlsearch']).apply_filter(systems) File "/home/dcallagh/work/beaker/Server/bkr/server/needpropertyxml.py", line 1136, in from_string return cls(etree.fromstring(xml_string)) File "lxml.etree.pyx", line 2532, in lxml.etree.fromstring (src/lxml/lxml.etree.c:48270) File "parser.pxi", line 1545, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:71812) File "parser.pxi", line 1417, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:70608) File "parser.pxi", line 898, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:67148) File "parser.pxi", line 539, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:63824) File "parser.pxi", line 625, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:64745) File "parser.pxi", line 565, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:64088) XMLSyntaxError: error parsing attribute name, line 1, column 12 Expected results: Sensible error message indicating the XML syntax error.