Created attachment 960674 [details] engine log Description of problem: [GUI]>[Pools] > New pool > double clicking on 'ok' will create the same pool twice with wrong calculation of vm's in pool. In the event log will be error about creating the pool, but the pool will be created twice, with the same name and wrong number of vm's in the pool. Version-Release number of selected component (if applicable): 3.5.0-0.21.el6ev How reproducible: always Steps to Reproduce: 1. [Pools] > new pool> create new pool(can be from template) with 50 vm's in pool 2. click double click on 'ok' to approve operation 3. Actual results: The same pool will be created twice with the same name, and wrong number of vm's. each pool will get something like 27-28 vm's per pool. Expected results: Pool should be created once with the right amount of vm's.
Occe the UI is solved it's going to solve this bug too.
regarding REST API calls..well, for 2 same requests you would get twice as many VMs...but that's basically what you would have asked for - so it works. Not worth adding any code around it...
seems the UI issue is fixed? can you confirm if there is no other issue?
Hi Michael, No, i can't confirm. Double click on 'ok' created 4 pool entities named 'mb' with a different number of assigned VMs. attaching engine.log
Created attachment 1033838 [details] new engine log
tested on - 3.6.0-0.0.master.20150519172219.git9a2e2b3.el6
Shmuel, is this fixed by https://gerrit.ovirt.org/#/c/40557 ? we might be able to fix this now that we have locking group for vm pools
No. VM_POOL lock can be taken when the pool is already created and we know its guid. This is ok for pool updates. To avoid creation of two pools with the same name in the same time we need to lock pool name. So we need VM_POOL_NAME lock in addition to VM_POOL lock like we have VM_NAME lock in addition to VM lock.
Verified on - 3.6.0-0.12.master.el6