Bug 1167419 - EC_MAX_NODES is defined incorrectly
Summary: EC_MAX_NODES is defined incorrectly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Xavi Hernandez
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1170959
TreeView+ depends on / blocked
 
Reported: 2014-11-24 17:14 UTC by Feng Wang
Modified: 2015-05-14 17:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of:
: 1170959 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:28:33 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Feng Wang 2014-11-24 17:14:27 UTC
Description of problem:

The macro is defined in ec.c file as the following statement.

#define EC_MAX_NODES    (EC_MAX_FRAGMENTS + ((EC_MAX_FRAGMENTS - 1) / 2))

However the number of the redundancy should be less than the number of fragment, instead of half of it.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-11-25 08:57:26 UTC
REVIEW: http://review.gluster.org/9193 (ec: Fix incorrect value of EC_MAX_NODES) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-12-04 19:35:23 UTC
COMMIT: http://review.gluster.org/9193 committed in master by Vijay Bellur (vbellur) 
------
commit ca2a3949715fb25862d1e34f9e65283287faa842
Author: Xavier Hernandez <xhernandez>
Date:   Tue Nov 25 09:54:29 2014 +0100

    ec: Fix incorrect value of EC_MAX_NODES
    
    EC_MAX_NODES was incorrectly calculated. Now the value if computed
    as the minimum between the theoretical maximum and the limit imposed
    by the Galois Field.
    
    Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
    BUG: 1167419
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9193
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>

Comment 3 Niels de Vos 2015-05-14 17:28:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:43 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:06 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:45:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.