Bug 1167460 - Review Request: python-pygraphviz - Create and Manipulate Graphs and Networks
Summary: Review Request: python-pygraphviz - Create and Manipulate Graphs and Networks
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mukundan Ragavan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 740687 (view as bug list)
Depends On:
Blocks: 1167478
TreeView+ depends on / blocked
 
Reported: 2014-11-24 20:30 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2014-12-03 01:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-03 01:03:43 UTC
Type: ---
Embargoed:
nonamedotc: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 740687 0 unspecified CLOSED Review Request: python-pygraphviz - PyGraphviz package for Python 2021-02-22 00:41:40 UTC

Internal Links: 740687

Description Zbigniew Jędrzejewski-Szmek 2014-11-24 20:30:56 UTC
Spec URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz-1.3rc2-1.fc22.src.rpm
Description:
PyGraphviz is a Python interface to the Graphviz graph layout and
visualization package. With PyGraphviz you can create, edit, read,
write, and draw graphs using Python to access the Graphviz graph data
structure and layout algorithms. PyGraphviz is independent from
NetworkX but provides a similar programming interface.

Fedora Account System Username: zbyszek

Comment 1 Zbigniew Jędrzejewski-Szmek 2014-11-24 21:35:10 UTC
Note on the version: upstream says that 1.3 will be released soon, so please ignore the 'rc2' in the version, it'll go away before first upload.

Comment 2 Zbigniew Jędrzejewski-Szmek 2014-11-24 21:48:26 UTC
Copr build: https://copr-fe.cloud.fedoraproject.org/coprs/zbyszek/neurord/build/61111/

Comment 3 Mukundan Ragavan 2014-11-25 01:22:03 UTC
As mentioned in the mailing list,

I can review all these three packages. We have break coming up
(from Thursday) and I can review it that day.

I am assigning the bugs to myself. If someone wants to go review the
packages before I get to it, please go ahead.

Comment 4 Thomas Spura 2014-11-25 15:06:20 UTC
*** Bug 740687 has been marked as a duplicate of this bug. ***

Comment 5 Mukundan Ragavan 2014-11-29 17:50:54 UTC
Hi! Here is the detailed review. A few problems that need fixing.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[?]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.

---> BSD license not included in the package. Cannot find the license file in the upstream tarball.

[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 32 files have unknown license. Detailed output of
     licensecheck in /home/mukundan/ownCloud/pkg_reviews/1167460-python-
     pygraphviz/licensecheck.txt

---> This looks fine.

[x]: License file installed when any subpackage combination is installed.

---> No license file in upstream tarball. License explicitly mentioned and is correctly specified in the spec file.

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/python-pygraphviz

---> Subpackage -doc owns %{_pkgdocdir}/html and%{_pkgdocdir}/examples but not the directory itself.

Please fix this.

[x]: %build honors applicable compiler flags or justifies otherwise.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).

---> I suggest some changes under this - 

python2 setup.py ... could be changed to use macros.

%{__python2}, %{__python3}

http://fedoraproject.org/wiki/Packaging:Python#Macros

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[?]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.

---> I think this complaint is about the docs.

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-pygraphviz , python-pygraphviz-doc

---> This looks fine to me.

[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8259181

[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-pygraphviz-1.3rc2-1.fc22.x86_64.rpm
          python3-pygraphviz-1.3rc2-1.fc22.x86_64.rpm
          python-pygraphviz-doc-1.3rc2-1.fc22.noarch.rpm
          python-pygraphviz-1.3rc2-1.fc22.src.rpm
python-pygraphviz.x86_64: E: invalid-version 1.3rc2
python3-pygraphviz.x86_64: E: invalid-version 1.3rc2
python-pygraphviz-doc.noarch: E: invalid-version 1.3rc2


---> Version should not contain alpha, rc, etc. tags. You will have to update the package using epoch tags. move rc2 to release tag.


python-pygraphviz-doc.noarch: E: zero-length /usr/share/doc/python-pygraphviz/html/_static/empty.txt

---> Is this file needed?

python-pygraphviz-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-pygraphviz/html/_static/jquery.js


---> Please fix this.

python-pygraphviz.src: E: invalid-version 1.3rc2
4 packages and 0 specfiles checked; 5 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@imladris /]# rpmlint python-pygraphviz python-pygraphviz-doc python3-pygraphviz
python-pygraphviz.x86_64: E: invalid-version 1.3rc2
python-pygraphviz-doc.noarch: E: invalid-version 1.3rc2
python-pygraphviz-doc.noarch: E: zero-length /usr/share/doc/python-pygraphviz/html/_static/empty.txt
python-pygraphviz-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-pygraphviz/html/_static/jquery.js
python3-pygraphviz.x86_64: E: invalid-version 1.3rc2
3 packages and 0 specfiles checked; 4 errors, 1 warnings.
]0;<mock-chroot><mock-chroot>[root@imladris /]# echo 'rpmlint-done:'



Requires
--------
python-pygraphviz (rpmlib, GLIBC filtered):
    graphviz-python
    libc.so.6()(64bit)
    libcdt.so.5()(64bit)
    libcgraph.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-pygraphviz-doc (rpmlib, GLIBC filtered):
    python-pygraphviz

python3-pygraphviz (rpmlib, GLIBC filtered):
    graphviz-python
    libc.so.6()(64bit)
    libcdt.so.5()(64bit)
    libcgraph.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython3.4m.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)



Provides
--------
python-pygraphviz:
    python-pygraphviz
    python-pygraphviz(x86-64)

python-pygraphviz-doc:
    python-pygraphviz-doc

python3-pygraphviz:
    python3-pygraphviz
    python3-pygraphviz(x86-64)



Unversioned so-files
--------------------
python-pygraphviz: /usr/lib64/python2.7/site-packages/pygraphviz/_graphviz.so
python3-pygraphviz: /usr/lib64/python3.4/site-packages/pygraphviz/_graphviz.cpython-34m.so

Source checksums
----------------
http://pypi.python.org/packages/source/p/pygraphviz/pygraphviz-1.3rc2.tar.gz :
  CHECKSUM(SHA256) this package     : ff7924c6ebe03f8fc949c1ca958f5a62b1f6db055d3cc0a062ab01eb4f5a8233
  CHECKSUM(SHA256) upstream package : ff7924c6ebe03f8fc949c1ca958f5a62b1f6db055d3cc0a062ab01eb4f5a8233


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1167460
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api, C/C++
Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 6 Zbigniew Jędrzejewski-Szmek 2014-11-29 23:37:15 UTC
(In reply to Mukundan Ragavan from comment #5)
> Hi! Here is the detailed review. A few problems that need fixing.
Thank you for the review. I think I fixed or justified everything. Specific comments below.

> [?]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.
This is private python libraries. They are not in ld path.

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/doc/python-pygraphviz
Damn, those last minute changes. Fixed.

> [!]: Package consistently uses macros (instead of hard-coded directory
> names).
> 
> ---> I suggest some changes under this - 
> 
> python2 setup.py ... could be changed to use macros.
> 
> %{__python2}, %{__python3}
I don't think that it matter to much, but I changed to %{__python2} and %{__python3}.

> Generic:
> [!]: Uses parallel make %{?_smp_mflags} macro.
Added to make invocation.

> [x]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>      python3-pygraphviz , python-pygraphviz-doc
> 
> ---> This looks fine to me.
Yes, those packages are functionally independent.

> Rpmlint
> -------
> Checking: python-pygraphviz-1.3rc2-1.fc22.x86_64.rpm
>           python3-pygraphviz-1.3rc2-1.fc22.x86_64.rpm
>           python-pygraphviz-doc-1.3rc2-1.fc22.noarch.rpm
>           python-pygraphviz-1.3rc2-1.fc22.src.rpm
> python-pygraphviz.x86_64: E: invalid-version 1.3rc2
> python3-pygraphviz.x86_64: E: invalid-version 1.3rc2
> python-pygraphviz-doc.noarch: E: invalid-version 1.3rc2
> 
> 
> ---> Version should not contain alpha, rc, etc. tags. You will have to
> update the package using epoch tags. move rc2 to release tag.
Yeah. Still waiting for upstream release.

> python-pygraphviz-doc.noarch: E: zero-length
> /usr/share/doc/python-pygraphviz/html/_static/empty.txt
> 
> ---> Is this file needed?
Doesn't seem to be. Removed in %prep.

> python-pygraphviz-doc.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/python-pygraphviz/html/_static/jquery.js
> 
> 
> ---> Please fix this.
This is bundled jquery. I added 'Provides: bundled(jquery)' as described by
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries.

> python-pygraphviz.src: E: invalid-version 1.3rc2
> 4 packages and 0 specfiles checked; 5 errors, 1 warnings.

Spec URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz-1.3rc2-2.fc22.src.rpm

Comment 7 Mukundan Ragavan 2014-11-30 21:20:37 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)


> > python-pygraphviz-doc.noarch: E: invalid-version 1.3rc2
> > 
> > 
> > ---> Version should not contain alpha, rc, etc. tags. You will have to
> > update the package using epoch tags. move rc2 to release tag.
> Yeah. Still waiting for upstream release.
> 

Hi! I guess I should have been clearer. What I meant was this - 

Now, the spec file states,

Name:           python-pygraphviz
Version:        1.3rc2
Release:        2%{?dist}


What you could do is

Name:           python-pygraphviz
Version:        1.3
Release:        2.rc2%{?dist}

See 

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Version_Tag

and 

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

for more detailed explanation.

Comment 8 Mukundan Ragavan 2014-11-30 21:59:46 UTC
I have looked at the updated spec and srpm. The package name would be main (and I think only) concern.

Comment 9 Zbigniew Jędrzejewski-Szmek 2014-12-01 03:07:38 UTC
I wanted to wait for upstream to release 1.3, but since I have no idea when this will happen, I followed your advice and changed the tag to 1.3-2.rc2.


Spec URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/python-pygraphviz-1.3-2.rc2.fc22.src.rpm

Comment 10 Mukundan Ragavan 2014-12-02 01:19:14 UTC
I have no other issues here.

Package APPROVED.

Comment 11 Mukundan Ragavan 2014-12-02 01:19:22 UTC
I also have 1167468 assigned to myself. Once this and bionetgen are built on koji, I will review that as well.

Comment 12 Zbigniew Jędrzejewski-Szmek 2014-12-02 15:54:04 UTC
New Package SCM Request
=======================
Package Name: python-pygraphviz
Short Description: Create and Manipulate Graphs and Networks
Upstream URL: http://networkx.lanl.gov/pygraphviz/
Owners: zbyszek
Branches: f19 f20 f21 epel7
InitialCC:

Comment 13 Gwyn Ciesla 2014-12-02 20:50:07 UTC
Git done (by process-git-requests).

Comment 14 Zbigniew Jędrzejewski-Szmek 2014-12-03 01:03:43 UTC
Updates have been submitted.


Note You need to log in before you can comment on or make changes to this bug.