Spec URL: http://declera.com/~yaneti/gsound/gsound.spec SRPM URL: http://declera.com/~yaneti/gsound/gsound-0.98.0-0.1.a648648.fc22.src.rpm Description: GSound is a small library for playing system sounds. It's designed to be used via GObject Introspection, and is a thin wrapper around the libcanberra C library Fedora Account System Username: yaneti
Spec URL: http://declera.com/~yaneti/gsound/gsound.spec SRPM URL: http://declera.com/~yaneti/gsound/gsound-0.98.0-0.2.a648648.fc22.src.rpm 0.98.0-0.2.a648648 - Additional patch + references + using %%autopatch
Spec URL: http://declera.com/~yaneti/gsound/gsound.spec SRPM URL: http://declera.com/~yaneti/gsound/gsound-1.0.0-1.fc22.src.rpm 1.0.0-1 - Update to 1.0.0. drop upstreamed paches - 1.0.0-1
Owning the /usr/share/gtk-doc directory is what is done in other packages (and is recommended by the packaging guidelines https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function), so that should be changed. The other unowned directories in /usr/share should also be owned by this package. Other than that, looks good to me, although it would be nice if the tools/gsound-play.vala source file had a license header. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1167482-gsound/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gir-1.0, /usr/share /gtk-doc, /usr/share/vala/vapi, /usr/share/gtk-doc/html, /usr/lib64/girepository-1.0, /usr/share/vala [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gsound-1.0.0-1.fc22.x86_64.rpm gsound-devel-1.0.0-1.fc22.x86_64.rpm gsound-1.0.0-1.fc22.src.rpm gsound.x86_64: W: spelling-error Summary(en_US) gobject -> object, g object gsound.x86_64: W: spelling-error %description -l en_US libcanberra -> Canberra gsound.x86_64: W: no-manual-page-for-binary gsound-play gsound-devel.x86_64: W: only-non-binary-in-usr-lib gsound.src: W: spelling-error Summary(en_US) gobject -> object, g object gsound.src: W: spelling-error %description -l en_US libcanberra -> Canberra 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# rpmlint gsound gsound-devel gsound.x86_64: W: spelling-error Summary(en_US) gobject -> object, g object gsound.x86_64: W: spelling-error %description -l en_US libcanberra -> Canberra gsound.x86_64: W: no-manual-page-for-binary gsound-play gsound-devel.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 4 warnings. ]0;<mock-chroot><mock-chroot>[root@lenovodave /]# echo 'rpmlint-done:' Requires -------- gsound (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcanberra.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgsound.so.0()(64bit) rtld(GNU_HASH) gsound-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gsound(x86-64) libgsound.so.0()(64bit) Provides -------- gsound: gsound gsound(x86-64) libgsound.so.0()(64bit) gsound-devel: gsound-devel gsound-devel(x86-64) pkgconfig(gsound) Source checksums ---------------- http://download.gnome.org/sources/gsound/1.0/gsound-1.0.0.tar.xz : CHECKSUM(SHA256) this package : b6acc33a6ed7198af6abaa56b5f9eb0f895903297697a214a37c132e4ab75b51 CHECKSUM(SHA256) upstream package : b6acc33a6ed7198af6abaa56b5f9eb0f895903297697a214a37c132e4ab75b51 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1167482 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks for the review. Spec URL: http://declera.com/~yaneti/gsound/gsound.spec SRPM URL: http://declera.com/~yaneti/gsound/gsound-1.0.0-2.fc22.src.rpm 1.0.0-2 - Own some more directories as per review (#1167482) - 1.0.0-2 About the license header for gsound-play.vala, filed https://bugzilla.gnome.org/show_bug.cgi?id=740931
Looks great, thanks for the quick improvements!
New Package SCM Request ======================= Package Name: gsound Short Description: Small gobject library for playing system sounds Owners: yaneti Branches: f21
Git done (by process-git-requests).
gsound-1.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gsound-1.0.1-1.fc21
gsound-1.0.1-1.fc21 has been pushed to the Fedora 21 testing repository.
gsound-1.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.