Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-1.spec SRPM URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-doc-0.1-0.1.fc20.noarch.rpm Description: Client library and command line utility for interacting with Openstack Share API. Fedora Account System Username: zaitcev
Few things: * Requires: python-requests should be versioned or else it will pull the wrong version on EL7 (fixed yesterday a similar bug with python-glanceclient) * Group tag is not required anymore Could you repost links to spec/srpm ?
Other changes: * BR: python2-devel * please use versionned python macros %{__python2} %{python2_sitelib}
Spec URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-2.spec SRPM URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-2.fc20.src.rpm Description: Client library and command line utility for interacting with Openstack Share API. Fedora Account System Username: zaitcev Haikel's comments are addressed in full. The bumped release should identify the correct spec and SRPM.
My apologies Pete, I failed to see your update. There's still one build failure due to missing BuildRequires: python-oslo-sphinx. There should be no other issue remaining.
Spec URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-3.spec SRPM URL: http://people.redhat.com/zaitcev/ftp/manila/python-manilaclient-1.0.1-3.fc21.src.rpm Description: Client library and command line utility for interacting with Openstack Share API. Fedora Account System Username: zaitcev Build verified using mock(1).
I hereby approve this package into Fedora Packages Collection as it complies with our guidelines. Please submit a scm request Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 8 files have unknown license. Detailed output of licensecheck in /home/hguemar/1168005-python-manilaclient-1.0.1-3/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- manilaclient-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-manilaclient-1.0.1-3.fc21.noarch.rpm python-manilaclient-doc-1.0.1-3.fc21.noarch.rpm python-manilaclient-1.0.1-3.fc21.src.rpm python-manilaclient.noarch: W: no-manual-page-for-binary manila python-manilaclient-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-manilaclient-doc/html/_static/jquery.js python-manilaclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-manilaclient-doc/html/objects.inv 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-manilaclient-doc python-manilaclient python-manilaclient-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-manilaclient-doc/html/_static/jquery.js python-manilaclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-manilaclient-doc/html/objects.inv python-manilaclient.noarch: W: no-manual-page-for-binary manila 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- python-manilaclient-doc (rpmlib, GLIBC filtered): python-manilaclient (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-babel python-iso8601 python-keystoneclient python-prettytable python-requests python-simplejson python-six Provides -------- python-manilaclient-doc: python-manilaclient-doc python-manilaclient: python-manilaclient Source checksums ---------------- http://tarballs.openstack.org/python-manilaclient/python-manilaclient-1.0.1.tar.gz : CHECKSUM(SHA256) this package : 35a4666d8d99b3029dae65a984c7beee01678e3555c0ce0c0d94f22920705c7b CHECKSUM(SHA256) upstream package : 35a4666d8d99b3029dae65a984c7beee01678e3555c0ce0c0d94f22920705c7b
New Package SCM Request ======================= Package Name: python-manilaclient Short Description: Client Library for OpenStack Share API Upstream URL: https://github.com/openstack/python-manilaclient Owners: zaitcev Branches: f20 f21 f22 InitialCC:
Git done (by process-git-requests).
social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591