Spec URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client.spec SRPM URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client-3.4.1-1.fc20.src.rpm Description: library allows Java code to interface to AMQP servers Fedora Account System Username: raphgro koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8231256 Reported about deprecation warnings to upstream: https://github.com/rabbitmq/rabbitmq-java-client/issues/23
New version 3.4.2 and some maven improvements. Spec URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client.spec SRPM URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client-3.4.2-1.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8337266
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4321280 bytes in 13 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MPL (v1.1)", "Unknown or generated". 56 files have unknown license. Detailed output of licensecheck in /home/gil/1168017 -rabbitmq-java-client/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-metadata [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-metadata [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rabbitmq- java-client-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rabbitmq-java-client-3.4.2-1.fc22.noarch.rpm rabbitmq-java-client-javadoc-3.4.2-1.fc22.noarch.rpm rabbitmq-java-client-3.4.2-1.fc22.src.rpm rabbitmq-java-client.noarch: W: file-not-utf8 /usr/share/doc/rabbitmq-java-client/channels/channels.tex rabbitmq-java-client.src:57: W: macro-in-comment %{jarname} rabbitmq-java-client.src: E: specfile-error mvn_install: invalid option -- 'J' rabbitmq-java-client.src: E: specfile-error error: Unknown option J in mvn_install() 3 packages and 0 specfiles checked; 2 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rabbitmq-java-client rabbitmq-java-client-javadoc rabbitmq-java-client.noarch: W: file-not-utf8 /usr/share/doc/rabbitmq-java-client/channels/channels.tex 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- rabbitmq-java-client (rpmlib, GLIBC filtered): java-headless jpackage-utils rabbitmq-java-client-javadoc (rpmlib, GLIBC filtered): jpackage-utils Provides -------- rabbitmq-java-client: mvn(com.rabbitmq:amqp-client) mvn(com.rabbitmq:amqp-client:pom:) rabbitmq-java-client rabbitmq-java-client-javadoc: rabbitmq-java-client-javadoc Source checksums ---------------- http://www.rabbitmq.com/releases/rabbitmq-java-client/v3.4.2/rabbitmq-java-client-3.4.2.tar.gz : CHECKSUM(SHA256) this package : e2492d58633624c06b90348cc242704adb40024b8f2c86309a23ee3f419f0721 CHECKSUM(SHA256) upstream package : e2492d58633624c06b90348cc242704adb40024b8f2c86309a23ee3f419f0721 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1168017 --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Issues: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4321280 bytes in 13 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation rabbitmq-java-client.noarch: W: file-not-utf8 /usr/share/doc/rabbitmq-java-client/channels/channels.tex Please fix before import
(In reply to gil cattaneo from comment #3) > Issues: > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 4321280 bytes in 13 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation What package is that? I guess rpmlint does not know about javadoc, maybe. > rabbitmq-java-client.noarch: W: file-not-utf8 > /usr/share/doc/rabbitmq-java-client/channels/channels.tex > > Please fix before import This is a tex file for further generation of documentation. I've already thought about converting it to pdf and excluding the tex file and consider it to be just source. What do you think?
(In reply to Raphael Groner from comment #4) … > What package is that? I guess rpmlint does not know about javadoc, maybe. What package is that? I guess fedora-review does not know/care about javadoc, maybe.
(In reply to gil cattaneo from comment #2) rabbitmq-java-client.src: E: specfile-error mvn_install: invalid option -- 'J' rabbitmq-java-client.src: E: specfile-error error: Unknown option J in mvn_install() Huh?
(In reply to Raphael Groner from comment #4) > (In reply to gil cattaneo from comment #3) > > Issues: > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) > > or number of files. > > Note: Documentation size is 4321280 bytes in 13 files. > > See: > > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > What package is that? I guess rpmlint does not know about javadoc, maybe. you must add a sub package e.g. rabbitmq-java-client-doc.noarch > > rabbitmq-java-client.noarch: W: file-not-utf8 > > /usr/share/doc/rabbitmq-java-client/channels/channels.tex > > This is a tex file for further generation of documentation. I've already > thought about converting it to pdf and excluding the tex file and consider > it to be just source. What do you think? would surely be better to generate the documentation files instead of installing the pre compiled, and also do not install the files used for generation of documentation
(In reply to Raphael Groner from comment #6) > (In reply to gil cattaneo from comment #2) > > rabbitmq-java-client.src: E: specfile-error mvn_install: invalid option -- > 'J' > rabbitmq-java-client.src: E: specfile-error error: Unknown option J in > mvn_install() > > Huh? Ignore for the moment. This is a known issue related to non-perfect sync with javapackages-* (macros) and other tools as fedora-review. Ask for more info to Mikolaj Izdebski mizdebsk in (fedora)Java irc channel
3.4.2-2: Spec URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client.spec SRPM URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client-3.4.2-2.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8341154 Thanks for the review!
Please, remove doc folder from %files -f .mfiles %doc LICENSE* README* doc/*
You should install only doc/channels/channels.pdf, the other files are only needed for build this pdf file. channels]$ pdflatex *.tex This is pdfTeX, Version 3.1415926-2.5-1.40.14 (TeX Live 2013) restricted \write18 enabled. entering extended mode (./channels.tex LaTeX2e <2011/06/27> Babel <3.9f> and hyphenation patterns for 2 languages loaded. (/usr/share/texlive/texmf-dist/tex/latex/base/article.cls Document Class: article 2007/10/19 v1.4h Standard LaTeX document class (/usr/share/texlive/texmf-dist/tex/latex/base/size12.clo)) (./zed-cm.sty) (/usr/share/texlive/texmf-dist/tex/latex/graphics/graphicx.sty (/usr/share/texlive/texmf-dist/tex/latex/graphics/keyval.sty) (/usr/share/texlive/texmf-dist/tex/latex/graphics/graphics.sty (/usr/share/texlive/texmf-dist/tex/latex/graphics/trig.sty) (/usr/share/texlive/texmf-dist/tex/latex/latexconfig/graphics.cfg) (/usr/share/texlive/texmf-dist/tex/latex/pdftex-def/pdftex.def (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/infwarerr.sty) (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/ltxcmds.sty)))) No file channels.aux. (/usr/share/texlive/texmf-dist/tex/context/base/supp-pdf.mkii [Loading MPS to PDF converter (version 2006.09.02).] ) (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/pdftexcmds.sty (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/ifluatex.sty) (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/ifpdf.sty)) (/usr/share/texlive/texmf-dist/tex/latex/oberdiek/epstopdf-base.sty (/usr/share/texlive/texmf-dist/tex/latex/oberdiek/grfext.sty (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/kvdefinekeys.sty)) (/usr/share/texlive/texmf-dist/tex/latex/oberdiek/kvoptions.sty (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/kvsetkeys.sty (/usr/share/texlive/texmf-dist/tex/generic/oberdiek/etexcmds.sty))) (/usr/share/texlive/texmf-dist/tex/latex/latexconfig/epstopdf-sys.cfg)) (/usr/share/texlive/texmf-dist/tex/latex/base/ulasy.fd) (/usr/share/texlive/texmf-dist/tex/latex/amsfonts/umsa.fd) (/usr/share/texlive/texmf-dist/tex/latex/amsfonts/umsb.fd) [1{/usr/share/texliv e/texmf-dist/fonts/map/pdftex/updmap/pdftex.map}] No file channels.toc. [2] [1] Underfull \vbox (badness 2809) has occurred while \output is active [2] Overfull \hbox (27.59804pt too wide) in alignment at lines 138--140 [] [3] [4] Overfull \hbox (8.6663pt too wide) in paragraph at lines 197--198 []\OT1/cmr/m/n/10.95 Should we be so in-clined, since the pre-con-di-tions of t he two $\OT1/cmr/m/it/10.95 EndWork$ [5] <worktransition.pdf, id=39, 316.18124pt x 200.75pt> <use worktransition.pdf> LaTeX Warning: Reference `fig:statediag' on page 6 undefined on input line 230. <whiteboard.JPG, id=41, 2601.72pt x 1667.22874pt> <use whiteboard.JPG> LaTeX Warning: Float too large for page by 19.83331pt on input line 242. LaTeX Warning: `h' float specifier changed to `ht'. LaTeX Warning: Reference `fig:whiteboard' on page 6 undefined on input line 243 . [6 <./worktransition.pdf>] [7 <./whiteboard.JPG>] (./channels.aux) LaTeX Warning: There were undefined references. LaTeX Warning: Label(s) may have changed. Rerun to get cross-references right. ) (see the transcript file for additional information)</usr/share/texlive/texmf-d ist/fonts/type1/public/amsfonts/cm/cmbx10.pfb></usr/share/texlive/texmf-dist/fo nts/type1/public/amsfonts/cm/cmbx12.pfb></usr/share/texlive/texmf-dist/fonts/ty pe1/public/amsfonts/cm/cmex10.pfb></usr/share/texlive/texmf-dist/fonts/type1/pu blic/amsfonts/cm/cmmi10.pfb></usr/share/texlive/texmf-dist/fonts/type1/public/a msfonts/cm/cmr10.pfb></usr/share/texlive/texmf-dist/fonts/type1/public/amsfonts /cm/cmr12.pfb></usr/share/texlive/texmf-dist/fonts/type1/public/amsfonts/cm/cmr 17.pfb></usr/share/texlive/texmf-dist/fonts/type1/public/amsfonts/cm/cmsl12.pfb ></usr/share/texlive/texmf-dist/fonts/type1/public/amsfonts/cm/cmss10.pfb></usr /share/texlive/texmf-dist/fonts/type1/public/amsfonts/cm/cmsy10.pfb></usr/share /texlive/texmf-dist/fonts/type1/public/amsfonts/cm/cmsy8.pfb></usr/share/texliv e/texmf-dist/fonts/type1/public/amsfonts/cm/cmti10.pfb></usr/share/texlive/texm f-dist/fonts/type1/public/amsfonts/symbols/msam10.pfb></usr/share/texlive/texmf -dist/fonts/type1/public/amsfonts/symbols/msbm10.pfb> Output written on channels.pdf (9 pages, 2164107 bytes). Transcript written on channels.log.
The pdf is already there (from tarball). So I only convert the tex file to some html (by texi2html). Spec URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client.spec SRPM URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client-3.4.2-3.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8347266 Thanks for the review!
(In reply to Raphael Groner from comment #12) > The pdf is already there (from tarball). So I only convert the tex file to > some html (by texi2html). > Yes, but that file contains only: "This document was generated by ... on December 11, 2014 using texi2html 1.82.". I dont understand what is it usefull ... Also doc/channels/channels.tex doc/channels/whiteboard.JPG doc/channels/worktransition.graffle doc/channels/worktransition.pdf doc/channels/zed-cm.sty are used for regenerate doc/channels/channels.pdf, aren't part of the documentation. Then, you should install only channels.pdf file.
Release #4. Spec URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client.spec SRPM URL: https://raphgro.fedorapeople.org/review/java/rabbitmq/rabbitmq-java-client-3.4.2-4.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8350061 Thanks for the review!
New Package SCM Request ======================= Package Name: rabbitmq-java-client Short Description: Java Advanced Message Queue Protocol client library Upstream URL: http://www.rabbitmq.com/java-client.html Owners: raphgro Branches: f21 InitialCC:
Git done (by process-git-requests).
rabbitmq-java-client-3.4.2-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rabbitmq-java-client-3.4.2-4.fc21
rabbitmq-java-client-3.4.2-4.fc21 has been pushed to the Fedora 21 testing repository.
rabbitmq-java-client-3.4.2-4.fc21 has been pushed to the Fedora 21 stable repository.
Package Change Request ====================== Package Name: rabbitmq-java-client New Branches: epel7 Owners: raphgro InitialCC:
rabbitmq-java-client-3.5.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rabbitmq-java-client-3.5.0-1.el7
rabbitmq-java-client-3.5.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rabbitmq-java-client-3.5.1-1.el7
rabbitmq-java-client-3.5.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.